Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chip-cert Crashes on Failure to Open File. #15731

Conversation

emargolis
Copy link
Contributor

Problem

#15444

Change overview

Fixed

Testing

Manually tested

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

PR #15731: Size comparison from 169b48a to 11faf1e

Increases above 0.2%:

platform target config section 169b48a 11faf1e change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039463 1075751 36288 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700488 728848 28360 4.0
Increases (1 build for nrfconnect)
platform target config section 169b48a 11faf1e change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039463 1075751 36288 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700488 728848 28360 4.0
Full report (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 169b48a 11faf1e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 600022 600022 0 0.0
.app_xip_area 504796 504796 0 0.0
.bss 77908 77908 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 558010 558010 0 0.0
.app_xip_area 464320 464320 0 0.0
.bss 76412 76412 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578430 578430 0 0.0
.app_xip_area 475308 475308 0 0.0
.bss 85516 85516 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 917012 917012 0 0.0
(read/write) 128672 128672 0 0.0
.bss 126616 126616 0 0.0
.data 2056 2056 0 0.0
.text 917004 917004 0 0.0
BRD4161A+rpc (read only) 947080 947080 0 0.0
(read/write) 145616 145616 0 0.0
.bss 143392 143392 0 0.0
.data 2220 2220 0 0.0
.text 947072 947072 0 0.0
lock-app BRD4161A+wf200 (read only) 986812 986812 0 0.0
(read/write) 120432 120432 0 0.0
.bss 118500 118500 0 0.0
.data 1932 1932 0 0.0
.text 986804 986804 0 0.0
window-app BRD4161A (read only) 850940 850940 0 0.0
(read/write) 126908 126908 0 0.0
.bss 124984 124984 0 0.0
.data 1924 1924 0 0.0
.text 850932 850932 0 0.0
esp32 all-clusters-app m5stack (read only) 1005187 1005187 0 0.0
(read/write) 458344 458344 0 0.0
.dram0.bss 68168 68168 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999803 999803 0 0.0
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 692208 692208 0 0.0
.bss 77544 77544 0 0.0
.data 1932 1932 0 0.0
.text 606932 606932 0 0.0
lock k32w061+release (read/write) 695568 695568 0 0.0
.bss 77744 77744 0 0.0
.data 1972 1972 0 0.0
.text 610052 610052 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8723956 8723956 0 0.0
(read/write) 395713 395713 0 0.0
.bss 43617 43617 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 295760 295760 0 0.0
.dynamic 560 560 0 0.0
.got 51368 51368 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 455964 455964 0 0.0
.text 7405684 7405684 0 0.0
thermostat-no-ble arm64 (read only) 2165444 2165444 0 0.0
(read/write) 148657 148657 0 0.0
.bss 65345 65345 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 75064 75064 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133140 133140 0 0.0
.text 1813984 1813984 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350452 2350452 0 0.0
.bss 187156 187156 0 0.0
.data 5784 5784 0 0.0
.text 1313052 1313052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1039463 1075751 36288 3.5
bss 125828 127680 1852 1.5
rodata 135904 141808 5904 4.3
text 700488 728848 28360 4.0
p6 all-clusters-app default (read/write) 2488704 2488704 0 0.0
.bss 118736 118736 0 0.0
.data 2696 2696 0 0.0
.text 1446968 1446968 0 0.0
light-app default (read/write) 2395880 2395880 0 0.0
.bss 113048 113048 0 0.0
.data 2544 2544 0 0.0
.text 1354144 1354144 0 0.0
lock-app default (read/write) 2359392 2359392 0 0.0
.bss 112792 112792 0 0.0
.data 2504 2504 0 0.0
.text 1317656 1317656 0 0.0
qpg lighting-app qpg6105+debug (read only) 601608 601608 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90928 0 0.0
.data 1132 1132 0 0.0
.text 596288 596288 0 0.0
lock-app qpg6105+debug (read only) 567324 567324 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1084 1084 0 0.0
.text 562004 562004 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883698 883698 0 0.0
bss 86408 86408 0 0.0
noinit 37160 37160 0 0.0
text 624478 624478 0 0.0

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking tooling changes

@emargolis emargolis merged commit 5924088 into project-chip:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants