Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] Add device layer commands: start, get, config. #1574

Merged
merged 9 commits into from
Jul 14, 2020
Merged

[shell] Add device layer commands: start, get, config. #1574

merged 9 commits into from
Jul 14, 2020

Conversation

turon
Copy link
Contributor

@turon turon commented Jul 13, 2020 •
edited
Loading

Problem

linux-embedded build of shell example is missing from GN build.
Also, there are no commands yet to start the device layer or interact with the device configuration.

Summary of Changes

Adds an initial linux-embedded target for GN.
Adds device command to shell, with subcommand start, config, and get.

fixes #1573, fixes #1586

@turon turon requested a review from mspang July 13, 2020 13:20
@turon turon force-pushed the pr/shell/device branch from 5459133 to 0966834 Compare July 13, 2020 17:08
@turon turon force-pushed the pr/shell/device branch from 154d894 to e15c2de Compare July 13, 2020 20:22
@turon turon force-pushed the pr/shell/device branch from 83335b0 to 4729ddd Compare July 14, 2020 00:44
rwalker-apple
rwalker-apple reviewed Jul 14, 2020
View reviewed changes
examples/shell/cmd_device.cpp
#include <support/CHIPArgParser.hpp>
#include <support/CHIPMem.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truth be told I'm not sure this is better, because now we have to verify it's not leaking...

rwalker-apple
rwalker-apple approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@rwalker-apple rwalker-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with reservations

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

@turon
Copy link
Contributor Author

turon commented Jul 14, 2020

@woody-apple? @BroderickCarlin?

@woody-apple woody-apple merged commit c10d357 into project-chip:master Jul 14, 2020
@turon turon deleted the pr/shell/device branch July 14, 2020 21:48
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
9efea0b 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
ad05005 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 19, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
06e78b4 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
1a73439 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020
@turon @kedars
[shell] Add device layer commands: start, get, config. (project-chip#…
5861fce 
…1574)

* [shell] Add device layer commands: start, get, config.

* [shell] add shell to default build.

* [shell] Strip out unneeded gni file.

* [shell] Simplified helpers for getting config fields.

* [shell] PR comment resolution.

* [shell] PR comment resolution. Add TODO(project-chip#1586) to stack large bufs.

* [shell] Fix project-chip#1586.

* [shell] add Manufacturer Device config.

* [shell] Delete unused linux config header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang left review comments

@gerickson gerickson gerickson left review comments

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@rwalker-apple rwalker-apple rwalker-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@turon @mspang @gerickson @andy31415 @saurabhst @woody-apple @rwalker-apple