Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScopedNodeId and return it by Session::GetPeer() #16000

Merged
merged 8 commits into from
Mar 24, 2022
Merged

Add ScopedNodeId and return it by Session::GetPeer() #16000

merged 8 commits into from
Mar 24, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Mar 9, 2022 •
edited
Loading

Problem

Tuple<NodeId, FabricIndex> is widely used to identify a unique node locally. Introduce a ScopedNodeId to make it more convenient and readable.

Change overview

  • Add ScopedNodeId class containing Tuple<NodeId, FabricIndex>
  • Add a Session::GetPeer() API for session interface returning a ScopedNodeId

Testing

Passes test-cases.

@restyled-io restyled-io bot mentioned this pull request Mar 9, 2022
Closed
mrjerryjohns
mrjerryjohns reviewed Mar 14, 2022
View reviewed changes
src/lib/core/PeerId.h Outdated Show resolved Hide resolved
mrjerryjohns
mrjerryjohns suggested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@mrjerryjohns mrjerryjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more guidance.

@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited
Loading

PR #16000: Size comparison from b18b03a to 463fff5

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 463fff5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602638 60 0.0
.app_xip_area 509756 509816 60 0.0
lock cyw930739m2evb_01 (read/write) 560430 560490 60 0.0
.app_xip_area 469136 469196 60 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570558 60 0.0
.app_xip_area 469556 469616 60 0.0
efr32 lighting-app BRD4161A (read only) 919652 919720 68 0.0
.text 919644 919712 68 0.0
BRD4161A+rpc (read only) 948440 948524 84 0.0
.text 948432 948516 84 0.0
window-app BRD4161A (read only) 850392 850468 76 0.0
.text 850384 850460 76 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961442 54 0.0
(read/write) 1394938 1394946 8 0.0
.flash.rodata 197776 197784 8 0.0
.flash.text 961388 961442 54 0.0
m5stack (read only) 1017011 1017111 100 0.0
(read/write) 462148 462156 8 0.0
.flash.rodata 226720 226728 8 0.0
.flash.text 1011627 1011727 100 0.0
k32w light k32w061+release (read/write) 699340 699408 68 0.0
.text 614092 614160 68 0.0
lock k32w061+release (read/write) 699644 699704 60 0.0
.text 614384 614444 60 0.0
linux all-clusters-app debug (read only) 2465225 2465657 432 0.0
(read/write) 146352 146384 32 0.0
.data.rel.ro 78728 78760 32 0.0
.text 2091298 2091634 336 0.0
bridge-app debug+rpc (read only) 1749757 1750189 432 0.0
(read/write) 92912 92944 32 0.0
.data.rel.ro 38128 38168 40 0.1
.text 1490901 1491237 336 0.0
chip-tool debug (read only) 10095037 10095605 568 0.0
(read/write) 357680 357712 32 0.0
.data.rel.ro 324864 324912 48 0.0
.text 8798789 8799237 448 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728524 432 0.0
(read/write) 475425 475473 48 0.0
.data.rel.ro 371232 371272 40 0.0
.text 8186052 8186356 304 0.0
door-lock-app debug (read only) 1984385 1984833 448 0.0
(read/write) 119776 119808 32 0.0
.data.rel.ro 62456 62504 48 0.1
.text 1657090 1657442 352 0.0
lighting-app debug+rpc (read only) 2115961 2116393 432 0.0
(read/write) 125160 125192 32 0.0
.data.rel.ro 66408 66440 32 0.0
.text 1789106 1789442 336 0.0
ota-provider-app debug (read only) 1918537 1918969 432 0.0
(read/write) 115536 115568 32 0.0
.data.rel.ro 57816 57832 16 0.0
.text 1603266 1603602 336 0.0
ota-requestor-app debug (read only) 1949249 1949681 432 0.0
(read/write) 118568 118600 32 0.0
.data.rel.ro 59880 59912 32 0.1
.text 1637570 1637906 336 0.0
shell debug (read only) 2411385 2411817 432 0.0
(read/write) 150184 150216 32 0.0
.data.rel.ro 73088 73120 32 0.0
.text 2047762 2048098 336 0.0
thermostat-no-ble arm64 (read only) 2207236 2207572 336 0.0
(read/write) 149377 149409 32 0.0
.data.rel.ro 75368 75400 32 0.0
.text 1851168 1851408 240 0.0
tv-app debug (read only) 2656097 2656665 568 0.0
(read/write) 250776 250808 32 0.0
.data.rel.ro 73800 73824 24 0.0
.text 2277826 2278274 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2352756 2352828 72 0.0
.text 1315356 1315428 72 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154075 64 0.0
rodata 145276 145292 16 0.0
text 786976 787024 48 0.0
p6 all-clusters-app default (read/write) 2492152 2492216 64 0.0
.text 1450416 1450480 64 0.0
light-app default (read/write) 2396000 2396056 56 0.0
.text 1354264 1354320 56 0.0
lock-app default (read/write) 2359544 2359624 80 0.0
.text 1317808 1317888 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893842 72 0.0
text 631868 631922 54 0.0
Decreases (1 build for efr32)
platform target config section b18b03a 463fff5 change % change
efr32 lighting-app BRD4161A+rpc (read/write) 144632 144628 -4 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b18b03a 463fff5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602638 60 0.0
.app_xip_area 509756 509816 60 0.0
.bss 75576 75576 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 560430 560490 60 0.0
.app_xip_area 469136 469196 60 0.0
.bss 74080 74080 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570498 570558 60 0.0
.app_xip_area 469556 469616 60 0.0
.bss 83384 83384 0 0.0
.data 520 520 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919652 919720 68 0.0
(read/write) 128672 128672 0 0.0
.bss 126664 126664 0 0.0
.data 2008 2008 0 0.0
.text 919644 919712 68 0.0
BRD4161A+rpc (read only) 948440 948524 84 0.0
(read/write) 144632 144628 -4 -0.0
.bss 142440 142440 0 0.0
.data 2188 2188 0 0.0
.text 948432 948516 84 0.0
window-app BRD4161A (read only) 850392 850468 76 0.0
(read/write) 126632 126632 0 0.0
.bss 124768 124768 0 0.0
.data 1864 1864 0 0.0
.text 850384 850460 76 0.0
esp32 all-clusters-app c3devkit (read only) 961388 961442 54 0.0
(read/write) 1394938 1394946 8 0.0
.dram0.bss 64056 64056 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 197776 197784 8 0.0
.flash.text 961388 961442 54 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1017011 1017111 100 0.0
(read/write) 462148 462156 8 0.0
.dram0.bss 69576 69576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 226720 226728 8 0.0
.flash.text 1011627 1011727 100 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 699340 699408 68 0.0
.bss 77560 77560 0 0.0
.data 1888 1888 0 0.0
.text 614092 614160 68 0.0
lock k32w061+release (read/write) 699644 699704 60 0.0
.bss 77552 77552 0 0.0
.data 1908 1908 0 0.0
.text 614384 614444 60 0.0
linux all-clusters-app debug (read only) 2465225 2465657 432 0.0
(read/write) 146352 146384 32 0.0
.bss 60640 60640 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78728 78760 32 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 210693 210693 0 0.0
.text 2091298 2091634 336 0.0
bridge-app debug+rpc (read only) 1749757 1750189 432 0.0
(read/write) 92912 92944 32 0.0
.bss 47752 47752 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 38128 38168 40 0.1
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 143308 143308 0 0.0
.text 1490901 1491237 336 0.0
chip-tool debug (read only) 10095037 10095605 568 0.0
(read/write) 357680 357712 32 0.0
.bss 25696 25696 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 324864 324912 48 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514997 514997 0 0.0
.text 8798789 8799237 448 0.0
chip-tool-ipv6only arm64 (read only) 9728092 9728524 432 0.0
(read/write) 475425 475473 48 0.0
.bss 44017 44017 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371232 371272 40 0.0
.dynamic 560 560 0 0.0
.got 55256 55256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492196 492196 0 0.0
.text 8186052 8186356 304 0.0
door-lock-app debug (read only) 1984385 1984833 448 0.0
(read/write) 119776 119808 32 0.0
.bss 50944 50944 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62456 62504 48 0.1
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 178396 178396 0 0.0
.text 1657090 1657442 352 0.0
lighting-app debug+rpc (read only) 2115961 2116393 432 0.0
(read/write) 125160 125192 32 0.0
.bss 51776 51776 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66408 66440 32 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 170940 170940 0 0.0
.text 1789106 1789442 336 0.0
ota-provider-app debug (read only) 1918537 1918969 432 0.0
(read/write) 115536 115568 32 0.0
.bss 50816 50816 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57816 57832 16 0.0
.dynamic 608 608 0 0.0
.got 4360 4360 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 164267 164267 0 0.0
.text 1603266 1603602 336 0.0
ota-requestor-app debug (read only) 1949249 1949681 432 0.0
(read/write) 118568 118600 32 0.0
.bss 51840 51840 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 59880 59912 32 0.1
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160452 160452 0 0.0
.text 1637570 1637906 336 0.0
shell debug (read only) 2411385 2411817 432 0.0
(read/write) 150184 150216 32 0.0
.bss 70600 70600 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73088 73120 32 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 207474 207474 0 0.0
.text 2047762 2048098 336 0.0
thermostat-no-ble arm64 (read only) 2207236 2207572 336 0.0
(read/write) 149377 149409 32 0.0
.bss 65649 65649 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75368 75400 32 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 136756 136756 0 0.0
.text 1851168 1851408 240 0.0
tv-app debug (read only) 2656097 2656665 568 0.0
(read/write) 250776 250808 32 0.0
.bss 167840 167840 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 73800 73824 24 0.0
.dynamic 592 592 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 204213 204213 0 0.0
.text 2277826 2278274 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2352756 2352828 72 0.0
.bss 186652 186652 0 0.0
.data 5752 5752 0 0.0
.text 1315356 1315428 72 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154011 1154075 64 0.0
bss 146644 146644 0 0.0
rodata 145276 145292 16 0.0
text 786976 787024 48 0.0
p6 all-clusters-app default (read/write) 2492152 2492216 64 0.0
.bss 120080 120080 0 0.0
.data 2632 2632 0 0.0
.text 1450416 1450480 64 0.0
light-app default (read/write) 2396000 2396056 56 0.0
.bss 113544 113544 0 0.0
.data 2488 2488 0 0.0
.text 1354264 1354320 56 0.0
lock-app default (read/write) 2359544 2359624 80 0.0
.bss 113288 113288 0 0.0
.data 2448 2448 0 0.0
.text 1317808 1317888 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 893770 893842 72 0.0
bss 87432 87432 0 0.0
noinit 37160 37160 0 0.0
text 631868 631922 54 0.0

andy31415 and others added 2 commits March 23, 2022 09:50
@andy31415 @mrjerryjohns
Update src/lib/core/ScopedNodeId.h
760ea8e 
Co-authored-by: Jerry Johns <johnsj@google.com>
@andy31415
Restyle
2393bc4
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16000: Size comparison from ed8d8cf to f271b9f

Increases (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ed8d8cf f271b9f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603546 68 0.0
.app_xip_area 510576 510644 68 0.0
lock cyw930739m2evb_01 (read/write) 561274 561342 68 0.0
.app_xip_area 469900 469968 68 0.0
efr32 lighting-app BRD4161A (read only) 922300 922368 68 0.0
(read/write) 128756 128760 4 0.0
.text 922292 922360 68 0.0
BRD4161A+rpc (read only) 951128 951196 68 0.0
.text 951120 951188 68 0.0
window-app BRD4161A (read only) 852660 852736 76 0.0
.text 852652 852728 76 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964212 56 0.0
(read/write) 1393714 1393738 24 0.0
.flash.rodata 198536 198560 24 0.0
.flash.text 964156 964212 56 0.0
m5stack (read only) 1020687 1020783 96 0.0
(read/write) 461492 461500 8 0.0
.flash.rodata 228040 228048 8 0.0
.flash.text 1015303 1015399 96 0.0
k32w light k32w061+release (read/write) 701120 701180 60 0.0
.text 615796 615856 60 0.0
lock k32w061+release (read/write) 701088 701156 68 0.0
.text 615756 615824 68 0.0
linux chip-tool-ipv6only arm64 (read only) 9785084 9785500 416 0.0
(read/write) 472961 472993 32 0.0
.data.rel.ro 371880 371920 40 0.0
.text 8238692 8238996 304 0.0
thermostat-no-ble arm64 (read only) 2262692 2263028 336 0.0
(read/write) 148273 148305 32 0.0
.data.rel.ro 77000 77032 32 0.0
.text 1899600 1899840 240 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353636 2353724 88 0.0
.text 1316236 1316324 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1138947 1139011 64 0.0
rodata 141516 141532 16 0.0
text 780084 780132 48 0.0
p6 all-clusters-app default (read/write) 2493592 2493672 80 0.0
.text 1451856 1451936 80 0.0
light-app default (read/write) 2396776 2396840 64 0.0
.text 1355040 1355104 64 0.0
lock-app default (read/write) 2360312 2360368 56 0.0
.text 1318576 1318632 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 897026 72 0.0
text 634304 634360 56 0.0
Decreases (1 build for cyw30739)
platform target config section ed8d8cf f271b9f change % change
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572806 572790 -16 -0.0
.app_xip_area 471784 471768 -16 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ed8d8cf f271b9f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603546 68 0.0
.app_xip_area 510576 510644 68 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561274 561342 68 0.0
.app_xip_area 469900 469968 68 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572806 572790 -16 -0.0
.app_xip_area 471784 471768 -16 -0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922300 922368 68 0.0
(read/write) 128756 128760 4 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922292 922360 68 0.0
BRD4161A+rpc (read only) 951128 951196 68 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951120 951188 68 0.0
window-app BRD4161A (read only) 852660 852736 76 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852652 852728 76 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964212 56 0.0
(read/write) 1393714 1393738 24 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198536 198560 24 0.0
.flash.text 964156 964212 56 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020687 1020783 96 0.0
(read/write) 461492 461500 8 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228040 228048 8 0.0
.flash.text 1015303 1015399 96 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701120 701180 60 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615796 615856 60 0.0
lock k32w061+release (read/write) 701088 701156 68 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615756 615824 68 0.0
linux chip-tool-ipv6only arm64 (read only) 9785084 9785500 416 0.0
(read/write) 472961 472993 32 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371920 40 0.0
.dynamic 560 560 0 0.0
.got 55528 55528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494308 494308 0 0.0
.text 8238692 8238996 304 0.0
thermostat-no-ble arm64 (read only) 2262692 2263028 336 0.0
(read/write) 148273 148305 32 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77032 32 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899600 1899840 240 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353724 88 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316236 1316324 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1138947 1139011 64 0.0
bss 142588 142588 0 0.0
rodata 141516 141532 16 0.0
text 780084 780132 48 0.0
p6 all-clusters-app default (read/write) 2493592 2493672 80 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451856 1451936 80 0.0
light-app default (read/write) 2396776 2396840 64 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355040 1355104 64 0.0
lock-app default (read/write) 2360312 2360368 56 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318576 1318632 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 897026 72 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634360 56 0.0

@andy31415
Copy link
Contributor

/rebase

@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 23, 2022
Merged
@andy31415
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Mar 24, 2022 •
edited
Loading

PR #16000: Size comparison from 1f3467e to 1fd5dfe

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f3467e 1fd5dfe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603334 603402 68 0.0
.app_xip_area 510424 510492 68 0.0
lock cyw930739m2evb_01 (read/write) 561122 561190 68 0.0
.app_xip_area 469740 469808 68 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573206 573266 60 0.0
.app_xip_area 472176 472236 60 0.0
efr32 lighting-app BRD4161A (read only) 922876 922952 76 0.0
(read/write) 128756 128760 4 0.0
.text 922868 922944 76 0.0
BRD4161A+rpc (read only) 951684 951768 84 0.0
.text 951676 951760 84 0.0
window-app BRD4161A (read only) 852680 852740 60 0.0
.text 852672 852732 60 0.0
esp32 all-clusters-app c3devkit (read only) 964186 964240 54 0.0
(read/write) 1393842 1393866 24 0.0
.flash.rodata 198648 198672 24 0.0
.flash.text 964186 964240 54 0.0
m5stack (read only) 1020723 1020743 20 0.0
(read/write) 461620 461628 8 0.0
.flash.rodata 228160 228168 8 0.0
.flash.text 1015339 1015359 20 0.0
k32w light k32w061+release (read/write) 701500 701560 60 0.0
.text 616176 616236 60 0.0
lock k32w061+release (read/write) 700936 701004 68 0.0
.text 615596 615664 68 0.0
linux all-clusters-app debug (read only) 2478273 2478705 432 0.0
(read/write) 143184 143216 32 0.0
.data.rel.ro 78872 78904 32 0.0
.text 2103026 2103362 336 0.0
bridge-app debug+rpc (read only) 1753061 1753493 432 0.0
(read/write) 89424 89456 32 0.0
.data.rel.ro 37912 37936 24 0.1
.text 1493621 1493957 336 0.0
chip-tool debug (read only) 10186893 10187461 568 0.0
(read/write) 355072 355104 32 0.0
.data.rel.ro 325496 325544 48 0.0
.text 8883301 8883749 448 0.0
chip-tool-ipv6only arm64 (read only) 9806636 9807052 416 0.0
(read/write) 473297 473329 32 0.0
.data.rel.ro 371968 372008 40 0.0
.text 8258020 8258324 304 0.0
door-lock-app debug (read only) 2005121 2005569 448 0.0
.data.rel.ro 62824 62840 16 0.0
.text 1674578 1674930 352 0.0
lighting-app debug+rpc (read only) 2178497 2178929 432 0.0
(read/write) 123760 123792 32 0.0
.data.rel.ro 67896 67928 32 0.0
.text 1844610 1844946 336 0.0
ota-provider-app debug (read only) 1946169 1946617 448 0.0
.data.rel.ro 58168 58184 16 0.0
.text 1627826 1628178 352 0.0
ota-requestor-app debug (read only) 1972977 1973425 448 0.0
.data.rel.ro 60392 60408 16 0.0
.text 1657730 1658082 352 0.0
shell debug (read only) 2427633 2428081 448 0.0
(read/write) 147240 147272 32 0.0
.data.rel.ro 73504 73536 32 0.0
.text 2061682 2062034 352 0.0
thermostat-no-ble arm64 (read only) 2262588 2262924 336 0.0
(read/write) 148257 148289 32 0.0
.data.rel.ro 76968 77000 32 0.0
.text 1899776 1900016 240 0.0
tv-app debug (read only) 2678929 2679497 568 0.0
(read/write) 247712 247776 64 0.0
.data.rel.ro 74104 74160 56 0.1
.text 2297250 2297698 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2353428 2353508 80 0.0
.text 1316028 1316108 80 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139283 1139347 64 0.0
rodata 141508 141524 16 0.0
text 780416 780464 48 0.0
p6 all-clusters-app default (read/write) 2493816 2493896 80 0.0
.text 1452080 1452160 80 0.0
light-app default (read/write) 2396752 2396840 88 0.0
.text 1355016 1355104 88 0.0
lock-app default (read/write) 2360288 2360368 80 0.0
.text 1318552 1318632 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 896794 896866 72 0.0
text 634212 634266 54 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f3467e 1fd5dfe change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603334 603402 68 0.0
.app_xip_area 510424 510492 68 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561122 561190 68 0.0
.app_xip_area 469740 469808 68 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573206 573266 60 0.0
.app_xip_area 472176 472236 60 0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922952 76 0.0
(read/write) 128756 128760 4 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922944 76 0.0
BRD4161A+rpc (read only) 951684 951768 84 0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951676 951760 84 0.0
window-app BRD4161A (read only) 852680 852740 60 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852672 852732 60 0.0
esp32 all-clusters-app c3devkit (read only) 964186 964240 54 0.0
(read/write) 1393842 1393866 24 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 198648 198672 24 0.0
.flash.text 964186 964240 54 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020723 1020743 20 0.0
(read/write) 461620 461628 8 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228160 228168 8 0.0
.flash.text 1015339 1015359 20 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701500 701560 60 0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616176 616236 60 0.0
lock k32w061+release (read/write) 700936 701004 68 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615596 615664 68 0.0
linux all-clusters-app debug (read only) 2478273 2478705 432 0.0
(read/write) 143184 143216 32 0.0
.bss 57312 57312 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78872 78904 32 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211845 211845 0 0.0
.text 2103026 2103362 336 0.0
bridge-app debug+rpc (read only) 1753061 1753493 432 0.0
(read/write) 89424 89456 32 0.0
.bss 44456 44456 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37912 37936 24 0.1
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144300 144300 0 0.0
.text 1493621 1493957 336 0.0
chip-tool debug (read only) 10186893 10187461 568 0.0
(read/write) 355072 355104 32 0.0
.bss 22400 22400 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325496 325544 48 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520405 520405 0 0.0
.text 8883301 8883749 448 0.0
chip-tool-ipv6only arm64 (read only) 9806636 9807052 416 0.0
(read/write) 473297 473329 32 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 371968 372008 40 0.0
.dynamic 560 560 0 0.0
.got 55704 55704 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 495780 495780 0 0.0
.text 8258020 8258324 304 0.0
door-lock-app debug (read only) 2005121 2005569 448 0.0
(read/write) 116800 116800 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62824 62840 16 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180956 180956 0 0.0
.text 1674578 1674930 352 0.0
lighting-app debug+rpc (read only) 2178497 2178929 432 0.0
(read/write) 123760 123792 32 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67896 67928 32 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174940 174940 0 0.0
.text 1844610 1844946 336 0.0
ota-provider-app debug (read only) 1946169 1946617 448 0.0
(read/write) 112528 112528 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58168 58184 16 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166699 166699 0 0.0
.text 1627826 1628178 352 0.0
ota-requestor-app debug (read only) 1972977 1973425 448 0.0
(read/write) 115784 115784 0 0.0
.bss 48448 48448 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60392 60408 16 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162692 162692 0 0.0
.text 1657730 1658082 352 0.0
shell debug (read only) 2427633 2428081 448 0.0
(read/write) 147240 147272 32 0.0
.bss 67240 67240 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73504 73536 32 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209298 209298 0 0.0
.text 2061682 2062034 352 0.0
thermostat-no-ble arm64 (read only) 2262588 2262924 336 0.0
(read/write) 148257 148289 32 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76968 77000 32 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139564 139564 0 0.0
.text 1899776 1900016 240 0.0
tv-app debug (read only) 2678929 2679497 568 0.0
(read/write) 247712 247776 64 0.0
.bss 164416 164416 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74104 74160 56 0.1
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206901 206901 0 0.0
.text 2297250 2297698 448 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353428 2353508 80 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316028 1316108 80 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139283 1139347 64 0.0
bss 142588 142588 0 0.0
rodata 141508 141524 16 0.0
text 780416 780464 48 0.0
p6 all-clusters-app default (read/write) 2493816 2493896 80 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1452080 1452160 80 0.0
light-app default (read/write) 2396752 2396840 88 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355016 1355104 88 0.0
lock-app default (read/write) 2360288 2360368 80 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318552 1318632 80 0.0
telink lighting-app tlsr9518adk80d (read/write) 896794 896866 72 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634212 634266 54 0.0

@bzbarsky-apple bzbarsky-apple merged commit dcb6609 into project-chip:master Mar 24, 2022
@kghost kghost deleted the node-id branch March 24, 2022 10:19
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@kghost @andy31415
@mrjerryjohns @andrei-menzopol
Add ScopedNodeId and return it by Session::GetPeer() (project-chip#16000
38bf43a 
)

* Add ScopedNodeId and return it by Session::GetPeer()

* Move ScopedNodeId to a new file

* Add guidance about PeerId class

* Update src/lib/core/ScopedNodeId.h

Co-authored-by: Jerry Johns <johnsj@google.com>

* Restyle

* Undo Progress/Error delta in logging

Co-authored-by: Andrei Litvin <andy314@gmail.com>
Co-authored-by: Jerry Johns <johnsj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app lib openthread platform review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kghost @andy31415 @msandstedt @mrjerryjohns @cecille @bzbarsky-apple