Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTA] Reset instead of cancel when auto-apply is off #16588

Conversation

carol-apple
Copy link
Contributor

Problem

By the time UpdateDownloaded is called, the download has already completed and there is no need to cancel the download

Change overview

  • Call Reset to ensure sure the state is transitioned to idle

Testing

  • Verified that without the --autoApplyImage, after image download, the current update state is idle and another query image can be initated

- By the time UpdateDownloaded is called, the download has already completed and there is no need to cancel the download
- Reset will make sure the state is transitioned to idle
@github-actions
Copy link

github-actions bot commented Mar 23, 2022

PR #16588: Size comparison from 395bb1f to d5f8269

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 395bb1f d5f8269 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603470 603470 0 0.0
.app_xip_area 510560 510560 0 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561266 561266 0 0.0
.app_xip_area 469884 469884 0 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573350 573350 0 0.0
.app_xip_area 472320 472320 0 0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922876 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922868 0 0.0
BRD4161A+rpc (read only) 951692 951692 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951684 951684 0 0.0
window-app BRD4161A (read only) 852656 852656 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852648 852648 0 0.0
esp32 all-clusters-app c3devkit (read only) 964154 964154 0 0.0
(read/write) 1393730 1393730 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198536 198536 0 0.0
.flash.text 964154 964154 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020691 1020691 0 0.0
(read/write) 461500 461500 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228040 228040 0 0.0
.flash.text 1015307 1015307 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701644 701644 0 0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616320 616320 0 0.0
lock k32w061+release (read/write) 701080 701080 0 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615740 615740 0 0.0
linux all-clusters-app debug (read only) 2478273 2478273 0 0.0
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 211941 0 0.0
.text 2102834 2102834 0 0.0
bridge-app debug+rpc (read only) 1753317 1753317 0 0.0
(read/write) 89456 89456 0 0.0
.bss 44456 44456 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144556 0 0.0
.text 1493525 1493525 0 0.0
chip-tool debug (read only) 10187517 10187517 0 0.0
(read/write) 355136 355136 0 0.0
.bss 22400 22400 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325560 325560 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520725 520725 0 0.0
.text 8883509 8883509 0 0.0
chip-tool-ipv6only arm64 (read only) 9807276 9807276 0 0.0
(read/write) 473313 473313 0 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372000 372000 0 0.0
.dynamic 560 560 0 0.0
.got 55696 55696 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496036 496036 0 0.0
.text 8258340 8258340 0 0.0
door-lock-app debug (read only) 2005073 2005073 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 180988 0 0.0
.text 1674402 1674402 0 0.0
lighting-app debug+rpc (read only) 2178721 2178721 0 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175164 0 0.0
.text 1844514 1844514 0 0.0
ota-provider-app debug (read only) 1946473 1946473 0 0.0
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 166987 0 0.0
.text 1627746 1627746 0 0.0
ota-requestor-app debug (read only) 1973281 1973281 0 0.0
(read/write) 115816 115816 0 0.0
.bss 48448 48448 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60424 60424 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 162980 0 0.0
.text 1657650 1657650 0 0.0
shell debug (read only) 2427617 2427617 0 0.0
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209362 0 0.0
.text 2061506 2061506 0 0.0
thermostat-no-ble arm64 (read only) 2262660 2262660 0 0.0
(read/write) 148289 148289 0 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899536 1899536 0 0.0
tv-app debug (read only) 2679201 2679201 0 0.0
(read/write) 247776 247776 0 0.0
.bss 164416 164416 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207157 0 0.0
.text 2297170 2297170 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316236 1316236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139459 1139459 0 0.0
bss 142588 142588 0 0.0
rodata 141588 141588 0 0.0
text 780508 780508 0 0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396760 2396760 0 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355024 1355024 0 0.0
lock-app default (read/write) 2360296 2360296 0 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318560 1318560 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896954 0 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634296 634296 0 0.0

@carol-apple carol-apple merged commit 1f3467e into project-chip:master Mar 23, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
)

- By the time UpdateDownloaded is called, the download has already completed and there is no need to cancel the download
- Reset will make sure the state is transitioned to idle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants