Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension attribute to access control cluster #17008

Merged
merged 6 commits into from
Apr 5, 2022
Merged

Add extension attribute to access control cluster #17008

merged 6 commits into from
Apr 5, 2022

Conversation

mlepage-google
Copy link
Contributor

@mlepage-google mlepage-google commented Apr 4, 2022 •
edited
Loading

Problem

Issue #10252 extension attribute for access control cluster

Change overview

Includes attribute and corresponding events. Does not include fabric removal.

Testing

  • Ran chip-all-clusters-app and chip-tool on Linux
  • Tested writing extension for two fabrics
  • Tested reading extension (fabric filtered and not fabric filtered)
  • Tested extension data too big (failed as expected)
  • Tested writing multiple items in list for one fabric (failed as expected)
  • Tested events properly sent when writing extensions

@mlepage-google
Add extension attribute to access control cluster
ebddcdd 
Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252
@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17008: Size comparison from 7ab6653 to ebddcdd

Increases above 0.2%:

platform target config section 7ab6653 ebddcdd change % change
linux thermostat-no-ble arm64 (read only) 2311676 2317628 5952 0.3
.text 1943232 1949104 5872 0.3
Increases (10 builds for k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 ebddcdd change % change
k32w light k32w061+release (read/write) 707852 709180 1328 0.2
.text 622240 623568 1328 0.2
lock k32w061+release (read/write) 707260 708588 1328 0.2
.text 621624 622952 1328 0.2
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10037980 96 0.0
.text 8466420 8466516 96 0.0
thermostat-no-ble arm64 (read only) 2311676 2317628 5952 0.3
(read/write) 149249 149265 16 0.0
.data.rel.ro 77656 77680 24 0.0
.rodata 142972 143020 48 0.0
.text 1943232 1949104 5872 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2359932 2361244 1312 0.1
.text 1322532 1323844 1312 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1150071 1336 0.1
rodata 143328 143416 88 0.1
text 787512 788752 1240 0.2
p6 all-clusters-app default (read/write) 2504488 2505960 1472 0.1
.text 1462752 1464224 1472 0.1
light-app default (read/write) 2405648 2407120 1472 0.1
.text 1363912 1365384 1472 0.1
lock-app default (read/write) 2369280 2370752 1472 0.1
.text 1327544 1329016 1472 0.1
telink lighting-app tlsr9518adk80d (read/write) 792052 793456 1404 0.2
text 561924 563226 1302 0.2
Full report (10 builds for k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 ebddcdd change % change
k32w light k32w061+release (read/write) 707852 709180 1328 0.2
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622240 623568 1328 0.2
lock k32w061+release (read/write) 707260 708588 1328 0.2
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621624 622952 1328 0.2
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10037980 96 0.0
(read/write) 478337 478337 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376288 376288 0 0.0
.dynamic 560 560 0 0.0
.got 56784 56784 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506604 506604 0 0.0
.text 8466420 8466516 96 0.0
thermostat-no-ble arm64 (read only) 2311676 2317628 5952 0.3
(read/write) 149249 149265 16 0.0
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77656 77680 24 0.0
.dynamic 560 560 0 0.0
.got 4584 4584 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142972 143020 48 0.0
.text 1943232 1949104 5872 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359932 2361244 1312 0.1
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322532 1323844 1312 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1150071 1336 0.1
bss 143048 143048 0 0.0
rodata 143328 143416 88 0.1
text 787512 788752 1240 0.2
p6 all-clusters-app default (read/write) 2504488 2505960 1472 0.1
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462752 1464224 1472 0.1
light-app default (read/write) 2405648 2407120 1472 0.1
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1363912 1365384 1472 0.1
lock-app default (read/write) 2369280 2370752 1472 0.1
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327544 1329016 1472 0.1
telink lighting-app tlsr9518adk80d (read/write) 792052 793456 1404 0.2
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 561924 563226 1302 0.2

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17008: Size comparison from 7ab6653 to 2cac609

Increases above 0.2%:

platform target config section 7ab6653 2cac609 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 .data 3128 3164 36 1.2
lock-mtd LP_CC2652R7 .data 3128 3164 36 1.2
.text 537072 538448 1376 0.3
pump-app LP_CC2652R7 .data 3160 3196 36 1.1
pump-controller-app LP_CC2652R7 .data 3124 3160 36 1.2
efr32 lighting-app BRD4161A .data 1956 1992 36 1.8
BRD4161A+rpc .data 2136 2172 36 1.7
window-app BRD4161A .data 1836 1872 36 2.0
k32w light k32w061+release .data 1868 1904 36 1.9
lock k32w061+release .data 1908 1944 36 1.9
linux all-clusters-app debug (read only) 2577057 2586041 8984 0.3
.data 1328 1440 112 8.4
.text 2188786 2197346 8560 0.4
bridge-app debug+rpc (read only) 1787533 1796341 8808 0.5
.data 1984 2048 64 3.2
.text 1524261 1532709 8448 0.6
door-lock-app debug (read only) 2058361 2067329 8968 0.4
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.text 1719938 1728482 8544 0.5
lighting-app debug+rpc (read only) 2236593 2245561 8968 0.4
.data 1504 1600 96 6.4
.text 1894562 1903106 8544 0.5
ota-provider-app debug (read only) 1996401 2005337 8936 0.4
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.text 1671218 1679762 8544 0.5
ota-requestor-app debug (read only) 2025433 2034385 8952 0.4
.data 1544 1608 64 4.1
.text 1702114 1710642 8528 0.5
shell debug (read only) 2474417 2483337 8920 0.4
.data 784 848 64 8.2
.text 2103810 2112338 8528 0.4
thermostat-no-ble arm64 (read only) 2311676 2318652 6976 0.3
.data 1072 1136 64 6.0
.got 4584 4624 40 0.9
.text 1943232 1949936 6704 0.3
tv-app debug (read only) 2740761 2749681 8920 0.3
.data 3296 3392 96 2.9
.text 2352002 2360562 8560 0.4
mbed lock-app CY8CPROTO_062_4343W+release .data 5752 5784 32 0.6
p6 all-clusters-app default .data 2632 2672 40 1.5
light-app default .data 2488 2528 40 1.6
lock-app default .data 2448 2488 40 1.6
telink lighting-app tlsr9518adk80d text 561924 563370 1446 0.3
Increases (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 2cac609 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 669411 1368 0.2
.bss 81736 81752 16 0.0
.data 3128 3164 36 1.2
.text 587840 589216 1376 0.2
lock-mtd LP_CC2652R7 (read only) 617163 618539 1376 0.2
(read/write) 154448 154500 52 0.0
.bss 77464 77480 16 0.0
.data 3128 3164 36 1.2
.text 537072 538448 1376 0.3
pump-app LP_CC2652R7 (read only) 687495 688863 1368 0.2
.bss 82128 82152 24 0.0
.data 3160 3196 36 1.1
.rodata 81791 81807 16 0.0
.text 605220 606572 1352 0.2
pump-controller-app LP_CC2652R7 (read only) 669703 671111 1408 0.2
.bss 81872 81888 16 0.0
.data 3124 3160 36 1.2
.rodata 78127 78143 16 0.0
.text 591092 592484 1392 0.2
efr32 lighting-app BRD4161A (read only) 916048 917576 1528 0.2
(read/write) 129728 129784 56 0.0
.bss 127768 127792 24 0.0
.data 1956 1992 36 1.8
.text 916040 917568 1528 0.2
BRD4161A+rpc (read only) 943944 945480 1536 0.2
(read/write) 145680 145736 56 0.0
.bss 143544 143560 16 0.0
.data 2136 2172 36 1.7
.text 943936 945472 1536 0.2
window-app BRD4161A (read only) 851360 852896 1536 0.2
(read/write) 127752 127808 56 0.0
.bss 125912 125936 24 0.0
.data 1836 1872 36 2.0
.text 851352 852888 1536 0.2
esp32 all-clusters-app c3devkit (read only) 985618 987164 1546 0.2
(read/write) 1460570 1460578 8 0.0
.dram0.bss 62920 62944 24 0.0
.dram0.data 14164 14196 32 0.2
.flash.text 985618 987164 1546 0.2
m5stack (read only) 1038235 1039611 1376 0.1
(read/write) 461584 461608 24 0.0
.dram0.bss 68448 68472 24 0.0
.dram0.data 34024 34056 32 0.1
.flash.text 1032851 1034227 1376 0.1
k32w light k32w061+release (read/write) 707852 709276 1424 0.2
.bss 77944 77952 8 0.0
.data 1868 1904 36 1.9
.text 622240 623620 1380 0.2
lock k32w061+release (read/write) 707260 708700 1440 0.2
.bss 77928 77952 24 0.0
.data 1908 1944 36 1.9
.text 621624 623004 1380 0.2
linux all-clusters-app debug (read only) 2577057 2586041 8984 0.3
(read/write) 144488 144744 256 0.2
.bss 57536 57632 96 0.2
.data 1328 1440 112 8.4
.data.rel.ro 79736 79784 48 0.1
.rodata 220613 220869 256 0.1
.text 2188786 2197346 8560 0.4
bridge-app debug+rpc (read only) 1787533 1796341 8808 0.5
(read/write) 90040 90200 160 0.2
.bss 44520 44552 32 0.1
.data 1984 2048 64 3.2
.data.rel.ro 38448 38520 72 0.2
.rodata 147001 147193 192 0.1
.text 1524261 1532709 8448 0.6
chip-tool debug (read only) 10437245 10437309 64 0.0
.text 9112293 9112357 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10037980 96 0.0
.text 8466420 8466516 96 0.0
door-lock-app debug (read only) 2058361 2067329 8968 0.4
(read/write) 117936 118160 224 0.2
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.data.rel.ro 63544 63592 48 0.1
.rodata 184969 185225 256 0.1
.text 1719938 1728482 8544 0.5
lighting-app debug+rpc (read only) 2236593 2245561 8968 0.4
(read/write) 124928 125152 224 0.2
.bss 49120 49184 64 0.1
.data 1504 1600 96 6.4
.data.rel.ro 68616 68680 64 0.1
.rodata 179113 179369 256 0.1
.text 1894562 1903106 8544 0.5
ota-provider-app debug (read only) 1996401 2005337 8936 0.4
(read/write) 113536 113760 224 0.2
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.data.rel.ro 58856 58936 80 0.1
.rodata 170819 171043 224 0.1
.text 1671218 1679762 8544 0.5
ota-requestor-app debug (read only) 2025433 2034385 8952 0.4
(read/write) 116792 117016 224 0.2
.bss 48608 48704 96 0.2
.data 1544 1608 64 4.1
.data.rel.ro 61064 61128 64 0.1
.rodata 167276 167532 256 0.2
.text 1702114 1710642 8528 0.5
shell debug (read only) 2474417 2483337 8920 0.4
(read/write) 148016 148208 192 0.1
.bss 67240 67304 64 0.1
.data 784 848 64 8.2
.data.rel.ro 74264 74328 64 0.1
.rodata 212434 212658 224 0.1
.text 2103810 2112338 8528 0.4
thermostat-no-ble arm64 (read only) 2311676 2318652 6976 0.3
(read/write) 149249 149393 144 0.1
.bss 62913 62945 32 0.1
.data 1072 1136 64 6.0
.data.rel.ro 77656 77664 8 0.0
.got 4584 4624 40 0.9
.rodata 142972 143100 128 0.1
.text 1943232 1949936 6704 0.3
tv-app debug (read only) 2740761 2749681 8920 0.3
(read/write) 249440 249664 224 0.1
.bss 165200 165264 64 0.0
.data 3296 3392 96 2.9
.data.rel.ro 74776 74848 72 0.1
.rodata 210699 210891 192 0.1
.text 2352002 2360562 8560 0.4
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2359932 2361516 1584 0.1
.bss 185020 185036 16 0.0
.data 5752 5784 32 0.6
.text 1322532 1324116 1584 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1150119 1384 0.1
bss 143048 143060 12 0.0
text 787512 788852 1340 0.2
p6 all-clusters-app default (read/write) 2504488 2505904 1416 0.1
.bss 118456 118472 16 0.0
.data 2632 2672 40 1.5
.text 1462752 1464168 1416 0.1
light-app default (read/write) 2405648 2407064 1416 0.1
.bss 111912 111928 16 0.0
.data 2488 2528 40 1.6
.text 1363912 1365328 1416 0.1
lock-app default (read/write) 2369280 2370720 1440 0.1
.bss 111656 111672 16 0.0
.data 2448 2488 40 1.6
.text 1327544 1328984 1440 0.1
telink lighting-app tlsr9518adk80d (read/write) 792052 793560 1508 0.2
bss 70264 70288 24 0.0
text 561924 563370 1446 0.3
Decreases (5 builds for cc13x2_26x2, esp32)
platform target config section 7ab6653 2cac609 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183652 182300 -1352 -0.7
.rodata 79723 79715 -8 -0.0
pump-app LP_CC2652R7 (read/write) 165360 164016 -1344 -0.8
pump-controller-app LP_CC2652R7 (read/write) 182896 181504 -1392 -0.8
esp32 all-clusters-app c3devkit .flash.rodata 198000 197960 -40 -0.0
m5stack .flash.rodata 226968 226936 -32 -0.0
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 2cac609 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 669411 1368 0.2
(read/write) 183652 182300 -1352 -0.7
.bss 81736 81752 16 0.0
.data 3128 3164 36 1.2
.rodata 79723 79715 -8 -0.0
.text 587840 589216 1376 0.2
lock-mtd LP_CC2652R7 (read only) 617163 618539 1376 0.2
(read/write) 154448 154500 52 0.0
.bss 77464 77480 16 0.0
.data 3128 3164 36 1.2
.rodata 79603 79603 0 0.0
.text 537072 538448 1376 0.3
pump-app LP_CC2652R7 (read only) 687495 688863 1368 0.2
(read/write) 165360 164016 -1344 -0.8
.bss 82128 82152 24 0.0
.data 3160 3196 36 1.1
.rodata 81791 81807 16 0.0
.text 605220 606572 1352 0.2
pump-controller-app LP_CC2652R7 (read only) 669703 671111 1408 0.2
(read/write) 182896 181504 -1392 -0.8
.bss 81872 81888 16 0.0
.data 3124 3160 36 1.2
.rodata 78127 78143 16 0.0
.text 591092 592484 1392 0.2
efr32 lighting-app BRD4161A (read only) 916048 917576 1528 0.2
(read/write) 129728 129784 56 0.0
.bss 127768 127792 24 0.0
.data 1956 1992 36 1.8
.text 916040 917568 1528 0.2
BRD4161A+rpc (read only) 943944 945480 1536 0.2
(read/write) 145680 145736 56 0.0
.bss 143544 143560 16 0.0
.data 2136 2172 36 1.7
.text 943936 945472 1536 0.2
window-app BRD4161A (read only) 851360 852896 1536 0.2
(read/write) 127752 127808 56 0.0
.bss 125912 125936 24 0.0
.data 1836 1872 36 2.0
.text 851352 852888 1536 0.2
esp32 all-clusters-app c3devkit (read only) 985618 987164 1546 0.2
(read/write) 1460570 1460578 8 0.0
.dram0.bss 62920 62944 24 0.0
.dram0.data 14164 14196 32 0.2
.flash.rodata 198000 197960 -40 -0.0
.flash.text 985618 987164 1546 0.2
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038235 1039611 1376 0.1
(read/write) 461584 461608 24 0.0
.dram0.bss 68448 68472 24 0.0
.dram0.data 34024 34056 32 0.1
.flash.rodata 226968 226936 -32 -0.0
.flash.text 1032851 1034227 1376 0.1
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707852 709276 1424 0.2
.bss 77944 77952 8 0.0
.data 1868 1904 36 1.9
.text 622240 623620 1380 0.2
lock k32w061+release (read/write) 707260 708700 1440 0.2
.bss 77928 77952 24 0.0
.data 1908 1944 36 1.9
.text 621624 623004 1380 0.2
linux all-clusters-app debug (read only) 2577057 2586041 8984 0.3
(read/write) 144488 144744 256 0.2
.bss 57536 57632 96 0.2
.data 1328 1440 112 8.4
.data.rel.ro 79736 79784 48 0.1
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220613 220869 256 0.1
.text 2188786 2197346 8560 0.4
bridge-app debug+rpc (read only) 1787533 1796341 8808 0.5
(read/write) 90040 90200 160 0.2
.bss 44520 44552 32 0.1
.data 1984 2048 64 3.2
.data.rel.ro 38448 38520 72 0.2
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147001 147193 192 0.1
.text 1524261 1532709 8448 0.6
chip-tool debug (read only) 10437245 10437309 64 0.0
(read/write) 358680 358680 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329400 329400 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532237 532237 0 0.0
.text 9112293 9112357 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10037980 96 0.0
(read/write) 478337 478337 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376288 376288 0 0.0
.dynamic 560 560 0 0.0
.got 56784 56784 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506604 506604 0 0.0
.text 8466420 8466516 96 0.0
door-lock-app debug (read only) 2058361 2067329 8968 0.4
(read/write) 117936 118160 224 0.2
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.data.rel.ro 63544 63592 48 0.1
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184969 185225 256 0.1
.text 1719938 1728482 8544 0.5
lighting-app debug+rpc (read only) 2236593 2245561 8968 0.4
(read/write) 124928 125152 224 0.2
.bss 49120 49184 64 0.1
.data 1504 1600 96 6.4
.data.rel.ro 68616 68680 64 0.1
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179113 179369 256 0.1
.text 1894562 1903106 8544 0.5
ota-provider-app debug (read only) 1996401 2005337 8936 0.4
(read/write) 113536 113760 224 0.2
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.data.rel.ro 58856 58936 80 0.1
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170819 171043 224 0.1
.text 1671218 1679762 8544 0.5
ota-requestor-app debug (read only) 2025433 2034385 8952 0.4
(read/write) 116792 117016 224 0.2
.bss 48608 48704 96 0.2
.data 1544 1608 64 4.1
.data.rel.ro 61064 61128 64 0.1
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167276 167532 256 0.2
.text 1702114 1710642 8528 0.5
shell debug (read only) 2474417 2483337 8920 0.4
(read/write) 148016 148208 192 0.1
.bss 67240 67304 64 0.1
.data 784 848 64 8.2
.data.rel.ro 74264 74328 64 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212434 212658 224 0.1
.text 2103810 2112338 8528 0.4
thermostat-no-ble arm64 (read only) 2311676 2318652 6976 0.3
(read/write) 149249 149393 144 0.1
.bss 62913 62945 32 0.1
.data 1072 1136 64 6.0
.data.rel.ro 77656 77664 8 0.0
.dynamic 560 560 0 0.0
.got 4584 4624 40 0.9
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142972 143100 128 0.1
.text 1943232 1949936 6704 0.3
tv-app debug (read only) 2740761 2749681 8920 0.3
(read/write) 249440 249664 224 0.1
.bss 165200 165264 64 0.0
.data 3296 3392 96 2.9
.data.rel.ro 74776 74848 72 0.1
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210699 210891 192 0.1
.text 2352002 2360562 8560 0.4
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359932 2361516 1584 0.1
.bss 185020 185036 16 0.0
.data 5752 5784 32 0.6
.text 1322532 1324116 1584 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1150119 1384 0.1
bss 143048 143060 12 0.0
rodata 143328 143328 0 0.0
text 787512 788852 1340 0.2
p6 all-clusters-app default (read/write) 2504488 2505904 1416 0.1
.bss 118456 118472 16 0.0
.data 2632 2672 40 1.5
.text 1462752 1464168 1416 0.1
light-app default (read/write) 2405648 2407064 1416 0.1
.bss 111912 111928 16 0.0
.data 2488 2528 40 1.6
.text 1363912 1365328 1416 0.1
lock-app default (read/write) 2369280 2370720 1440 0.1
.bss 111656 111672 16 0.0
.data 2448 2488 40 1.6
.text 1327544 1328984 1440 0.1
telink lighting-app tlsr9518adk80d (read/write) 792052 793560 1508 0.2
bss 70264 70288 24 0.0
noinit 40416 40416 0 0.0
text 561924 563370 1446 0.3

bzbarsky-apple
bzbarsky-apple reviewed Apr 4, 2022
View reviewed changes
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/app/clusters/access-control-server/access-control-server.cpp Outdated Show resolved Hide resolved
src/lib/support/DefaultStorageKeyAllocator.h Outdated Show resolved Hide resolved
@mlepage-google
Add extension event support
81a624e 
Also change the keys for storing extensions based on review feedback.
@mlepage-google
Relax VerifyOrDie
be46ad2 
Use CHIP_ERROR_INCORRECT_STATE instead.
mlepage-google and others added 2 commits April 4, 2022 16:52
@mlepage-google @bzbarsky-apple
Update src/app/clusters/access-control-server/access-control-server.cpp
839c13c 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@mlepage-google
Change some error codes
72f9d8c 
For invalid octstr length and invalid list length, instead use
constraint error.
@mlepage-google mlepage-google mentioned this pull request Apr 4, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #17008: Size comparison from 7ab6653 to 72f9d8c

Increases above 0.2%:

platform target config section 7ab6653 72f9d8c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 670123 2080 0.3
.data 3128 3164 36 1.2
.text 587840 589864 2024 0.3
lock-mtd LP_CC2652R7 (read only) 617163 619243 2080 0.3
.data 3128 3164 36 1.2
.text 537072 539096 2024 0.4
pump-app LP_CC2652R7 (read only) 687495 689591 2096 0.3
.data 3160 3196 36 1.1
.text 605220 607244 2024 0.3
pump-controller-app LP_CC2652R7 (read only) 669703 671815 2112 0.3
.data 3124 3160 36 1.2
.text 591092 593132 2040 0.3
efr32 lighting-app BRD4161A (read only) 916048 918428 2380 0.3
.data 1956 1992 36 1.8
.text 916040 918420 2380 0.3
BRD4161A+rpc (read only) 943944 946332 2388 0.3
.data 2136 2172 36 1.7
.text 943936 946324 2388 0.3
window-app BRD4161A (read only) 851360 853740 2380 0.3
.data 1836 1872 36 2.0
.text 851352 853732 2380 0.3
esp32 all-clusters-app c3devkit (read only) 985618 987876 2258 0.2
.dram0.data 14164 14196 32 0.2
.flash.text 985618 987876 2258 0.2
k32w light k32w061+release (read/write) 707852 709988 2136 0.3
.data 1868 1904 36 1.9
.text 622240 624332 2092 0.3
lock k32w061+release (read/write) 707260 709396 2136 0.3
.data 1908 1944 36 1.9
.text 621624 623700 2076 0.3
linux all-clusters-app debug (read only) 2577057 2591825 14768 0.6
.data 1328 1440 112 8.4
.text 2188786 2202930 14144 0.6
bridge-app debug+rpc (read only) 1787533 1802109 14576 0.8
.data 1984 2048 64 3.2
.data.rel.ro 38448 38552 104 0.3
.text 1524261 1538277 14016 0.9
chip-tool debug (read only) 10437245 10468181 30936 0.3
(read/write) 358680 367128 8448 2.4
.data.rel.ro 329400 337848 8448 2.6
.got 4896 4920 24 0.5
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10068868 30984 0.3
(read/write) 478337 486769 8432 1.8
.data.rel.ro 376288 384712 8424 2.2
door-lock-app debug (read only) 2058361 2073081 14720 0.7
.data 1056 1152 96 9.1
.text 1719938 1734066 14128 0.8
lighting-app debug+rpc (read only) 2236593 2251361 14768 0.7
.data 1504 1600 96 6.4
.text 1894562 1908802 14240 0.8
ota-provider-app debug (read only) 1996401 2011137 14736 0.7
.data 1320 1384 64 4.8
.text 1671218 1685298 14080 0.8
ota-requestor-app debug (read only) 2025433 2040153 14720 0.7
.data 1544 1608 64 4.1
.text 1702114 1716210 14096 0.8
shell debug (read only) 2474417 2488849 14432 0.6
.data 784 848 64 8.2
.text 2103810 2117746 13936 0.7
thermostat-no-ble arm64 (read only) 2311676 2323596 11920 0.5
.data 1072 1136 64 6.0
.got 4584 4632 48 1.0
.text 1943232 1954736 11504 0.6
tv-app debug (read only) 2740761 2760721 19960 0.7
.data 3296 3392 96 2.9
.data.rel.ro 74776 74976 200 0.3
.got 4656 4672 16 0.3
.rodata 210699 211307 608 0.3
.text 2352002 2370706 18704 0.8
mbed lock-app CY8CPROTO_062_4343W+release .data 5752 5784 32 0.6
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 787512 789516 2004 0.3
p6 all-clusters-app default .data 2632 2672 40 1.5
light-app default .data 2488 2528 40 1.6
lock-app default .data 2448 2488 40 1.6
telink lighting-app tlsr9518adk80d (read/write) 792052 794396 2344 0.3
text 561924 564146 2222 0.4
Increases (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 72f9d8c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 670123 2080 0.3
.bss 81736 81752 16 0.0
.data 3128 3164 36 1.2
.rodata 79723 79779 56 0.1
.text 587840 589864 2024 0.3
lock-mtd LP_CC2652R7 (read only) 617163 619243 2080 0.3
(read/write) 154448 154500 52 0.0
.bss 77464 77480 16 0.0
.data 3128 3164 36 1.2
.rodata 79603 79659 56 0.1
.text 537072 539096 2024 0.4
pump-app LP_CC2652R7 (read only) 687495 689591 2096 0.3
.bss 82128 82152 24 0.0
.data 3160 3196 36 1.1
.rodata 81791 81863 72 0.1
.text 605220 607244 2024 0.3
pump-controller-app LP_CC2652R7 (read only) 669703 671815 2112 0.3
.bss 81872 81888 16 0.0
.data 3124 3160 36 1.2
.rodata 78127 78199 72 0.1
.text 591092 593132 2040 0.3
efr32 lighting-app BRD4161A (read only) 916048 918428 2380 0.3
(read/write) 129728 129784 56 0.0
.bss 127768 127792 24 0.0
.data 1956 1992 36 1.8
.text 916040 918420 2380 0.3
BRD4161A+rpc (read only) 943944 946332 2388 0.3
(read/write) 145680 145732 52 0.0
.bss 143544 143560 16 0.0
.data 2136 2172 36 1.7
.text 943936 946324 2388 0.3
window-app BRD4161A (read only) 851360 853740 2380 0.3
(read/write) 127752 127808 56 0.0
.bss 125912 125936 24 0.0
.data 1836 1872 36 2.0
.text 851352 853732 2380 0.3
esp32 all-clusters-app c3devkit (read only) 985618 987876 2258 0.2
(read/write) 1460570 1460642 72 0.0
.dram0.bss 62920 62944 24 0.0
.dram0.data 14164 14196 32 0.2
.flash.rodata 198000 198024 24 0.0
.flash.text 985618 987876 2258 0.2
m5stack (read only) 1038235 1040291 2056 0.2
(read/write) 461584 461648 64 0.0
.dram0.bss 68448 68472 24 0.0
.dram0.data 34024 34056 32 0.1
.flash.rodata 226968 226976 8 0.0
.flash.text 1032851 1034907 2056 0.2
k32w light k32w061+release (read/write) 707852 709988 2136 0.3
.bss 77944 77952 8 0.0
.data 1868 1904 36 1.9
.text 622240 624332 2092 0.3
lock k32w061+release (read/write) 707260 709396 2136 0.3
.bss 77928 77952 24 0.0
.data 1908 1944 36 1.9
.text 621624 623700 2076 0.3
linux all-clusters-app debug (read only) 2577057 2591825 14768 0.6
(read/write) 144488 144776 288 0.2
.bss 57536 57632 96 0.2
.data 1328 1440 112 8.4
.data.rel.ro 79736 79816 80 0.1
.rodata 220613 220997 384 0.2
.text 2188786 2202930 14144 0.6
bridge-app debug+rpc (read only) 1787533 1802109 14576 0.8
(read/write) 90040 90232 192 0.2
.bss 44520 44552 32 0.1
.data 1984 2048 64 3.2
.data.rel.ro 38448 38552 104 0.3
.rodata 147001 147321 320 0.2
.text 1524261 1538277 14016 0.9
chip-tool debug (read only) 10437245 10468181 30936 0.3
(read/write) 358680 367128 8448 2.4
.data.rel.ro 329400 337848 8448 2.6
.got 4896 4920 24 0.5
.rodata 532237 532653 416 0.1
.text 9112293 9117189 4896 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10068868 30984 0.3
(read/write) 478337 486769 8432 1.8
.data.rel.ro 376288 384712 8424 2.2
.got 56784 56800 16 0.0
.rodata 506604 506756 152 0.0
.text 8466420 8471892 5472 0.1
door-lock-app debug (read only) 2058361 2073081 14720 0.7
(read/write) 117936 118224 288 0.2
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.data.rel.ro 63544 63640 96 0.2
.rodata 184969 185321 352 0.2
.text 1719938 1734066 14128 0.8
lighting-app debug+rpc (read only) 2236593 2251361 14768 0.7
(read/write) 124928 125216 288 0.2
.bss 49120 49184 64 0.1
.data 1504 1600 96 6.4
.data.rel.ro 68616 68744 128 0.2
.rodata 179113 179401 288 0.2
.text 1894562 1908802 14240 0.8
ota-provider-app debug (read only) 1996401 2011137 14736 0.7
(read/write) 113536 113792 256 0.2
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.data.rel.ro 58856 58968 112 0.2
.rodata 170819 171235 416 0.2
.text 1671218 1685298 14080 0.8
ota-requestor-app debug (read only) 2025433 2040153 14720 0.7
(read/write) 116792 117080 288 0.2
.bss 48608 48704 96 0.2
.data 1544 1608 64 4.1
.data.rel.ro 61064 61176 112 0.2
.rodata 167276 167660 384 0.2
.text 1702114 1716210 14096 0.8
shell debug (read only) 2474417 2488849 14432 0.6
(read/write) 148016 148240 224 0.2
.bss 67240 67304 64 0.1
.data 784 848 64 8.2
.data.rel.ro 74264 74360 96 0.1
.rodata 212434 212690 256 0.1
.text 2103810 2117746 13936 0.7
thermostat-no-ble arm64 (read only) 2311676 2323596 11920 0.5
(read/write) 149249 149441 192 0.1
.bss 62913 62945 32 0.1
.data 1072 1136 64 6.0
.data.rel.ro 77656 77704 48 0.1
.got 4584 4632 48 1.0
.rodata 142972 143148 176 0.1
.text 1943232 1954736 11504 0.6
tv-app debug (read only) 2740761 2760721 19960 0.7
(read/write) 249440 249888 448 0.2
.bss 165200 165328 128 0.1
.data 3296 3392 96 2.9
.data.rel.ro 74776 74976 200 0.3
.got 4656 4672 16 0.3
.rodata 210699 211307 608 0.3
.text 2352002 2370706 18704 0.8
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2359932 2362220 2288 0.1
.bss 185020 185036 16 0.0
.data 5752 5784 32 0.6
.text 1322532 1324820 2288 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1150831 2096 0.2
bss 143048 143060 12 0.0
rodata 143328 143384 56 0.0
text 787512 789516 2004 0.3
p6 all-clusters-app default (read/write) 2504488 2506784 2296 0.1
.bss 118456 118472 16 0.0
.data 2632 2672 40 1.5
.text 1462752 1465048 2296 0.2
light-app default (read/write) 2405648 2407976 2328 0.1
.bss 111912 111928 16 0.0
.data 2488 2528 40 1.6
.text 1363912 1366240 2328 0.2
lock-app default (read/write) 2369280 2371616 2336 0.1
.bss 111656 111672 16 0.0
.data 2448 2488 40 1.6
.text 1327544 1329880 2336 0.2
telink lighting-app tlsr9518adk80d (read/write) 792052 794396 2344 0.3
bss 70264 70288 24 0.0
text 561924 564146 2222 0.4
Decreases (3 builds for cc13x2_26x2)
platform target config section 7ab6653 72f9d8c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183652 181588 -2064 -1.1
pump-app LP_CC2652R7 (read/write) 165360 163288 -2072 -1.3
pump-controller-app LP_CC2652R7 (read/write) 182896 180800 -2096 -1.1
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7ab6653 72f9d8c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668043 670123 2080 0.3
(read/write) 183652 181588 -2064 -1.1
.bss 81736 81752 16 0.0
.data 3128 3164 36 1.2
.rodata 79723 79779 56 0.1
.text 587840 589864 2024 0.3
lock-mtd LP_CC2652R7 (read only) 617163 619243 2080 0.3
(read/write) 154448 154500 52 0.0
.bss 77464 77480 16 0.0
.data 3128 3164 36 1.2
.rodata 79603 79659 56 0.1
.text 537072 539096 2024 0.4
pump-app LP_CC2652R7 (read only) 687495 689591 2096 0.3
(read/write) 165360 163288 -2072 -1.3
.bss 82128 82152 24 0.0
.data 3160 3196 36 1.1
.rodata 81791 81863 72 0.1
.text 605220 607244 2024 0.3
pump-controller-app LP_CC2652R7 (read only) 669703 671815 2112 0.3
(read/write) 182896 180800 -2096 -1.1
.bss 81872 81888 16 0.0
.data 3124 3160 36 1.2
.rodata 78127 78199 72 0.1
.text 591092 593132 2040 0.3
efr32 lighting-app BRD4161A (read only) 916048 918428 2380 0.3
(read/write) 129728 129784 56 0.0
.bss 127768 127792 24 0.0
.data 1956 1992 36 1.8
.text 916040 918420 2380 0.3
BRD4161A+rpc (read only) 943944 946332 2388 0.3
(read/write) 145680 145732 52 0.0
.bss 143544 143560 16 0.0
.data 2136 2172 36 1.7
.text 943936 946324 2388 0.3
window-app BRD4161A (read only) 851360 853740 2380 0.3
(read/write) 127752 127808 56 0.0
.bss 125912 125936 24 0.0
.data 1836 1872 36 2.0
.text 851352 853732 2380 0.3
esp32 all-clusters-app c3devkit (read only) 985618 987876 2258 0.2
(read/write) 1460570 1460642 72 0.0
.dram0.bss 62920 62944 24 0.0
.dram0.data 14164 14196 32 0.2
.flash.rodata 198000 198024 24 0.0
.flash.text 985618 987876 2258 0.2
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038235 1040291 2056 0.2
(read/write) 461584 461648 64 0.0
.dram0.bss 68448 68472 24 0.0
.dram0.data 34024 34056 32 0.1
.flash.rodata 226968 226976 8 0.0
.flash.text 1032851 1034907 2056 0.2
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707852 709988 2136 0.3
.bss 77944 77952 8 0.0
.data 1868 1904 36 1.9
.text 622240 624332 2092 0.3
lock k32w061+release (read/write) 707260 709396 2136 0.3
.bss 77928 77952 24 0.0
.data 1908 1944 36 1.9
.text 621624 623700 2076 0.3
linux all-clusters-app debug (read only) 2577057 2591825 14768 0.6
(read/write) 144488 144776 288 0.2
.bss 57536 57632 96 0.2
.data 1328 1440 112 8.4
.data.rel.ro 79736 79816 80 0.1
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220613 220997 384 0.2
.text 2188786 2202930 14144 0.6
bridge-app debug+rpc (read only) 1787533 1802109 14576 0.8
(read/write) 90040 90232 192 0.2
.bss 44520 44552 32 0.1
.data 1984 2048 64 3.2
.data.rel.ro 38448 38552 104 0.3
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147001 147321 320 0.2
.text 1524261 1538277 14016 0.9
chip-tool debug (read only) 10437245 10468181 30936 0.3
(read/write) 358680 367128 8448 2.4
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329400 337848 8448 2.6
.dynamic 624 624 0 0.0
.got 4896 4920 24 0.5
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532237 532653 416 0.1
.text 9112293 9117189 4896 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 10037884 10068868 30984 0.3
(read/write) 478337 486769 8432 1.8
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376288 384712 8424 2.2
.dynamic 560 560 0 0.0
.got 56784 56800 16 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506604 506756 152 0.0
.text 8466420 8471892 5472 0.1
door-lock-app debug (read only) 2058361 2073081 14720 0.7
(read/write) 117936 118224 288 0.2
.bss 47776 47872 96 0.2
.data 1056 1152 96 9.1
.data.rel.ro 63544 63640 96 0.2
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184969 185321 352 0.2
.text 1719938 1734066 14128 0.8
lighting-app debug+rpc (read only) 2236593 2251361 14768 0.7
(read/write) 124928 125216 288 0.2
.bss 49120 49184 64 0.1
.data 1504 1600 96 6.4
.data.rel.ro 68616 68744 128 0.2
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179113 179401 288 0.2
.text 1894562 1908802 14240 0.8
ota-provider-app debug (read only) 1996401 2011137 14736 0.7
(read/write) 113536 113792 256 0.2
.bss 47616 47712 96 0.2
.data 1320 1384 64 4.8
.data.rel.ro 58856 58968 112 0.2
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170819 171235 416 0.2
.text 1671218 1685298 14080 0.8
ota-requestor-app debug (read only) 2025433 2040153 14720 0.7
(read/write) 116792 117080 288 0.2
.bss 48608 48704 96 0.2
.data 1544 1608 64 4.1
.data.rel.ro 61064 61176 112 0.2
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167276 167660 384 0.2
.text 1702114 1716210 14096 0.8
shell debug (read only) 2474417 2488849 14432 0.6
(read/write) 148016 148240 224 0.2
.bss 67240 67304 64 0.1
.data 784 848 64 8.2
.data.rel.ro 74264 74360 96 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212434 212690 256 0.1
.text 2103810 2117746 13936 0.7
thermostat-no-ble arm64 (read only) 2311676 2323596 11920 0.5
(read/write) 149249 149441 192 0.1
.bss 62913 62945 32 0.1
.data 1072 1136 64 6.0
.data.rel.ro 77656 77704 48 0.1
.dynamic 560 560 0 0.0
.got 4584 4632 48 1.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142972 143148 176 0.1
.text 1943232 1954736 11504 0.6
tv-app debug (read only) 2740761 2760721 19960 0.7
(read/write) 249440 249888 448 0.2
.bss 165200 165328 128 0.1
.data 3296 3392 96 2.9
.data.rel.ro 74776 74976 200 0.3
.dynamic 592 592 0 0.0
.got 4656 4672 16 0.3
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210699 211307 608 0.3
.text 2352002 2370706 18704 0.8
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359932 2362220 2288 0.1
.bss 185020 185036 16 0.0
.data 5752 5784 32 0.6
.text 1322532 1324820 2288 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148735 1150831 2096 0.2
bss 143048 143060 12 0.0
rodata 143328 143384 56 0.0
text 787512 789516 2004 0.3
p6 all-clusters-app default (read/write) 2504488 2506784 2296 0.1
.bss 118456 118472 16 0.0
.data 2632 2672 40 1.5
.text 1462752 1465048 2296 0.2
light-app default (read/write) 2405648 2407976 2328 0.1
.bss 111912 111928 16 0.0
.data 2488 2528 40 1.6
.text 1363912 1366240 2328 0.2
lock-app default (read/write) 2369280 2371616 2336 0.1
.bss 111656 111672 16 0.0
.data 2448 2488 40 1.6
.text 1327544 1329880 2336 0.2
telink lighting-app tlsr9518adk80d (read/write) 792052 794396 2344 0.3
bss 70264 70288 24 0.0
noinit 40416 40416 0 0.0
text 561924 564146 2222 0.4

@mlepage-google mlepage-google mentioned this pull request Apr 5, 2022
Merged
@woody-apple woody-apple merged commit 70a6caa into project-chip:master Apr 5, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@mlepage-google @bzbarsky-apple @chencheung
Add extension attribute to access control cluster (project-chip#17008)
c9daf35 
* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@mlepage-google @bzbarsky-apple @chencheung
Add extension attribute to access control cluster (project-chip#17008)
85ae4e3 
* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@mlepage-google @bzbarsky-apple @andrei-menzopol
Add extension attribute to access control cluster (project-chip#17008)
d00ac68 
* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@mlepage-google mlepage-google deleted the extension-attribute branch April 28, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlepage-google @tcarmelveilleux @woody-apple @bzbarsky-apple