Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused FindDestinationIDCandidate API #17020

Merged

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

Change overview

  • Remove stale FindDestinationIDCandidate API

Testing

  • No functional change, removes dead code
  • Unit tests and integration tests still pass

- `FabricTable::FindDestinationIDCandidate` is declared, but used nowhere
  since the IPK refactor of project-chip#16737, and not implemented either. It is
  100% dead code.
- Remove stale `FindDestinationIDCandidate` API
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

PR #17020: Size comparison from c3b1810 to 9de56a7

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c3b1810 9de56a7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668387 668387 0 0.0
(read/write) 183324 183324 0 0.0
.bss 81752 81752 0 0.0
.data 3164 3164 0 0.0
.rodata 79715 79715 0 0.0
.text 588192 588192 0 0.0
lock-mtd LP_CC2652R7 (read only) 617507 617507 0 0.0
(read/write) 154500 154500 0 0.0
.bss 77480 77480 0 0.0
.data 3164 3164 0 0.0
.rodata 79595 79595 0 0.0
.text 537424 537424 0 0.0
pump-app LP_CC2652R7 (read only) 687847 687847 0 0.0
(read/write) 165032 165032 0 0.0
.bss 82152 82152 0 0.0
.data 3196 3196 0 0.0
.rodata 81791 81791 0 0.0
.text 605572 605572 0 0.0
pump-controller-app LP_CC2652R7 (read only) 670079 670079 0 0.0
(read/write) 182536 182536 0 0.0
.bss 81888 81888 0 0.0
.data 3160 3160 0 0.0
.rodata 78127 78127 0 0.0
.text 591468 591468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610982 610982 0 0.0
.app_xip_area 517692 517692 0 0.0
.bss 76004 76004 0 0.0
.data 632 632 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568498 568498 0 0.0
.app_xip_area 476752 476752 0 0.0
.bss 74500 74500 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 580158 580158 0 0.0
.app_xip_area 478768 478768 0 0.0
.bss 83816 83816 0 0.0
.data 536 536 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916292 916292 0 0.0
(read/write) 129784 129784 0 0.0
.bss 127792 127792 0 0.0
.data 1992 1992 0 0.0
.text 916284 916284 0 0.0
BRD4161A+rpc (read only) 944196 944196 0 0.0
(read/write) 145732 145732 0 0.0
.bss 143560 143560 0 0.0
.data 2172 2172 0 0.0
.text 944188 944188 0 0.0
window-app BRD4161A (read only) 851604 851604 0 0.0
(read/write) 127808 127808 0 0.0
.bss 125936 125936 0 0.0
.data 1872 1872 0 0.0
.text 851596 851596 0 0.0
esp32 all-clusters-app c3devkit (read only) 986054 986054 0 0.0
(read/write) 1460602 1460602 0 0.0
.dram0.bss 62944 62944 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 197984 197984 0 0.0
.flash.text 986054 986054 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038519 1038519 0 0.0
(read/write) 461632 461632 0 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 226960 226960 0 0.0
.flash.text 1033135 1033135 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 708236 708236 0 0.0
.bss 77952 77952 0 0.0
.data 1904 1904 0 0.0
.text 622580 622580 0 0.0
lock k32w061+release (read/write) 707660 707660 0 0.0
.bss 77952 77952 0 0.0
.data 1944 1944 0 0.0
.text 621964 621964 0 0.0
linux all-clusters-app debug (read only) 2580137 2580137 0 0.0
(read/write) 144744 144744 0 0.0
.bss 57632 57632 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79784 79784 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221061 221061 0 0.0
.text 2191250 2191250 0 0.0
bridge-app debug+rpc (read only) 1790421 1790421 0 0.0
(read/write) 90200 90200 0 0.0
.bss 44552 44552 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38520 38520 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147385 147385 0 0.0
.text 1526597 1526597 0 0.0
chip-tool debug (read only) 10468101 10468101 0 0.0
(read/write) 367128 367128 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 337848 337848 0 0.0
.dynamic 624 624 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532653 532653 0 0.0
.text 9117109 9117109 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10068772 10068772 0 0.0
(read/write) 486769 486769 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 56800 56800 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506756 506756 0 0.0
.text 8471796 8471796 0 0.0
door-lock-app debug (read only) 2061425 2061425 0 0.0
(read/write) 118160 118160 0 0.0
.bss 47872 47872 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63592 63592 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185417 185417 0 0.0
.text 1722386 1722386 0 0.0
lighting-app debug+rpc (read only) 2239705 2239705 0 0.0
(read/write) 125152 125152 0 0.0
.bss 49184 49184 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68680 68680 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179497 179497 0 0.0
.text 1897122 1897122 0 0.0
ota-provider-app debug (read only) 1999449 1999449 0 0.0
(read/write) 113760 113760 0 0.0
.bss 47712 47712 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 58936 58936 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171299 171299 0 0.0
.text 1673618 1673618 0 0.0
ota-requestor-app debug (read only) 2028481 2028481 0 0.0
(read/write) 117016 117016 0 0.0
.bss 48704 48704 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61128 61128 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167724 167724 0 0.0
.text 1704546 1704546 0 0.0
shell debug (read only) 2477129 2477129 0 0.0
(read/write) 148208 148208 0 0.0
.bss 67304 67304 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74328 74328 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212754 212754 0 0.0
.text 2106034 2106034 0 0.0
thermostat-no-ble arm64 (read only) 2314172 2314172 0 0.0
(read/write) 149361 149361 0 0.0
.bss 62945 62945 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77640 77640 0 0.0
.dynamic 560 560 0 0.0
.got 4624 4624 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143132 143132 0 0.0
.text 1945440 1945440 0 0.0
tv-app debug (read only) 2749033 2749033 0 0.0
(read/write) 249856 249856 0 0.0
.bss 165328 165328 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 74944 74944 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211371 211371 0 0.0
.text 2359026 2359026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360548 2360548 0 0.0
.bss 185036 185036 0 0.0
.data 5784 5784 0 0.0
.text 1323148 1323148 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1149103 1149103 0 0.0
bss 143060 143060 0 0.0
rodata 143320 143320 0 0.0
text 787844 787844 0 0.0
p6 all-clusters-app default (read/write) 2504664 2504664 0 0.0
.bss 118472 118472 0 0.0
.data 2672 2672 0 0.0
.text 1462928 1462928 0 0.0
light-app default (read/write) 2405840 2405840 0 0.0
.bss 111928 111928 0 0.0
.data 2528 2528 0 0.0
.text 1364104 1364104 0 0.0
lock-app default (read/write) 2369496 2369496 0 0.0
.bss 111672 111672 0 0.0
.data 2488 2488 0 0.0
.text 1327760 1327760 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 792504 792504 0 0.0
bss 70288 70288 0 0.0
noinit 40416 40416 0 0.0
text 562332 562332 0 0.0

@woody-apple woody-apple merged commit f69dfe8 into project-chip:master Apr 5, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
- `FabricTable::FindDestinationIDCandidate` is declared, but used nowhere
  since the IPK refactor of project-chip#16737, and not implemented either. It is
  100% dead code.
- Remove stale `FindDestinationIDCandidate` API
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
- `FabricTable::FindDestinationIDCandidate` is declared, but used nowhere
  since the IPK refactor of project-chip#16737, and not implemented either. It is
  100% dead code.
- Remove stale `FindDestinationIDCandidate` API
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
- `FabricTable::FindDestinationIDCandidate` is declared, but used nowhere
  since the IPK refactor of project-chip#16737, and not implemented either. It is
  100% dead code.
- Remove stale `FindDestinationIDCandidate` API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants