Pass the country code via commissioning parameters. #17284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't assume the configuration manager exists on the commissioner, or stores anything useful, so switch to passing in the country code via commissioning parameters instead of reading it from the configuration manager.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
andy31415
approved these changes
Apr 12, 2022
|
PR #17284: Size comparison from 2c15978 to cc2fd03 Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
cecille
reviewed
Apr 12, 2022
There was a problem hiding this comment.
Testing suggestion: You can test this in the commissiong_test.py cirque test. There is a truly insane amount of plumbing to get through to the python layer, but it's do-able. In src/controller/python/ChipDeviceController-ScriptBinding.cpp, there is a set of commissioning parameters that we use for commissioning. There are functions to set the wifi and thread data sets, this can be extended out to set also the country code (you'd have to add the plumbing). In commissioning_test.py, set the country code before TestKeyExchange, then check that the value is reflected in the basic info cluster.
tcarmelveilleux
approved these changes
Apr 12, 2022
tcarmelveilleux
approved these changes
Apr 13, 2022
jmartinez-silabs
approved these changes
Apr 13, 2022
Filed #17368 |
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
We shouldn't assume the configuration manager exists on the commissioner, or stores anything useful, so switch to passing in the country code via commissioning parameters instead of reading it from the configuration manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't assume the configuration manager exists on the
commissioner, or stores anything useful, so switch to passing in the
country code via commissioning parameters instead of reading it from
the configuration manager.
Problem
See above.
Change overview
See above.
Testing
Not sure how to test this so far....