[nrfconnect] Added recovering CASE session for the light switch #17315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't CASE recovery mechanism, so after resetting lighting device, the light switch is not able to communicate with it, as it holds out of date CASE session. Added releasing CASE session in case invoke command failure due to timeout reason. After that new session is established and command retransmitted. CASE session is recovered only once per failure to prevent multiple tries in case comunnication is seriously broken.
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #17315: Size comparison from faabdf9 to f169fab Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Apr 13, 2022
andy31415
approved these changes
Apr 13, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ect-chip#17315) There isn't CASE recovery mechanism, so after resetting lighting device, the light switch is not able to communicate with it, as it holds out of date CASE session. Added releasing CASE session in case invoke command failure due to timeout reason. After that new session is established and command retransmitted. CASE session is recovered only once per failure to prevent multiple tries in case comunnication is seriously broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There isn't CASE recovery mechanism, so after resetting lighting
device, the light switch is not able to communicate with it,
as it holds out of date CASE session.
Change overview
Added releasing CASE session in case invoke command failure due
to timeout reason. After that new session is established and command
retransmitted. CASE session is recovered only once per failure to
prevent multiple tries in case comunnication is seriously broken.
Testing
Tested manually with light-switch and lighting-app that after rebooting lighting-app, the light-switch after sending "matter switch onoff on/off/toggle" command is able to automatically drop old session and establish new one.