Store the updated fabric info when bringing up controller on existing fabric #18260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
bzbarsky-apple
force-pushed
the
safer-fabric-update
branch
from
e04a049 to
ba6b517
Compare
|
PR #18260: Size comparison from 46ae442 to ba6b517 Increases (32 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
safer-fabric-update
branch
from
ba6b517 to
dfff0d7
Compare
|
PR #18260: Size comparison from 395375d to dfff0d7 Increases (27 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (27 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
safer-fabric-update
branch
from
dfff0d7 to
e1ae605
Compare
|
PR #18260: Size comparison from 837b939 to e1ae605 Increases (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (20 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
May 10, 2022
|
/rebase |
… fabric. Right now bringing up a controller on an existing fabric updates the in-memory fabric table but does not store the updated data. This is not very consistent with our desire to not even keep the fabric table in memory, and leads to inconsistent behavior if someone later reloads the fabric table from storage in some way. Specific changes: 1. Change FabricInfo::SetFabricInfo to not modify any member state until validation of the incoming info is complete, so we won't corrupt an existing fabric due to mistaken input and leave it in a bad state. 2. If updating the existing fabric in ProcessControllerNOCChain succeeds, store the updated fabric info. This is done outside the fabric table for now, pending changes to the fabric table to store things itself instead of keeping them in RAM.
bzbarsky-apple
force-pushed
the
safer-fabric-update
branch
from
e1ae605 to
da79299
Compare
|
PR #18260: Size comparison from 582a3a2 to da79299 Increases (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (4 builds for cc13x2_26x2)
Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmeg-sfy
approved these changes
May 11, 2022
andy31415
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now bringing up a controller on an existing fabric updates the in-memory fabric table but does not store the updated data.
This is not very consistent with our desire to not even keep the fabric table in memory, and leads to inconsistent behavior if someone later reloads the fabric table from storage in some way.
Specific changes:
Change FabricInfo::SetFabricInfo to not modify any member state until
validation of the incoming info is complete, so we won't corrupt an existing
fabric due to mistaken input and leave it in a bad state.
If updating the existing fabric in ProcessControllerNOCChain succeeds, store
the updated fabric info. This is done outside the fabric table for now,
pending changes to the fabric table to store things itself instead of keeping
them in RAM.
Problem
See above.
Change overview
See above.
Testing
CI should cover this, but I will also be writing tests for some work I am doing right now on Darwin controller bring-up which will exercise this.