Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved door-lock app from chip-all-clusters-common to chip-all-clusters-app #18289

Merged
merged 1 commit into from
May 12, 2022
Merged

Moved door-lock app from chip-all-clusters-common to chip-all-clusters-app #18289

merged 1 commit into from
May 12, 2022

Conversation

vijs
Copy link
Collaborator

@vijs vijs commented May 11, 2022

Problem

  • Linux all-clusters-app build environment uses a common source-set that includes example-specific code/callbacks for door-lock applications. This should not be part of the common source-set, because it overrides weak methods that could be used for customer-specific demonstration/test applications (that use the all-clusters-app common source-set).

Change overview

  • Move door-lock app dependencies from the chip-all-clusters-common source-set into the executable targets of the example chip-all-clusters-app.

Testing

  • Matter Unit Tests
  • Tested Commissioning flow (chip-tool vs chip-all-clusters-app)

@restyled-io restyled-io bot mentioned this pull request May 11, 2022
Closed
@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited
Loading

PR #18289: Size comparison from 582a3a2 to 7b40410

Full report (25 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 582a3a2 7b40410 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691019 691019 0 0.0
(read/write) 161332 161332 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 103083 0 0.0
.text 587452 587452 0 0.0
lock-ftd LP_CC2652R7 (read only) 678543 678543 0 0.0
(read/write) 164912 164912 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94823 94823 0 0.0
.text 583240 583240 0 0.0
lock-mtd LP_CC2652R7 (read only) 627303 627303 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94711 94711 0 0.0
.text 532104 532104 0 0.0
pump-app LP_CC2652R7 (read only) 663039 663039 0 0.0
(read/write) 181704 181704 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80991 0 0.0
.text 581564 581564 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655963 655963 0 0.0
(read/write) 188580 188580 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83939 83939 0 0.0
.text 571540 571540 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627606 627606 0 0.0
.app_xip_area 530196 530196 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626526 626526 0 0.0
.app_xip_area 530572 530572 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575278 575278 0 0.0
.app_xip_area 469608 469608 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910000 910000 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 909992 909992 0 0.0
BRD4161A+rpc (read only) 944344 944344 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944336 944336 0 0.0
BRD4161A+rs911x (read only) 787596 787596 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787588 787588 0 0.0
lock-app BRD4161A+wf200 (read only) 946804 946804 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946796 946796 0 0.0
window-app BRD4161A (read only) 890304 890304 0 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890296 890296 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001094 1001094 0 0.0
(read/write) 1475770 1475770 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208416 208416 0 0.0
.flash.text 1001094 1001094 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055947 1055947 0 0.0
(read/write) 478184 478184 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238180 238180 0 0.0
.flash.text 1050563 1050563 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685148 685148 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600176 600176 0 0.0
lock k32w061+release (read/write) 730528 730528 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645164 645164 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8934972 8934972 0 0.0
(read/write) 643105 643105 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 438812 438812 0 0.0
.text 7036884 7036884 0 0.0
thermostat-no-ble arm64 (read only) 2369556 2369556 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146868 146868 0 0.0
.text 1992800 1992800 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2419956 2419956 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382556 1382556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179879 1179879 0 0.0
bss 139680 139680 0 0.0
rodata 151640 151640 0 0.0
text 809840 809840 0 0.0
p6 all-clusters-app default (read/write) 2531536 2531536 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489800 1489800 0 0.0
light-app default (read/write) 2421496 2421496 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379760 1379760 0 0.0
lock-app default (read/write) 2431040 2431040 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389304 1389304 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806128 806128 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572504 572504 0 0.0

@vijs vijs force-pushed the feature/all_clusters_app_wo_door_lock branch from 7b40410 to 0342236 Compare May 11, 2022 17:37
@vijs vijs requested a review from bzbarsky-apple May 11, 2022 17:39
@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited
Loading

PR #18289: Size comparison from 2ae1d5a to 0342236

Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2ae1d5a 0342236 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691099 691099 0 0.0
(read/write) 161252 161252 0 0.0
.bss 75332 75332 0 0.0
.data 3412 3412 0 0.0
.rodata 103083 103083 0 0.0
.text 587532 587532 0 0.0
lock-ftd LP_CC2652R7 (read only) 678607 678607 0 0.0
(read/write) 164848 164848 0 0.0
.bss 73492 73492 0 0.0
.data 3236 3236 0 0.0
.rodata 94823 94823 0 0.0
.text 583304 583304 0 0.0
lock-mtd LP_CC2652R7 (read only) 627359 627359 0 0.0
(read/write) 146308 146308 0 0.0
.bss 69212 69212 0 0.0
.data 3236 3236 0 0.0
.rodata 94711 94711 0 0.0
.text 532160 532160 0 0.0
pump-app LP_CC2652R7 (read only) 663111 663111 0 0.0
(read/write) 181632 181632 0 0.0
.bss 73756 73756 0 0.0
.data 3268 3268 0 0.0
.rodata 80991 80991 0 0.0
.text 581636 581636 0 0.0
pump-controller-app LP_CC2652R7 (read only) 656027 656027 0 0.0
(read/write) 188516 188516 0 0.0
.bss 73812 73812 0 0.0
.data 3232 3232 0 0.0
.rodata 83939 83939 0 0.0
.text 571604 571604 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 627710 627710 0 0.0
.app_xip_area 530300 530300 0 0.0
.bss 80052 80052 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 626630 626630 0 0.0
.app_xip_area 530676 530676 0 0.0
.bss 78628 78628 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575350 575350 0 0.0
.app_xip_area 469680 469680 0 0.0
.bss 88048 88048 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 910096 910096 0 0.0
(read/write) 134520 134520 0 0.0
.bss 132456 132456 0 0.0
.data 2064 2064 0 0.0
.text 910088 910088 0 0.0
BRD4161A+rpc (read only) 944424 944424 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148936 148936 0 0.0
.data 2268 2268 0 0.0
.text 944416 944416 0 0.0
BRD4161A+rs911x (read only) 787692 787692 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127708 127708 0 0.0
.data 2068 2068 0 0.0
.text 787684 787684 0 0.0
lock-app BRD4161A+wf200 (read only) 946868 946868 0 0.0
(read/write) 124268 124268 0 0.0
.bss 122244 122244 0 0.0
.data 2024 2024 0 0.0
.text 946860 946860 0 0.0
window-app BRD4161A (read only) 890400 890400 0 0.0
(read/write) 134472 134472 0 0.0
.bss 132416 132416 0 0.0
.data 2052 2052 0 0.0
.text 890392 890392 0 0.0
esp32 all-clusters-app c3devkit (read only) 1001212 1001212 0 0.0
(read/write) 1475770 1475770 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 14444 14444 0 0.0
.flash.rodata 208416 208416 0 0.0
.flash.text 1001212 1001212 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1056067 1056067 0 0.0
(read/write) 478184 478184 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34184 34184 0 0.0
.flash.rodata 238180 238180 0 0.0
.flash.text 1050683 1050683 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 685260 685260 0 0.0
.bss 81248 81248 0 0.0
.data 2020 2020 0 0.0
.text 600288 600288 0 0.0
lock k32w061+release (read/write) 730624 730624 0 0.0
.bss 81680 81680 0 0.0
.data 1980 1980 0 0.0
.text 645260 645260 0 0.0
linux all-clusters-app debug (read only) 2742713 2742713 0 0.0
(read/write) 174552 174552 0 0.0
.bss 83904 83904 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 82456 82456 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 236453 236453 0 0.0
.text 2330386 2330386 0 0.0
bridge-app debug+rpc (read only) 1897241 1897241 0 0.0
(read/write) 121080 121080 0 0.0
.bss 71520 71520 0 0.0
.data 3488 3488 0 0.0
.data.rel.ro 40712 40712 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 161593 161593 0 0.0
.text 1612290 1612290 0 0.0
chip-tool debug (read only) 9118229 9118229 0 0.0
(read/write) 577008 577008 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546752 546752 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 471893 471893 0 0.0
.text 7321877 7321877 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8937180 8937180 0 0.0
(read/write) 643121 643121 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 582008 582008 0 0.0
.dynamic 560 560 0 0.0
.got 14976 14976 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 438924 438924 0 0.0
.text 7038724 7038724 0 0.0
lighting-app debug+rpc (read only) 2330857 2330857 0 0.0
(read/write) 152032 152032 0 0.0
.bss 73568 73568 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70664 70664 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 185753 185753 0 0.0
.text 1977890 1977890 0 0.0
lock-app debug (read only) 2238361 2238361 0 0.0
(read/write) 146616 146616 0 0.0
.bss 72192 72192 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67160 67160 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 195561 195561 0 0.0
.text 1881906 1881906 0 0.0
ota-provider-app debug (read only) 2067129 2067129 0 0.0
(read/write) 139696 139696 0 0.0
.bss 71680 71680 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 60488 60488 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 176499 176499 0 0.0
.text 1732258 1732258 0 0.0
ota-requestor-app debug (read only) 2097489 2097489 0 0.0
(read/write) 142536 142536 0 0.0
.bss 72320 72320 0 0.0
.data 1992 1992 0 0.0
.data.rel.ro 62584 62584 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172796 172796 0 0.0
.text 1764834 1764834 0 0.0
shell debug (read only) 2567729 2567729 0 0.0
(read/write) 198288 198288 0 0.0
.bss 114408 114408 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 76744 76744 0 0.0
.dynamic 592 592 0 0.0
.got 4208 4208 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217938 217938 0 0.0
.text 2187010 2187010 0 0.0
thermostat-no-ble arm64 (read only) 2369940 2369940 0 0.0
(read/write) 175153 175153 0 0.0
.bss 86417 86417 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79408 79408 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146868 146868 0 0.0
.text 1993184 1993184 0 0.0
tv-app debug (read only) 2855593 2855593 0 0.0
(read/write) 277312 277312 0 0.0
.bss 189464 189464 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 592 592 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 218475 218475 0 0.0
.text 2453890 2453890 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2420020 2420020 0 0.0
.bss 205820 205820 0 0.0
.data 5872 5872 0 0.0
.text 1382620 1382620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179943 1179943 0 0.0
bss 139680 139680 0 0.0
rodata 151640 151640 0 0.0
text 809908 809908 0 0.0
p6 all-clusters-app default (read/write) 2531600 2531600 0 0.0
.bss 139328 139328 0 0.0
.data 2808 2808 0 0.0
.text 1489864 1489864 0 0.0
light-app default (read/write) 2421592 2421592 0 0.0
.bss 132656 132656 0 0.0
.data 2608 2608 0 0.0
.text 1379856 1379856 0 0.0
lock-app default (read/write) 2431136 2431136 0 0.0
.bss 132472 132472 0 0.0
.data 2568 2568 0 0.0
.text 1389400 1389400 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 806240 806240 0 0.0
bss 72176 72176 0 0.0
noinit 40416 40416 0 0.0
text 572614 572614 0 0.0

@pullapprove pullapprove bot requested review from tehampson and removed request for holbrookt May 12, 2022 05:25
@vijs vijs merged commit 01f67e9 into project-chip:master May 12, 2022
@vivien-apple vivien-apple mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawk248 hawk248 hawk248 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@tehampson tehampson Awaiting requested review from tehampson

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijs @hawk248 @bzbarsky-apple