Fix DiscoveryImplPlatform::Shutdown so restart works correctly. #18542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until the changes in project-chip#18442 DiscoveryImplPlatform::Shutdown was a no-op on most platforms, so the fact that you could not re-init after that call did not matter, because nothing had actually been shut down. Now that we are actually shutting down mResolverProxy, we need to make sure a future call to Init() will correctly re-initialize things instead of just bailing out.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #18542: Size comparison from a777a80 to 28f61eb Increases (14 builds for cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect, telink)
Decreases (5 builds for cc13x2_26x2)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until the changes in #18442 DiscoveryImplPlatform::Shutdown was a
no-op on most platforms, so the fact that you could not re-init after
that call did not matter, because nothing had actually been shut down.
Now that we are actually shutting down mResolverProxy, we need to make
sure a future call to Init() will correctly re-initialize things
instead of just bailing out.
Problem
Can't re-init platform mdns after shutdown.
Change overview
Flag ourselves as not initialized any more once we have shut down.
Testing
Made sure that CHIPTool on iOS works again after this (was broken before, because it could not do anything with mdns after restarting the Matter stack).