Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added New Credentials Validity Checks for UpdateNOC Command. #18866

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Added New Credentials Validity Checks for UpdateNOC Command. #18866

merged 2 commits into from
Jun 3, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Ticket #15310

Change overview

Factored out common code that performs those validity checks.

Testing

existing tests

@boring-cyborg boring-cyborg bot added the app label May 26, 2022
@github-actions
Copy link

github-actions bot commented May 26, 2022 •
edited
Loading

PR #18866: Size comparison from 3956a9d to 6e64bf7

Increases (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3956a9d 6e64bf7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 644979 645099 120 0.0
.text 560996 561116 120 0.0
lock-ftd LP_CC2652R7 (read only) 679295 679415 120 0.0
.text 582756 582876 120 0.0
lock-mtd LP_CC2652R7 (read only) 628695 628815 120 0.0
.text 532268 532388 120 0.0
pump-app LP_CC2652R7 (read only) 675715 675819 104 0.0
.text 586700 586804 104 0.0
pump-controller-app LP_CC2652R7 (read only) 653643 653763 120 0.0
.text 569888 570008 120 0.0
shell LP_CC2652R7 (read only) 637986 638106 120 0.0
.text 557032 557152 120 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621510 621630 120 0.0
.app_xip_area 524788 524908 120 0.0
lock cyw930739m2evb_01 (read/write) 630210 630330 120 0.0
.app_xip_area 534960 535080 120 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570614 570726 112 0.0
.app_xip_area 465684 465796 112 0.0
efr32 lighting-app BRD4161A (read only) 913936 914096 160 0.0
.text 913928 914088 160 0.0
BRD4161A+rpc (read only) 948108 948268 160 0.0
.text 948100 948260 160 0.0
BRD4161A+rs911x (read only) 788508 788652 144 0.0
.text 788500 788644 144 0.0
lock-app BRD4161A+wf200 (read only) 953864 953976 112 0.0
.text 953856 953968 112 0.0
window-app BRD4161A (read only) 898880 899024 144 0.0
.text 898872 899016 144 0.0
esp32 all-clusters-app c3devkit (read only) 1002224 1002344 120 0.0
.flash.text 1002224 1002344 120 0.0
m5stack (read only) 1057135 1057299 164 0.0
.flash.text 1051751 1051915 164 0.0
k32w light k32w061+release (read/write) 680744 680872 128 0.0
.text 596608 596736 128 0.0
lock k32w061+release (read/write) 732084 732196 112 0.0
.text 647548 647660 112 0.0
linux all-clusters-app debug (read only) 2751177 2751609 432 0.0
.text 2335570 2336002 432 0.0
bridge-app debug+rpc (read only) 2023745 2024177 432 0.0
.text 1699490 1699922 432 0.0
chip-tool debug (read only) 9633029 9633317 288 0.0
.text 7761269 7761557 288 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9376100 9376516 416 0.0
.text 7405588 7406004 416 0.0
lighting-app debug+rpc (read only) 2314097 2314513 416 0.0
.text 1961970 1962386 416 0.0
lock-app debug (read only) 2253241 2253657 416 0.0
.text 1893138 1893554 416 0.0
ota-provider-app debug (read only) 2066369 2066673 304 0.0
.text 1728034 1728338 304 0.0
ota-requestor-app debug (read only) 2095585 2096001 416 0.0
.text 1759778 1760194 416 0.0
shell debug (read only) 2555537 2555953 416 0.0
.text 2174258 2174674 416 0.0
thermostat-no-ble arm64 (read only) 2359708 2360252 544 0.0
.text 1983344 1983888 544 0.0
tv-app debug (read only) 2875017 2875433 416 0.0
.text 2470802 2471218 416 0.0
tv-casting-app debug (read only) 5432729 5433145 416 0.0
.text 4734114 4734530 416 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2423816 2423944 128 0.0
.text 1386460 1386588 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181375 1181487 112 0.0
text 810288 810408 120 0.0
p6 all-clusters-app default (read/write) 2536592 2536736 144 0.0
.text 1494856 1495000 144 0.0
light-app default (read/write) 2419880 2420024 144 0.0
.text 1378144 1378288 144 0.0
lock-app default (read/write) 2437912 2438056 144 0.0
.text 1396176 1396320 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779400 779520 120 0.0
text 551116 551230 114 0.0
lighting-app tlsr9518adk80d (read/write) 799424 799536 112 0.0
text 567850 567964 114 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 3956a9d 6e64bf7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 163776 163656 -120 -0.1
pump-app LP_CC2652R7 (read/write) 168524 168420 -104 -0.1
pump-controller-app LP_CC2652R7 (read/write) 190452 190332 -120 -0.1
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3956a9d 6e64bf7 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 644979 645099 120 0.0
(read/write) 159144 159144 0 0.0
.bss 74828 74828 0 0.0
.data 3400 3400 0 0.0
.rodata 83747 83747 0 0.0
.text 560996 561116 120 0.0
lock-ftd LP_CC2652R7 (read only) 679295 679415 120 0.0
(read/write) 163776 163656 -120 -0.1
.bss 72852 72852 0 0.0
.data 3264 3264 0 0.0
.rodata 96055 96055 0 0.0
.text 582756 582876 120 0.0
lock-mtd LP_CC2652R7 (read only) 628695 628815 120 0.0
(read/write) 145968 145968 0 0.0
.bss 68588 68588 0 0.0
.data 3264 3264 0 0.0
.rodata 95935 95935 0 0.0
.text 532268 532388 120 0.0
pump-app LP_CC2652R7 (read only) 675715 675819 104 0.0
(read/write) 168524 168420 -104 -0.1
.bss 73252 73252 0 0.0
.data 3300 3300 0 0.0
.rodata 88531 88531 0 0.0
.text 586700 586804 104 0.0
pump-controller-app LP_CC2652R7 (read only) 653643 653763 120 0.0
(read/write) 190452 190332 -120 -0.1
.bss 73108 73108 0 0.0
.data 3260 3260 0 0.0
.rodata 83275 83275 0 0.0
.text 569888 570008 120 0.0
shell LP_CC2652R7 (read only) 637986 638106 120 0.0
(read/write) 154708 154708 0 0.0
.bss 77188 77188 0 0.0
.data 3404 3404 0 0.0
.rodata 80722 80722 0 0.0
.text 557032 557152 120 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621510 621630 120 0.0
.app_xip_area 524788 524908 120 0.0
.bss 79364 79364 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630210 630330 120 0.0
.app_xip_area 534960 535080 120 0.0
.bss 77924 77924 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570614 570726 112 0.0
.app_xip_area 465684 465796 112 0.0
.bss 87284 87284 0 0.0
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 913936 914096 160 0.0
(read/write) 133448 133448 0 0.0
.bss 131352 131352 0 0.0
.data 2092 2092 0 0.0
.text 913928 914088 160 0.0
BRD4161A+rpc (read only) 948108 948268 160 0.0
(read/write) 150136 150136 0 0.0
.bss 147840 147840 0 0.0
.data 2296 2296 0 0.0
.text 948100 948260 160 0.0
BRD4161A+rs911x (read only) 788508 788652 144 0.0
(read/write) 129712 129712 0 0.0
.bss 127612 127612 0 0.0
.data 2100 2100 0 0.0
.text 788500 788644 144 0.0
lock-app BRD4161A+wf200 (read only) 953864 953976 112 0.0
(read/write) 128484 128484 0 0.0
.bss 126420 126420 0 0.0
.data 2064 2064 0 0.0
.text 953856 953968 112 0.0
window-app BRD4161A (read only) 898880 899024 144 0.0
(read/write) 133504 133504 0 0.0
.bss 131416 131416 0 0.0
.data 2088 2088 0 0.0
.text 898872 899016 144 0.0
esp32 all-clusters-app c3devkit (read only) 1002224 1002344 120 0.0
(read/write) 1479314 1479314 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14640 14640 0 0.0
.flash.rodata 209840 209840 0 0.0
.flash.text 1002224 1002344 120 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1057135 1057299 164 0.0
(read/write) 481288 481288 0 0.0
.dram0.bss 74912 74912 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240172 240172 0 0.0
.flash.text 1051751 1051915 164 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680744 680872 128 0.0
.bss 80424 80424 0 0.0
.data 2008 2008 0 0.0
.text 596608 596736 128 0.0
lock k32w061+release (read/write) 732084 732196 112 0.0
.bss 80856 80856 0 0.0
.data 1976 1976 0 0.0
.text 647548 647660 112 0.0
linux all-clusters-app debug (read only) 2751177 2751609 432 0.0
(read/write) 178240 178240 0 0.0
.bss 86496 86496 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83560 83560 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 242013 242013 0 0.0
.text 2335570 2336002 432 0.0
bridge-app debug+rpc (read only) 2023745 2024177 432 0.0
(read/write) 147896 147896 0 0.0
.bss 73120 73120 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65272 65272 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168096 168096 0 0.0
.text 1699490 1699922 432 0.0
chip-tool debug (read only) 9633029 9633317 288 0.0
(read/write) 596016 596016 0 0.0
.bss 23936 23936 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 564656 564656 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 494141 494141 0 0.0
.text 7761269 7761557 288 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9376100 9376516 416 0.0
(read/write) 662145 662145 0 0.0
.bss 42225 42225 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 599960 599960 0 0.0
.dynamic 560 560 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 457932 457932 0 0.0
.text 7405588 7406004 416 0.0
lighting-app debug+rpc (read only) 2314097 2314513 416 0.0
(read/write) 153536 153536 0 0.0
.bss 74944 74944 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70776 70776 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 186760 186760 0 0.0
.text 1961970 1962386 416 0.0
lock-app debug (read only) 2253241 2253657 416 0.0
(read/write) 148600 148600 0 0.0
.bss 73632 73632 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67704 67704 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200168 200168 0 0.0
.text 1893138 1893554 416 0.0
ota-provider-app debug (read only) 2066369 2066673 304 0.0
(read/write) 141360 141360 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 60776 60776 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 179768 179768 0 0.0
.text 1728034 1728338 304 0.0
ota-requestor-app debug (read only) 2095585 2096001 416 0.0
(read/write) 144200 144200 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 62872 62872 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 175776 175776 0 0.0
.text 1759778 1760194 416 0.0
shell debug (read only) 2555537 2555953 416 0.0
(read/write) 201744 201744 0 0.0
.bss 117416 117416 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222194 222194 0 0.0
.text 2174258 2174674 416 0.0
thermostat-no-ble arm64 (read only) 2359708 2360252 544 0.0
(read/write) 177377 177377 0 0.0
.bss 88177 88177 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 79872 79872 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 147404 147404 0 0.0
.text 1983344 1983888 544 0.0
tv-app debug (read only) 2875017 2875433 416 0.0
(read/write) 280368 280368 0 0.0
.bss 191304 191304 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221728 221728 0 0.0
.text 2470802 2471218 416 0.0
tv-casting-app debug (read only) 5432729 5433145 416 0.0
(read/write) 226256 226256 0 0.0
.bss 78888 78888 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138736 138736 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339264 339264 0 0.0
.text 4734114 4734530 416 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2423816 2423944 128 0.0
.bss 202868 202868 0 0.0
.data 5872 5872 0 0.0
.text 1386460 1386588 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181375 1181487 112 0.0
bss 139532 139532 0 0.0
rodata 152656 152656 0 0.0
text 810288 810408 120 0.0
p6 all-clusters-app default (read/write) 2536592 2536736 144 0.0
.bss 137352 137352 0 0.0
.data 2800 2800 0 0.0
.text 1494856 1495000 144 0.0
light-app default (read/write) 2419880 2420024 144 0.0
.bss 129688 129688 0 0.0
.data 2600 2600 0 0.0
.text 1378144 1378288 144 0.0
lock-app default (read/write) 2437912 2438056 144 0.0
.bss 129496 129496 0 0.0
.data 2568 2568 0 0.0
.text 1396176 1396320 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779400 779520 120 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 551116 551230 114 0.0
lighting-app tlsr9518adk80d (read/write) 799424 799536 112 0.0
bss 71076 71076 0 0.0
noinit 40416 40416 0 0.0
text 567850 567964 114 0.0

bzbarsky-apple
bzbarsky-apple requested changes May 27, 2022
View reviewed changes
src/credentials/FabricTable.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.cpp Outdated Show resolved Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Outdated Show resolved Hide resolved
@emargolis emargolis force-pushed the emargolis/feature/update-noc branch from 6e64bf7 to f0c50dd Compare May 31, 2022 23:20
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

PR #18866: Size comparison from eb3ac83 to f0c50dd

Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 f0c50dd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648339 152 0.0
.text 563684 563836 152 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615179 152 0.0
.text 541132 541284 152 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679875 144 0.0
.text 583036 583180 144 0.0
lock-mtd LP_CC2652R7 (read only) 629147 629291 144 0.0
.text 532556 532700 144 0.0
pump-app LP_CC2652R7 (read only) 676167 676295 128 0.0
.text 586996 587124 128 0.0
pump-controller-app LP_CC2652R7 (read only) 654087 654231 144 0.0
.text 570184 570328 144 0.0
shell LP_CC2652R7 (read only) 641194 641338 144 0.0
.text 559712 559856 144 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621934 144 0.0
.app_xip_area 525368 525512 144 0.0
lock cyw930739m2evb_01 (read/write) 630498 630642 144 0.0
.app_xip_area 535548 535692 144 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571146 136 0.0
.app_xip_area 466132 466268 136 0.0
efr32 lighting-app BRD4161A (read only) 914500 914580 80 0.0
.text 914492 914572 80 0.0
BRD4161A+rpc (read only) 948736 948800 64 0.0
.text 948728 948792 64 0.0
BRD4161A+rs911x (read only) 789360 789440 80 0.0
.text 789352 789432 80 0.0
lock-app BRD4161A+wf200 (read only) 954460 954604 144 0.0
.text 954452 954596 144 0.0
window-app BRD4161A (read only) 899428 899508 80 0.0
.text 899420 899500 80 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005664 182 0.0
.flash.text 1005482 1005664 182 0.0
m5stack (read only) 1060687 1060851 164 0.0
.flash.text 1055303 1055467 164 0.0
k32w light k32w061+release (read/write) 680932 681092 160 0.0
.text 597048 597208 160 0.0
lock k32w061+release (read/write) 732420 732564 144 0.0
.text 648136 648280 144 0.0
linux all-clusters-app debug (read only) 2769745 2771121 1376 0.0
.text 2352114 2353490 1376 0.1
all-clusters-minimal-app debug (read only) 2646865 2648241 1376 0.1
.text 2228706 2230082 1376 0.1
bridge-app debug+rpc (read only) 2030057 2031433 1376 0.1
.text 1704770 1706146 1376 0.1
chip-tool debug (read only) 9669565 9669837 272 0.0
.text 7784261 7784533 272 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9414156 304 0.0
.text 7429556 7429860 304 0.0
lighting-app debug+rpc (read only) 2319889 2321281 1392 0.1
.text 1966418 1967810 1392 0.1
lock-app debug (read only) 2258649 2260041 1392 0.1
.text 1897426 1898818 1392 0.1
ota-provider-app debug (read only) 2067729 2067985 256 0.0
.text 1728450 1728706 256 0.0
ota-requestor-app debug (read only) 2096529 2097905 1376 0.1
.text 1759714 1761090 1376 0.1
shell debug (read only) 2573833 2575225 1392 0.1
.text 2190594 2191986 1392 0.1
thermostat-no-ble arm64 (read only) 2366708 2367892 1184 0.1
.text 1988912 1990096 1184 0.1
tv-app debug (read only) 2876433 2877809 1376 0.0
.text 2471714 2473090 1376 0.1
tv-casting-app debug (read only) 5434009 5435385 1376 0.0
.text 4734562 4735938 1376 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425016 2425240 224 0.0
.text 1387660 1387884 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186599 144 0.0
text 814672 814816 144 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135315 144 0.0
text 787672 787816 144 0.0
p6 all-clusters-app default (read/write) 2540960 2541040 80 0.0
.text 1499224 1499304 80 0.0
all-clusters-minimal-app default (read/write) 2486928 2487008 80 0.0
.text 1445192 1445272 80 0.0
light-app default (read/write) 2420872 2420968 96 0.0
.text 1379136 1379232 96 0.0
lock-app default (read/write) 2438912 2438992 80 0.0
.text 1397176 1397256 80 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779780 184 0.0
text 551404 551588 184 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799824 184 0.0
text 568146 568330 184 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section eb3ac83 f0c50dd change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 163092 162948 -144 -0.1
pump-app LP_CC2652R7 (read/write) 167824 167696 -128 -0.1
pump-controller-app LP_CC2652R7 (read/write) 189760 189616 -144 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 f0c50dd change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648339 152 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84267 84267 0 0.0
.text 563684 563836 152 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615179 152 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73659 73659 0 0.0
.text 541132 541284 152 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679875 144 0.0
(read/write) 163092 162948 -144 -0.1
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96211 96211 0 0.0
.text 583036 583180 144 0.0
lock-mtd LP_CC2652R7 (read only) 629147 629291 144 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96099 96099 0 0.0
.text 532556 532700 144 0.0
pump-app LP_CC2652R7 (read only) 676167 676295 128 0.0
(read/write) 167824 167696 -128 -0.1
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88687 88687 0 0.0
.text 586996 587124 128 0.0
pump-controller-app LP_CC2652R7 (read only) 654087 654231 144 0.0
(read/write) 189760 189616 -144 -0.1
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83423 83423 0 0.0
.text 570184 570328 144 0.0
shell LP_CC2652R7 (read only) 641194 641338 144 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81250 81250 0 0.0
.text 559712 559856 144 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621934 144 0.0
.app_xip_area 525368 525512 144 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630642 144 0.0
.app_xip_area 535548 535692 144 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571146 136 0.0
.app_xip_area 466132 466268 136 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914500 914580 80 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914492 914572 80 0.0
BRD4161A+rpc (read only) 948736 948800 64 0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948728 948792 64 0.0
BRD4161A+rs911x (read only) 789360 789440 80 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789352 789432 80 0.0
lock-app BRD4161A+wf200 (read only) 954460 954604 144 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954452 954596 144 0.0
window-app BRD4161A (read only) 899428 899508 80 0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899420 899500 80 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005664 182 0.0
(read/write) 1479602 1479602 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210368 0 0.0
.flash.text 1005482 1005664 182 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060687 1060851 164 0.0
(read/write) 481816 481816 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 240948 0 0.0
.flash.text 1055303 1055467 164 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680932 681092 160 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 597208 160 0.0
lock k32w061+release (read/write) 732420 732564 144 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648280 144 0.0
linux all-clusters-app debug (read only) 2769745 2771121 1376 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243677 0 0.0
.text 2352114 2353490 1376 0.1
all-clusters-minimal-app debug (read only) 2646865 2648241 1376 0.1
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2228706 2230082 1376 0.1
bridge-app debug+rpc (read only) 2030057 2031433 1376 0.1
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168768 0 0.0
.text 1704770 1706146 1376 0.1
chip-tool debug (read only) 9669565 9669837 272 0.0
(read/write) 600848 600848 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569472 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496285 0 0.0
.text 7784261 7784533 272 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9414156 304 0.0
(read/write) 667105 667105 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604872 0 0.0
.dynamic 528 528 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 459972 0 0.0
.text 7429556 7429860 304 0.0
lighting-app debug+rpc (read only) 2319889 2321281 1392 0.1
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 187720 0 0.0
.text 1966418 1967810 1392 0.1
lock-app debug (read only) 2258649 2260041 1392 0.1
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1897426 1898818 1392 0.1
ota-provider-app debug (read only) 2067729 2067985 256 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180184 0 0.0
.text 1728450 1728706 256 0.0
ota-requestor-app debug (read only) 2096529 2097905 1376 0.1
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176256 0 0.0
.text 1759714 1761090 1376 0.1
shell debug (read only) 2573833 2575225 1392 0.1
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223794 0 0.0
.text 2190594 2191986 1392 0.1
thermostat-no-ble arm64 (read only) 2366708 2367892 1184 0.1
(read/write) 177441 177441 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148164 0 0.0
.text 1988912 1990096 1184 0.1
tv-app debug (read only) 2876433 2877809 1376 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222112 0 0.0
.text 2471714 2473090 1376 0.1
tv-casting-app debug (read only) 5434009 5435385 1376 0.0
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339808 0 0.0
.text 4734562 4735938 1376 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2425240 224 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387884 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186599 144 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814672 814816 144 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135315 144 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787672 787816 144 0.0
p6 all-clusters-app default (read/write) 2540960 2541040 80 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499304 80 0.0
all-clusters-minimal-app default (read/write) 2486928 2487008 80 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445272 80 0.0
light-app default (read/write) 2420872 2420968 96 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379232 96 0.0
lock-app default (read/write) 2438912 2438992 80 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397256 80 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779780 184 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551588 184 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799824 184 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568330 184 0.0

@emargolis emargolis force-pushed the emargolis/feature/update-noc branch from f0c50dd to 708b9fe Compare June 1, 2022 03:49
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #18866: Size comparison from 50d1c8e to 708b9fe

Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 50d1c8e 708b9fe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648347 648499 152 0.0
.text 563612 563764 152 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615179 615331 152 0.0
.text 541060 541212 152 0.0
lock-ftd LP_CC2652R7 (read only) 679995 680139 144 0.0
.text 582948 583092 144 0.0
lock-mtd LP_CC2652R7 (read only) 629411 629555 144 0.0
.text 532468 532612 144 0.0
pump-app LP_CC2652R7 (read only) 676415 676559 144 0.0
.text 586892 587036 144 0.0
pump-controller-app LP_CC2652R7 (read only) 654343 654487 144 0.0
.text 570096 570240 144 0.0
shell LP_CC2652R7 (read only) 641362 641490 128 0.0
.text 559640 559768 128 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 622118 622270 152 0.0
.app_xip_area 525696 525848 152 0.0
lock cyw930739m2evb_01 (read/write) 630826 630970 144 0.0
.app_xip_area 535876 536020 144 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570978 571114 136 0.0
.app_xip_area 466100 466236 136 0.0
efr32 lighting-app BRD4161A (read only) 914876 914956 80 0.0
.text 914868 914948 80 0.0
BRD4161A+rpc (read only) 949032 949096 64 0.0
.text 949024 949088 64 0.0
BRD4161A+rs911x (read only) 789736 789816 80 0.0
.text 789728 789808 80 0.0
lock-app BRD4161A+wf200 (read only) 954756 954900 144 0.0
.text 954748 954892 144 0.0
window-app BRD4161A (read only) 899796 899892 96 0.0
.text 899788 899884 96 0.0
esp32 all-clusters-app c3devkit (read only) 1005546 1005732 186 0.0
.flash.text 1005546 1005732 186 0.0
m5stack (read only) 1060695 1060859 164 0.0
.flash.text 1055311 1055475 164 0.0
k32w light k32w061+release (read/write) 680700 680860 160 0.0
.text 596816 596976 160 0.0
lock k32w061+release (read/write) 732692 732852 160 0.0
.text 648408 648568 160 0.0
linux all-clusters-app debug (read only) 2769985 2771361 1376 0.0
.text 2351650 2353026 1376 0.1
all-clusters-minimal-app debug (read only) 2647073 2648449 1376 0.1
.text 2228242 2229618 1376 0.1
bridge-app debug+rpc (read only) 2030297 2031673 1376 0.1
.text 1704306 1705682 1376 0.1
chip-tool debug (read only) 9668925 9669197 272 0.0
.text 7783637 7783909 272 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413324 9413628 304 0.0
.text 7429236 7429540 304 0.0
lighting-app debug+rpc (read only) 2319921 2321313 1392 0.1
.text 1965714 1967106 1392 0.1
lock-app debug (read only) 2258857 2260233 1376 0.1
.text 1896962 1898338 1376 0.1
ota-provider-app debug (read only) 2068689 2068961 272 0.0
.text 1728674 1728946 272 0.0
ota-requestor-app debug (read only) 2096753 2098145 1392 0.1
.text 1759234 1760626 1392 0.1
shell debug (read only) 2574073 2575449 1376 0.1
.text 2190130 2191506 1376 0.1
thermostat-no-ble arm64 (read only) 2367316 2368500 1184 0.1
.text 1988960 1990144 1184 0.1
tv-app debug (read only) 2876689 2878081 1392 0.0
.text 2471234 2472626 1392 0.1
tv-casting-app debug (read only) 5430313 5431689 1376 0.0
.text 4730706 4732082 1376 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2424832 2425056 224 0.0
.text 1387476 1387700 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186795 1186939 144 0.0
text 814632 814780 148 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135531 1135675 144 0.0
text 787636 787784 148 0.0
p6 all-clusters-app default (read/write) 2541352 2541448 96 0.0
.text 1499616 1499712 96 0.0
all-clusters-minimal-app default (read/write) 2487304 2487400 96 0.0
.text 1445568 1445664 96 0.0
light-app default (read/write) 2421248 2421344 96 0.0
.text 1379512 1379608 96 0.0
lock-app default (read/write) 2439296 2439392 96 0.0
.text 1397560 1397656 96 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780048 780232 184 0.0
text 551456 551644 188 0.0
lighting-app tlsr9518adk80d (read/write) 800092 800276 184 0.0
text 568198 568386 188 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 50d1c8e 708b9fe change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162828 162684 -144 -0.1
pump-app LP_CC2652R7 (read/write) 167576 167432 -144 -0.1
pump-controller-app LP_CC2652R7 (read/write) 189504 189360 -144 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 50d1c8e 708b9fe change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648347 648499 152 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84499 84499 0 0.0
.text 563612 563764 152 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615179 615331 152 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73883 73883 0 0.0
.text 541060 541212 152 0.0
lock-ftd LP_CC2652R7 (read only) 679995 680139 144 0.0
(read/write) 162828 162684 -144 -0.1
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96563 96563 0 0.0
.text 582948 583092 144 0.0
lock-mtd LP_CC2652R7 (read only) 629411 629555 144 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96451 96451 0 0.0
.text 532468 532612 144 0.0
pump-app LP_CC2652R7 (read only) 676415 676559 144 0.0
(read/write) 167576 167432 -144 -0.1
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89039 89039 0 0.0
.text 586892 587036 144 0.0
pump-controller-app LP_CC2652R7 (read only) 654343 654487 144 0.0
(read/write) 189504 189360 -144 -0.1
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83767 83767 0 0.0
.text 570096 570240 144 0.0
shell LP_CC2652R7 (read only) 641362 641490 128 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81490 81490 0 0.0
.text 559640 559768 128 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 622118 622270 152 0.0
.app_xip_area 525696 525848 152 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630826 630970 144 0.0
.app_xip_area 535876 536020 144 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 570978 571114 136 0.0
.app_xip_area 466100 466236 136 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914876 914956 80 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914868 914948 80 0.0
BRD4161A+rpc (read only) 949032 949096 64 0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949024 949088 64 0.0
BRD4161A+rs911x (read only) 789736 789816 80 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789728 789808 80 0.0
lock-app BRD4161A+wf200 (read only) 954756 954900 144 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954748 954892 144 0.0
window-app BRD4161A (read only) 899796 899892 96 0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899788 899884 96 0.0
esp32 all-clusters-app c3devkit (read only) 1005546 1005732 186 0.0
(read/write) 1480002 1480002 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210768 210768 0 0.0
.flash.text 1005546 1005732 186 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060695 1060859 164 0.0
(read/write) 482208 482208 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241340 241340 0 0.0
.flash.text 1055311 1055475 164 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680700 680860 160 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 596816 596976 160 0.0
lock k32w061+release (read/write) 732692 732852 160 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648408 648568 160 0.0
linux all-clusters-app debug (read only) 2769985 2771361 1376 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244381 244381 0 0.0
.text 2351650 2353026 1376 0.1
all-clusters-minimal-app debug (read only) 2647073 2648449 1376 0.1
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246269 246269 0 0.0
.text 2228242 2229618 1376 0.1
bridge-app debug+rpc (read only) 2030297 2031673 1376 0.1
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169472 169472 0 0.0
.text 1704306 1705682 1376 0.1
chip-tool debug (read only) 9668925 9669197 272 0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496701 496701 0 0.0
.text 7783637 7783909 272 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413324 9413628 304 0.0
(read/write) 666929 666929 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604696 0 0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460228 460228 0 0.0
.text 7429236 7429540 304 0.0
lighting-app debug+rpc (read only) 2319921 2321313 1392 0.1
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188456 188456 0 0.0
.text 1965714 1967106 1392 0.1
lock-app debug (read only) 2258857 2260233 1376 0.1
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201576 201576 0 0.0
.text 1896962 1898338 1376 0.1
ota-provider-app debug (read only) 2068689 2068961 272 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180920 180920 0 0.0
.text 1728674 1728946 272 0.0
ota-requestor-app debug (read only) 2096753 2098145 1392 0.1
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176960 176960 0 0.0
.text 1759234 1760626 1392 0.1
shell debug (read only) 2574073 2575449 1376 0.1
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224498 224498 0 0.0
.text 2190130 2191506 1376 0.1
thermostat-no-ble arm64 (read only) 2367316 2368500 1184 0.1
(read/write) 177457 177457 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80216 80216 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148708 148708 0 0.0
.text 1988960 1990144 1184 0.1
tv-app debug (read only) 2876689 2878081 1392 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222848 222848 0 0.0
.text 2471234 2472626 1392 0.1
tv-casting-app debug (read only) 5430313 5431689 1376 0.0
(read/write) 226000 226000 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138760 138760 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340352 340352 0 0.0
.text 4730706 4732082 1376 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424832 2425056 224 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387476 1387700 224 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186795 1186939 144 0.0
bss 139280 139280 0 0.0
rodata 153980 153980 0 0.0
text 814632 814780 148 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135531 1135675 144 0.0
bss 138508 138508 0 0.0
rodata 130548 130548 0 0.0
text 787636 787784 148 0.0
p6 all-clusters-app default (read/write) 2541352 2541448 96 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499616 1499712 96 0.0
all-clusters-minimal-app default (read/write) 2487304 2487400 96 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445568 1445664 96 0.0
light-app default (read/write) 2421248 2421344 96 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379512 1379608 96 0.0
lock-app default (read/write) 2439296 2439392 96 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397560 1397656 96 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780048 780232 184 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551456 551644 188 0.0
lighting-app tlsr9518adk80d (read/write) 800092 800276 184 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568198 568386 188 0.0

@emargolis emargolis force-pushed the emargolis/feature/update-noc branch from 708b9fe to 31efdec Compare June 2, 2022 17:46
@emargolis emargolis requested a review from bzbarsky-apple June 2, 2022 18:18
@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #18866: Size comparison from 6c4b54e to 31efdec

Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6c4b54e 31efdec change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648691 648859 168 0.0
.text 563924 564092 168 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615523 615691 168 0.0
.text 541372 541540 168 0.0
lock-ftd LP_CC2652R7 (read only) 680755 680947 192 0.0
.text 583644 583836 192 0.0
lock-mtd LP_CC2652R7 (read only) 630155 630347 192 0.0
.text 533156 533348 192 0.0
pump-app LP_CC2652R7 (read only) 663627 663819 192 0.0
.text 577504 577696 192 0.0
pump-controller-app LP_CC2652R7 (read only) 655083 655259 176 0.0
.text 570768 570944 176 0.0
shell LP_CC2652R7 (read only) 641706 641874 168 0.0
.text 559952 560120 168 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602150 602286 136 0.0
.app_xip_area 461176 461312 136 0.0
lock cyw930739m2evb_01 (read/write) 598290 598426 136 0.0
.app_xip_area 457188 457324 136 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596786 596962 176 0.0
.app_xip_area 456808 456984 176 0.0
efr32 lighting-app BRD4161A (read only) 915712 915824 112 0.0
.text 915704 915816 112 0.0
BRD4161A+rpc (read only) 949924 950020 96 0.0
.text 949916 950012 96 0.0
BRD4161A+rs911x (read only) 787860 787972 112 0.0
.text 787852 787964 112 0.0
lock-app BRD4161A+wf200 (read only) 955400 955592 192 0.0
.text 955392 955584 192 0.0
window-app BRD4161A (read only) 900648 900760 112 0.0
.text 900640 900752 112 0.0
esp32 all-clusters-app c3devkit (read only) 1005572 1005740 168 0.0
.flash.text 1005572 1005740 168 0.0
m5stack (read only) 1060659 1060843 184 0.0
.flash.text 1055275 1055459 184 0.0
k32w light k32w061+release (read/write) 681412 681572 160 0.0
.text 597528 597688 160 0.0
lock k32w061+release (read/write) 733444 733604 160 0.0
.text 649160 649320 160 0.0
linux all-clusters-app debug (read only) 2766657 2767553 896 0.0
.text 2348130 2349026 896 0.0
all-clusters-minimal-app debug (read only) 2643809 2644705 896 0.0
.text 2224722 2225618 896 0.0
bridge-app debug+rpc (read only) 2029585 2030465 880 0.0
.text 1703282 1704162 880 0.1
chip-tool debug (read only) 9704173 9704237 64 0.0
.text 7817605 7817669 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9438980 9439076 96 0.0
.text 7453764 7453860 96 0.0
lighting-app debug+rpc (read only) 2319833 2320729 896 0.0
.text 1965378 1966274 896 0.0
lock-app debug (read only) 2258481 2259361 880 0.0
.text 1896402 1897282 880 0.0
ota-provider-app debug (read only) 2066353 2066433 80 0.0
.text 1726114 1726194 80 0.0
ota-requestor-app debug (read only) 2093377 2094273 896 0.0
.text 1755730 1756626 896 0.1
shell debug (read only) 2571641 2572537 896 0.0
.text 2187570 2188466 896 0.0
thermostat-no-ble arm64 (read only) 2367132 2368060 928 0.0
.text 1988608 1989536 928 0.0
tv-app debug (read only) 2876665 2877545 880 0.0
.text 2470994 2471874 880 0.0
tv-casting-app debug (read only) 5431169 5432065 896 0.0
.text 4731346 4732242 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425752 2426072 320 0.0
.text 1388396 1388716 320 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187927 1188103 176 0.0
text 814932 815116 184 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136659 1136851 192 0.0
text 787944 788128 184 0.0
p6 all-clusters-app default (read/write) 2541760 2541872 112 0.0
.text 1500024 1500136 112 0.0
all-clusters-minimal-app default (read/write) 2487696 2487824 128 0.0
.text 1445960 1446088 128 0.0
light-app default (read/write) 2422144 2422256 112 0.0
.text 1380408 1380520 112 0.0
lock-app default (read/write) 2440184 2440312 128 0.0
.text 1398448 1398576 128 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 781060 160 0.0
text 552238 552402 164 0.0
lighting-app tlsr9518adk80d (read/write) 800936 801104 168 0.0
text 568980 569144 164 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 6c4b54e 31efdec change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162068 161876 -192 -0.1
pump-app LP_CC2652R7 (read/write) 180108 179916 -192 -0.1
pump-controller-app LP_CC2652R7 (read/write) 188764 188588 -176 -0.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6c4b54e 31efdec change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648691 648859 168 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563924 564092 168 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615523 615691 168 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541372 541540 168 0.0
lock-ftd LP_CC2652R7 (read only) 680755 680947 192 0.0
(read/write) 162068 161876 -192 -0.1
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583644 583836 192 0.0
lock-mtd LP_CC2652R7 (read only) 630155 630347 192 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533156 533348 192 0.0
pump-app LP_CC2652R7 (read only) 663627 663819 192 0.0
(read/write) 180108 179916 -192 -0.1
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85643 85643 0 0.0
.text 577504 577696 192 0.0
pump-controller-app LP_CC2652R7 (read only) 655083 655259 176 0.0
(read/write) 188764 188588 -176 -0.1
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570768 570944 176 0.0
shell LP_CC2652R7 (read only) 641706 641874 168 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559952 560120 168 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602150 602286 136 0.0
.app_xip_area 461176 461312 136 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598290 598426 136 0.0
.app_xip_area 457188 457324 136 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596786 596962 176 0.0
.app_xip_area 456808 456984 176 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915712 915824 112 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915704 915816 112 0.0
BRD4161A+rpc (read only) 949924 950020 96 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949916 950012 96 0.0
BRD4161A+rs911x (read only) 787860 787972 112 0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 787852 787964 112 0.0
lock-app BRD4161A+wf200 (read only) 955400 955592 192 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 955392 955584 192 0.0
window-app BRD4161A (read only) 900648 900760 112 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 900640 900752 112 0.0
esp32 all-clusters-app c3devkit (read only) 1005572 1005740 168 0.0
(read/write) 1480026 1480026 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210792 210792 0 0.0
.flash.text 1005572 1005740 168 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060659 1060843 184 0.0
(read/write) 482232 482232 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241364 241364 0 0.0
.flash.text 1055275 1055459 184 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681412 681572 160 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597528 597688 160 0.0
lock k32w061+release (read/write) 733444 733604 160 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 649160 649320 160 0.0
linux all-clusters-app debug (read only) 2766657 2767553 896 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244573 244573 0 0.0
.text 2348130 2349026 896 0.0
all-clusters-minimal-app debug (read only) 2643809 2644705 896 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246525 246525 0 0.0
.text 2224722 2225618 896 0.0
bridge-app debug+rpc (read only) 2029585 2030465 880 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169760 169760 0 0.0
.text 1703282 1704162 880 0.1
chip-tool debug (read only) 9704173 9704237 64 0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497981 497981 0 0.0
.text 7817605 7817669 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9438980 9439076 96 0.0
(read/write) 666897 666897 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604672 604672 0 0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461372 461372 0 0.0
.text 7453764 7453860 96 0.0
lighting-app debug+rpc (read only) 2319833 2320729 896 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188680 188680 0 0.0
.text 1965378 1966274 896 0.0
lock-app debug (read only) 2258481 2259361 880 0.0
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201736 201736 0 0.0
.text 1896402 1897282 880 0.0
ota-provider-app debug (read only) 2066353 2066433 80 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181144 181144 0 0.0
.text 1726114 1726194 80 0.0
ota-requestor-app debug (read only) 2093377 2094273 896 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177088 177088 0 0.0
.text 1755730 1756626 896 0.1
shell debug (read only) 2571641 2572537 896 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224626 224626 0 0.0
.text 2187570 2188466 896 0.0
thermostat-no-ble arm64 (read only) 2367132 2368060 928 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1988608 1989536 928 0.0
tv-app debug (read only) 2876665 2877545 880 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223040 223040 0 0.0
.text 2470994 2471874 880 0.0
tv-casting-app debug (read only) 5431169 5432065 896 0.0
(read/write) 226032 226032 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138792 138792 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340544 340544 0 0.0
.text 4731346 4732242 896 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425752 2426072 320 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388396 1388716 320 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187927 1188103 176 0.0
bss 141277 141277 0 0.0
rodata 152832 152832 0 0.0
text 814932 815116 184 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136659 1136851 192 0.0
bss 140506 140506 0 0.0
rodata 129396 129396 0 0.0
text 787944 788128 184 0.0
p6 all-clusters-app default (read/write) 2541760 2541872 112 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1500024 1500136 112 0.0
all-clusters-minimal-app default (read/write) 2487696 2487824 128 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445960 1446088 128 0.0
light-app default (read/write) 2422144 2422256 112 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380408 1380520 112 0.0
lock-app default (read/write) 2440184 2440312 128 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398448 1398576 128 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 781060 160 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552238 552402 164 0.0
lighting-app tlsr9518adk80d (read/write) 800936 801104 168 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568980 569144 164 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with the gFabricBeingCommissioned cleanup we are missing added.

src/app/clusters/operational-credentials-server/operational-credentials-server.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #18866: Size comparison from 6c4b54e to 9a8a228

Increases above 0.2%:

platform target config section 6c4b54e 9a8a228 change % change
k32w light k32w061+release .data 2012 2020 8 0.4
lock k32w061+release .data 1980 1988 8 0.4
linux all-clusters-app debug .init_array 1016 1024 8 0.8
all-clusters-minimal-app debug .init_array 1016 1024 8 0.8
bridge-app debug+rpc .init_array 688 696 8 1.2
chip-tool debug .bss 23968 24032 64 0.3
.init_array 648 656 8 1.2
chip-tool-no-interactive-ipv6only arm64 .init_array 184 192 8 4.3
lighting-app debug+rpc .init_array 792 800 8 1.0
lock-app debug .init_array 752 760 8 1.1
ota-provider-app debug .init_array 648 656 8 1.2
ota-requestor-app debug .init_array 672 680 8 1.2
shell debug .init_array 928 936 8 0.9
thermostat-no-ble arm64 .init_array 376 384 8 2.1
tv-app debug .init_array 928 936 8 0.9
tv-casting-app debug .init_array 864 872 8 0.9
p6 all-clusters-minimal-app default .data 2744 2752 8 0.3
light-app default .data 2600 2608 8 0.3
lock-app default .data 2568 2576 8 0.3
Increases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6c4b54e 9a8a228 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 158900 158988 88 0.1
.bss 74580 74668 88 0.1
all-clusters-minimal-app LP_CC2652R7 (read/write) 158072 158160 88 0.1
.bss 73812 73900 88 0.1
.text 541372 541376 4 0.0
lock-ftd LP_CC2652R7 (read/write) 162068 162180 112 0.1
.bss 72604 72692 88 0.1
lock-mtd LP_CC2652R7 (read/write) 145724 145812 88 0.1
.bss 68340 68428 88 0.1
pump-app LP_CC2652R7 (read only) 663627 663771 144 0.0
.bss 72748 72836 88 0.1
.text 577504 577644 140 0.0
pump-controller-app LP_CC2652R7 (read/write) 188764 188852 88 0.0
.bss 72860 72948 88 0.1
shell LP_CC2652R7 (read/write) 154456 154544 88 0.1
.bss 76932 77020 88 0.1
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596786 596818 32 0.0
.app_xip_area 456808 456840 32 0.0
efr32 lighting-app BRD4161A (read only) 915712 915984 272 0.0
(read/write) 133184 133280 96 0.1
.bss 131088 131176 88 0.1
.data 2096 2100 4 0.2
.text 915704 915976 272 0.0
BRD4161A+rpc (read only) 949924 950196 272 0.0
(read/write) 149876 149968 92 0.1
.bss 147576 147664 88 0.1
.data 2300 2304 4 0.2
.text 949916 950188 272 0.0
BRD4161A+rs911x (read only) 787860 788052 192 0.0
(read/write) 129404 129496 92 0.1
.bss 127308 127396 88 0.1
.data 2096 2100 4 0.2
.text 787852 788044 192 0.0
lock-app BRD4161A+wf200 (read/write) 128244 128332 88 0.1
.bss 126172 126260 88 0.1
.data 2068 2072 4 0.2
window-app BRD4161A (read only) 900648 900904 256 0.0
(read/write) 133256 133344 88 0.1
.bss 131160 131248 88 0.1
.data 2092 2096 4 0.2
.text 900640 900896 256 0.0
esp32 all-clusters-app c3devkit (read/write) 1480026 1480114 88 0.0
.dram0.bss 69144 69232 88 0.1
.flash.rodata 210792 210800 8 0.0
m5stack (read/write) 482232 482324 92 0.0
.dram0.bss 74664 74752 88 0.1
.flash.rodata 241364 241368 4 0.0
k32w light k32w061+release .data 2012 2020 8 0.4
lock k32w061+release .data 1980 1988 8 0.4
linux all-clusters-app debug (read only) 2766657 2767577 920 0.0
(read/write) 178272 178344 72 0.0
.bss 86240 86304 64 0.1
.init_array 1016 1024 8 0.8
.text 2348130 2349026 896 0.0
all-clusters-minimal-app debug (read only) 2643809 2644729 920 0.0
(read/write) 170304 170376 72 0.0
.bss 85504 85568 64 0.1
.init_array 1016 1024 8 0.8
.text 2224722 2225618 896 0.0
bridge-app debug+rpc (read only) 2029585 2030601 1016 0.1
(read/write) 147928 148000 72 0.0
.bss 72896 72960 64 0.1
.init_array 688 696 8 1.2
.text 1703282 1704274 992 0.1
chip-tool debug .bss 23968 24032 64 0.3
.init_array 648 656 8 1.2
chip-tool-no-interactive-ipv6only arm64 .bss 42257 42305 48 0.1
.init_array 184 192 8 4.3
lighting-app debug+rpc (read only) 2319833 2320753 920 0.0
(read/write) 153568 153640 72 0.0
.bss 74752 74816 64 0.1
.init_array 792 800 8 1.0
.text 1965378 1966274 896 0.0
lock-app debug (read only) 2258481 2259385 904 0.0
(read/write) 148664 148736 72 0.0
.bss 73440 73504 64 0.1
.init_array 752 760 8 1.1
.text 1896402 1897282 880 0.0
ota-provider-app debug (read only) 2066353 2066585 232 0.0
(read/write) 141584 141656 72 0.1
.bss 73024 73088 64 0.1
.init_array 648 656 8 1.2
.text 1726114 1726322 208 0.0
ota-requestor-app debug (read only) 2093377 2094425 1048 0.1
(read/write) 144424 144496 72 0.0
.bss 73728 73792 64 0.1
.init_array 672 680 8 1.2
.text 1755730 1756754 1024 0.1
shell debug (read only) 2571641 2572561 920 0.0
(read/write) 201680 201752 72 0.0
.bss 117096 117160 64 0.1
.init_array 928 936 8 0.9
.text 2187570 2188466 896 0.0
thermostat-no-ble arm64 (read only) 2367132 2367612 480 0.0
(read/write) 177505 177601 96 0.1
.bss 87921 87969 48 0.1
.data.rel.ro 80264 80288 24 0.0
.got 4792 4800 8 0.2
.init_array 376 384 8 2.1
.text 1988608 1989008 400 0.0
tv-app debug (read only) 2876665 2877713 1048 0.0
(read/write) 280208 280280 72 0.0
.bss 191048 191112 64 0.0
.init_array 928 936 8 0.9
.text 2470994 2472018 1024 0.0
tv-casting-app debug .bss 78632 78696 64 0.1
.init_array 864 872 8 0.9
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425752 2425760 8 0.0
.bss 202620 202652 32 0.0
.data 5872 5880 8 0.1
.text 1388396 1388404 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 bss 141277 141297 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 bss 140506 140526 20 0.0
p6 all-clusters-app default (read/write) 2541760 2541936 176 0.0
.bss 137104 137192 88 0.1
.text 1500024 1500200 176 0.0
all-clusters-minimal-app default (read/write) 2487696 2487904 208 0.0
.bss 136328 136416 88 0.1
.data 2744 2752 8 0.3
.text 1445960 1446168 208 0.0
light-app default (read/write) 2422144 2422304 160 0.0
.bss 129432 129520 88 0.1
.data 2600 2608 8 0.3
.text 1380408 1380568 160 0.0
lock-app default (read/write) 2440184 2440344 160 0.0
.bss 129248 129336 88 0.1
.data 2568 2576 8 0.3
.text 1398448 1398608 160 0.0
telink light-switch-app tlsr9518adk80d bss 70564 70584 20 0.0
text 552238 552298 60 0.0
lighting-app tlsr9518adk80d bss 70824 70844 20 0.0
text 568980 569040 60 0.0
Decreases (20 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, telink)
platform target config section 6c4b54e 9a8a228 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648691 648643 -48 -0.0
.text 563924 563880 -44 -0.0
lock-ftd LP_CC2652R7 (read only) 680755 680731 -24 -0.0
.text 583644 583624 -20 -0.0
lock-mtd LP_CC2652R7 (read only) 630155 630131 -24 -0.0
.text 533156 533136 -20 -0.0
pump-app LP_CC2652R7 (read/write) 180108 180052 -56 -0.0
pump-controller-app LP_CC2652R7 .text 570768 570764 -4 -0.0
shell LP_CC2652R7 (read only) 641706 641666 -40 -0.0
.text 559952 559908 -44 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602150 602046 -104 -0.0
.app_xip_area 461176 461072 -104 -0.0
lock cyw930739m2evb_01 (read/write) 598290 598154 -136 -0.0
.app_xip_area 457188 457052 -136 -0.0
efr32 lock-app BRD4161A+wf200 (read only) 955400 955336 -64 -0.0
.text 955392 955328 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 1005572 1005466 -106 -0.0
.flash.text 1005572 1005466 -106 -0.0
m5stack (read only) 1060659 1060643 -16 -0.0
.flash.text 1055275 1055259 -16 -0.0
k32w light k32w061+release (read/write) 681412 657956 -23456 -3.4
.bss 80168 69768 -10400 -13.0
.text 597528 580368 -17160 -2.9
lock k32w061+release (read/write) 733444 716928 -16516 -2.3
.bss 80600 70192 -10408 -12.9
.text 649160 638948 -10212 -1.6
linux chip-tool debug (read only) 9704173 9591413 -112760 -1.2
(read/write) 600688 597048 -3640 -0.6
.data.rel.ro 569296 565600 -3696 -0.6
.rodata 497981 494909 -3072 -0.6
.text 7817605 7716965 -100640 -1.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9438980 9345572 -93408 -1.0
(read/write) 666897 662961 -3936 -0.6
.data.rel.ro 604672 600832 -3840 -0.6
.got 14984 14824 -160 -1.1
.rodata 461372 458652 -2720 -0.6
.text 7453764 7372756 -81008 -1.1
tv-casting-app debug (read only) 5431169 5327609 -103560 -1.9
(read/write) 226032 222744 -3288 -1.5
.data.rel.ro 138792 135432 -3360 -2.4
.rodata 340544 337408 -3136 -0.9
.text 4731346 4638962 -92384 -2.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187927 1187879 -48 -0.0
text 814932 814884 -48 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136659 1136643 -16 -0.0
text 787944 787928 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780864 -36 -0.0
lighting-app tlsr9518adk80d (read/write) 800936 800900 -36 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6c4b54e 9a8a228 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648691 648643 -48 -0.0
(read/write) 158900 158988 88 0.1
.bss 74580 74668 88 0.1
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563924 563880 -44 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615523 615523 0 0.0
(read/write) 158072 158160 88 0.1
.bss 73812 73900 88 0.1
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541372 541376 4 0.0
lock-ftd LP_CC2652R7 (read only) 680755 680731 -24 -0.0
(read/write) 162068 162180 112 0.1
.bss 72604 72692 88 0.1
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583644 583624 -20 -0.0
lock-mtd LP_CC2652R7 (read only) 630155 630131 -24 -0.0
(read/write) 145724 145812 88 0.1
.bss 68340 68428 88 0.1
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533156 533136 -20 -0.0
pump-app LP_CC2652R7 (read only) 663627 663771 144 0.0
(read/write) 180108 180052 -56 -0.0
.bss 72748 72836 88 0.1
.data 3300 3300 0 0.0
.rodata 85643 85643 0 0.0
.text 577504 577644 140 0.0
pump-controller-app LP_CC2652R7 (read only) 655083 655083 0 0.0
(read/write) 188764 188852 88 0.0
.bss 72860 72948 88 0.1
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570768 570764 -4 -0.0
shell LP_CC2652R7 (read only) 641706 641666 -40 -0.0
(read/write) 154456 154544 88 0.1
.bss 76932 77020 88 0.1
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559952 559908 -44 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602150 602046 -104 -0.0
.app_xip_area 461176 461072 -104 -0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598290 598154 -136 -0.0
.app_xip_area 457188 457052 -136 -0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596786 596818 32 0.0
.app_xip_area 456808 456840 32 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915712 915984 272 0.0
(read/write) 133184 133280 96 0.1
.bss 131088 131176 88 0.1
.data 2096 2100 4 0.2
.text 915704 915976 272 0.0
BRD4161A+rpc (read only) 949924 950196 272 0.0
(read/write) 149876 149968 92 0.1
.bss 147576 147664 88 0.1
.data 2300 2304 4 0.2
.text 949916 950188 272 0.0
BRD4161A+rs911x (read only) 787860 788052 192 0.0
(read/write) 129404 129496 92 0.1
.bss 127308 127396 88 0.1
.data 2096 2100 4 0.2
.text 787852 788044 192 0.0
lock-app BRD4161A+wf200 (read only) 955400 955336 -64 -0.0
(read/write) 128244 128332 88 0.1
.bss 126172 126260 88 0.1
.data 2068 2072 4 0.2
.text 955392 955328 -64 -0.0
window-app BRD4161A (read only) 900648 900904 256 0.0
(read/write) 133256 133344 88 0.1
.bss 131160 131248 88 0.1
.data 2092 2096 4 0.2
.text 900640 900896 256 0.0
esp32 all-clusters-app c3devkit (read only) 1005572 1005466 -106 -0.0
(read/write) 1480026 1480114 88 0.0
.dram0.bss 69144 69232 88 0.1
.dram0.data 14656 14656 0 0.0
.flash.rodata 210792 210800 8 0.0
.flash.text 1005572 1005466 -106 -0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060659 1060643 -16 -0.0
(read/write) 482232 482324 92 0.0
.dram0.bss 74664 74752 88 0.1
.dram0.data 34208 34208 0 0.0
.flash.rodata 241364 241368 4 0.0
.flash.text 1055275 1055259 -16 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 681412 657956 -23456 -3.4
.bss 80168 69768 -10400 -13.0
.data 2012 2020 8 0.4
.text 597528 580368 -17160 -2.9
lock k32w061+release (read/write) 733444 716928 -16516 -2.3
.bss 80600 70192 -10408 -12.9
.data 1980 1988 8 0.4
.text 649160 638948 -10212 -1.6
linux all-clusters-app debug (read only) 2766657 2767577 920 0.0
(read/write) 178272 178344 72 0.0
.bss 86240 86304 64 0.1
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1024 8 0.8
.rodata 244573 244573 0 0.0
.text 2348130 2349026 896 0.0
all-clusters-minimal-app debug (read only) 2643809 2644729 920 0.0
(read/write) 170304 170376 72 0.0
.bss 85504 85568 64 0.1
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1024 8 0.8
.rodata 246525 246525 0 0.0
.text 2224722 2225618 896 0.0
bridge-app debug+rpc (read only) 2029585 2030601 1016 0.1
(read/write) 147928 148000 72 0.0
.bss 72896 72960 64 0.1
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 696 8 1.2
.rodata 169760 169760 0 0.0
.text 1703282 1704274 992 0.1
chip-tool debug (read only) 9704173 9591413 -112760 -1.2
(read/write) 600688 597048 -3640 -0.6
.bss 23968 24032 64 0.3
.data 1120 1120 0 0.0
.data.rel.ro 569296 565600 -3696 -0.6
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 656 8 1.2
.rodata 497981 494909 -3072 -0.6
.text 7817605 7716965 -100640 -1.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9438980 9345572 -93408 -1.0
(read/write) 666897 662961 -3936 -0.6
.bss 42257 42305 48 0.1
.data 1176 1176 0 0.0
.data.rel.ro 604672 600832 -3840 -0.6
.dynamic 528 528 0 0.0
.got 14984 14824 -160 -1.1
.init 24 24 0 0.0
.init_array 184 192 8 4.3
.rodata 461372 458652 -2720 -0.6
.text 7453764 7372756 -81008 -1.1
lighting-app debug+rpc (read only) 2319833 2320753 920 0.0
(read/write) 153568 153640 72 0.0
.bss 74752 74816 64 0.1
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 800 8 1.0
.rodata 188680 188680 0 0.0
.text 1965378 1966274 896 0.0
lock-app debug (read only) 2258481 2259385 904 0.0
(read/write) 148664 148736 72 0.0
.bss 73440 73504 64 0.1
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 760 8 1.1
.rodata 201736 201736 0 0.0
.text 1896402 1897282 880 0.0
ota-provider-app debug (read only) 2066353 2066585 232 0.0
(read/write) 141584 141656 72 0.1
.bss 73024 73088 64 0.1
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 656 8 1.2
.rodata 181144 181144 0 0.0
.text 1726114 1726322 208 0.0
ota-requestor-app debug (read only) 2093377 2094425 1048 0.1
(read/write) 144424 144496 72 0.0
.bss 73728 73792 64 0.1
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 680 8 1.2
.rodata 177088 177088 0 0.0
.text 1755730 1756754 1024 0.1
shell debug (read only) 2571641 2572561 920 0.0
(read/write) 201680 201752 72 0.0
.bss 117096 117160 64 0.1
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 936 8 0.9
.rodata 224626 224626 0 0.0
.text 2187570 2188466 896 0.0
thermostat-no-ble arm64 (read only) 2367132 2367612 480 0.0
(read/write) 177505 177601 96 0.1
.bss 87921 87969 48 0.1
.data 1528 1528 0 0.0
.data.rel.ro 80264 80288 24 0.0
.dynamic 528 528 0 0.0
.got 4792 4800 8 0.2
.init 24 24 0 0.0
.init_array 376 384 8 2.1
.rodata 148828 148828 0 0.0
.text 1988608 1989008 400 0.0
tv-app debug (read only) 2876665 2877713 1048 0.0
(read/write) 280208 280280 72 0.0
.bss 191048 191112 64 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 936 8 0.9
.rodata 223040 223040 0 0.0
.text 2470994 2472018 1024 0.0
tv-casting-app debug (read only) 5431169 5327609 -103560 -1.9
(read/write) 226032 222744 -3288 -1.5
.bss 78632 78696 64 0.1
.data 2400 2400 0 0.0
.data.rel.ro 138792 135432 -3360 -2.4
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 872 8 0.9
.rodata 340544 337408 -3136 -0.9
.text 4731346 4638962 -92384 -2.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425752 2425760 8 0.0
.bss 202620 202652 32 0.0
.data 5872 5880 8 0.1
.text 1388396 1388404 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187927 1187879 -48 -0.0
bss 141277 141297 20 0.0
rodata 152832 152832 0 0.0
text 814932 814884 -48 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136659 1136643 -16 -0.0
bss 140506 140526 20 0.0
rodata 129396 129396 0 0.0
text 787944 787928 -16 -0.0
p6 all-clusters-app default (read/write) 2541760 2541936 176 0.0
.bss 137104 137192 88 0.1
.data 2808 2808 0 0.0
.text 1500024 1500200 176 0.0
all-clusters-minimal-app default (read/write) 2487696 2487904 208 0.0
.bss 136328 136416 88 0.1
.data 2744 2752 8 0.3
.text 1445960 1446168 208 0.0
light-app default (read/write) 2422144 2422304 160 0.0
.bss 129432 129520 88 0.1
.data 2600 2608 8 0.3
.text 1380408 1380568 160 0.0
lock-app default (read/write) 2440184 2440344 160 0.0
.bss 129248 129336 88 0.1
.data 2568 2576 8 0.3
.text 1398448 1398608 160 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780864 -36 -0.0
bss 70564 70584 20 0.0
noinit 40416 40416 0 0.0
text 552238 552298 60 0.0
lighting-app tlsr9518adk80d (read/write) 800936 800900 -36 -0.0
bss 70824 70844 20 0.0
noinit 40416 40416 0 0.0
text 568980 569040 60 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 3, 2022
Merged
@tcarmelveilleux tcarmelveilleux merged commit a00e966 into project-chip:master Jun 3, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @tcarmelveilleux @bzbarsky-apple