Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BitMask instead of BitFlags for data model encoding of bitmaps #19008

Merged
merged 22 commits into from
Jun 3, 2022
Merged

Use BitMask instead of BitFlags for data model encoding of bitmaps #19008

merged 22 commits into from
Jun 3, 2022

Conversation

andy31415
Copy link
Contributor

Problem

BitFlags were designed for boolean flags for individual values.
However the spec has several types that are bitmapX with specific areas set as masks.

See #18300

Change overview

Use a BitMask class that derives from BitFlags but also adds support for setting bits based on masks.

Testing

Compile only and CI should validate. Change is mostly a noop, but changes such as #18300 can start using this.

@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

PR #19008: Size comparison from eb3ac83 to fb350a9

Increases (8 builds for linux)
platform target config section eb3ac83 fb350a9 change % change
linux all-clusters-app debug (read only) 2769745 2770369 624 0.0
.text 2352114 2352738 624 0.0
all-clusters-minimal-app debug (read only) 2646865 2647361 496 0.0
.text 2228706 2229202 496 0.0
chip-tool debug (read only) 9669565 9671421 1856 0.0
.text 7784261 7786117 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9415244 1392 0.0
.text 7429556 7430948 1392 0.0
lock-app debug (read only) 2258649 2258825 176 0.0
.text 1897426 1897602 176 0.0
shell debug (read only) 2573833 2574361 528 0.0
.text 2190594 2191122 528 0.0
thermostat-no-ble arm64 (read only) 2366708 2366916 208 0.0
.text 1988912 1989120 208 0.0
tv-casting-app debug (read only) 5434009 5435273 1264 0.0
.text 4734562 4735826 1264 0.0
Decreases (1 build for linux)
platform target config section eb3ac83 fb350a9 change % change
linux lighting-app debug+rpc (read only) 2319889 2318801 -1088 -0.0
(read/write) 153536 153504 -32 -0.0
.bss 74752 74720 -32 -0.0
.rodata 187720 187400 -320 -0.2
.text 1966418 1965650 -768 -0.0
Full report (26 builds for cyw30739, k32w, linux, nrfconnect, p6, telink)
platform target config section eb3ac83 fb350a9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621790 0 0.0
.app_xip_area 525368 525368 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630498 0 0.0
.app_xip_area 535548 535548 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 680932 680932 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 597048 0 0.0
lock k32w061+release (read/write) 732420 732420 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648136 0 0.0
linux all-clusters-app debug (read only) 2769745 2770369 624 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243677 0 0.0
.text 2352114 2352738 624 0.0
all-clusters-minimal-app debug (read only) 2646865 2647361 496 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2228706 2229202 496 0.0
bridge-app debug+rpc (read only) 2030057 2030057 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168768 0 0.0
.text 1704770 1704770 0 0.0
chip-tool debug (read only) 9669565 9671421 1856 0.0
(read/write) 600848 600848 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569472 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496285 0 0.0
.text 7784261 7786117 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9415244 1392 0.0
(read/write) 667105 667105 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604872 0 0.0
.dynamic 528 528 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 459972 0 0.0
.text 7429556 7430948 1392 0.0
lighting-app debug+rpc (read only) 2319889 2318801 -1088 -0.0
(read/write) 153536 153504 -32 -0.0
.bss 74752 74720 -32 -0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 187400 -320 -0.2
.text 1966418 1965650 -768 -0.0
lock-app debug (read only) 2258649 2258825 176 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1897426 1897602 176 0.0
ota-provider-app debug (read only) 2067729 2067729 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180184 0 0.0
.text 1728450 1728450 0 0.0
ota-requestor-app debug (read only) 2096529 2096529 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176256 0 0.0
.text 1759714 1759714 0 0.0
shell debug (read only) 2573833 2574361 528 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223794 0 0.0
.text 2190594 2191122 528 0.0
thermostat-no-ble arm64 (read only) 2366708 2366916 208 0.0
(read/write) 177441 177441 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148164 0 0.0
.text 1988912 1989120 208 0.0
tv-app debug (read only) 2876433 2876433 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222112 0 0.0
.text 2471714 2471714 0 0.0
tv-casting-app debug (read only) 5434009 5435273 1264 0.0
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339808 0 0.0
.text 4734562 4735826 1264 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186455 0 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814672 814672 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135171 0 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787672 787672 0 0.0
p6 all-clusters-app default (read/write) 2540960 2540960 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499224 0 0.0
all-clusters-minimal-app default (read/write) 2486928 2486928 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445192 0 0.0
light-app default (read/write) 2420872 2420872 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379136 0 0.0
lock-app default (read/write) 2438912 2438912 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397176 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779596 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551404 0 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799640 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568146 0 0.0

@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

PR #19008: Size comparison from eb3ac83 to cf0826f

Increases (9 builds for linux)
platform target config section eb3ac83 cf0826f change % change
linux all-clusters-app debug (read only) 2769745 2770369 624 0.0
.text 2352114 2352738 624 0.0
all-clusters-minimal-app debug (read only) 2646865 2647361 496 0.0
.text 2228706 2229202 496 0.0
chip-tool debug (read only) 9669565 9671421 1856 0.0
.text 7784261 7786117 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9415244 1392 0.0
.text 7429556 7430948 1392 0.0
lighting-app debug+rpc (read only) 2319889 2320097 208 0.0
.text 1966418 1966626 208 0.0
lock-app debug (read only) 2258649 2258825 176 0.0
.text 1897426 1897602 176 0.0
shell debug (read only) 2573833 2574361 528 0.0
.text 2190594 2191122 528 0.0
thermostat-no-ble arm64 (read only) 2366708 2366916 208 0.0
.text 1988912 1989120 208 0.0
tv-casting-app debug (read only) 5434009 5435273 1264 0.0
.text 4734562 4735826 1264 0.0
Full report (29 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 cf0826f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621790 0 0.0
.app_xip_area 525368 525368 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630498 0 0.0
.app_xip_area 535548 535548 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005482 0 0.0
(read/write) 1479602 1479602 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210368 0 0.0
.flash.text 1005482 1005482 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060687 1060687 0 0.0
(read/write) 481816 481816 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 240948 0 0.0
.flash.text 1055303 1055303 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680932 680932 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 597048 0 0.0
lock k32w061+release (read/write) 732420 732420 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648136 0 0.0
linux all-clusters-app debug (read only) 2769745 2770369 624 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243677 0 0.0
.text 2352114 2352738 624 0.0
all-clusters-minimal-app debug (read only) 2646865 2647361 496 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2228706 2229202 496 0.0
bridge-app debug+rpc (read only) 2030057 2030057 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168768 0 0.0
.text 1704770 1704770 0 0.0
chip-tool debug (read only) 9669565 9671421 1856 0.0
(read/write) 600848 600848 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569472 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496285 0 0.0
.text 7784261 7786117 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9415244 1392 0.0
(read/write) 667105 667105 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604872 0 0.0
.dynamic 528 528 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 459972 0 0.0
.text 7429556 7430948 1392 0.0
lighting-app debug+rpc (read only) 2319889 2320097 208 0.0
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 187720 0 0.0
.text 1966418 1966626 208 0.0
lock-app debug (read only) 2258649 2258825 176 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1897426 1897602 176 0.0
ota-provider-app debug (read only) 2067729 2067729 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180184 0 0.0
.text 1728450 1728450 0 0.0
ota-requestor-app debug (read only) 2096529 2096529 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176256 0 0.0
.text 1759714 1759714 0 0.0
shell debug (read only) 2573833 2574361 528 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223794 0 0.0
.text 2190594 2191122 528 0.0
thermostat-no-ble arm64 (read only) 2366708 2366916 208 0.0
(read/write) 177441 177441 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148164 0 0.0
.text 1988912 1989120 208 0.0
tv-app debug (read only) 2876433 2876433 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222112 0 0.0
.text 2471714 2471714 0 0.0
tv-casting-app debug (read only) 5434009 5435273 1264 0.0
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339808 0 0.0
.text 4734562 4735826 1264 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2425016 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186455 0 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814672 814672 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135171 0 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787672 787672 0 0.0
p6 all-clusters-app default (read/write) 2540960 2540960 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499224 0 0.0
all-clusters-minimal-app default (read/write) 2486928 2486928 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445192 0 0.0
light-app default (read/write) 2420872 2420872 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379136 0 0.0
lock-app default (read/write) 2438912 2438912 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397176 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779596 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551404 0 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799640 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568146 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #19008: Size comparison from eb3ac83 to bbf903f

Increases (9 builds for linux)
platform target config section eb3ac83 bbf903f change % change
linux all-clusters-app debug (read only) 2769745 2770369 624 0.0
.text 2352114 2352738 624 0.0
all-clusters-minimal-app debug (read only) 2646865 2647361 496 0.0
.text 2228706 2229202 496 0.0
chip-tool debug (read only) 9669565 9671421 1856 0.0
.text 7784261 7786117 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9415244 1392 0.0
.text 7429556 7430948 1392 0.0
lighting-app debug+rpc (read only) 2319889 2320097 208 0.0
.text 1966418 1966626 208 0.0
lock-app debug (read only) 2258649 2258825 176 0.0
.text 1897426 1897602 176 0.0
shell debug (read only) 2573833 2574361 528 0.0
.text 2190594 2191122 528 0.0
thermostat-no-ble arm64 (read only) 2366708 2366916 208 0.0
.text 1988912 1989120 208 0.0
tv-casting-app debug (read only) 5434009 5435273 1264 0.0
.text 4734562 4735826 1264 0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eb3ac83 bbf903f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648187 648187 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84267 84267 0 0.0
.text 563684 563684 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615027 615027 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73659 73659 0 0.0
.text 541132 541132 0 0.0
lock-ftd LP_CC2652R7 (read only) 679731 679731 0 0.0
(read/write) 163092 163092 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96211 96211 0 0.0
.text 583036 583036 0 0.0
lock-mtd LP_CC2652R7 (read only) 629147 629147 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96099 96099 0 0.0
.text 532556 532556 0 0.0
pump-app LP_CC2652R7 (read only) 676167 676167 0 0.0
(read/write) 167824 167824 0 0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 88687 88687 0 0.0
.text 586996 586996 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654087 654087 0 0.0
(read/write) 189760 189760 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83423 83423 0 0.0
.text 570184 570184 0 0.0
shell LP_CC2652R7 (read only) 641194 641194 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81250 81250 0 0.0
.text 559712 559712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 621790 621790 0 0.0
.app_xip_area 525368 525368 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630498 630498 0 0.0
.app_xip_area 535548 535548 0 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571010 571010 0 0.0
.app_xip_area 466132 466132 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914500 914500 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914492 914492 0 0.0
BRD4161A+rpc (read only) 948736 948736 0 0.0
(read/write) 149880 149880 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 948728 948728 0 0.0
BRD4161A+rs911x (read only) 789360 789360 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789352 789352 0 0.0
lock-app BRD4161A+wf200 (read only) 954460 954460 0 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954452 954452 0 0.0
window-app BRD4161A (read only) 899428 899428 0 0.0
(read/write) 133252 133252 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899420 899420 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005482 1005482 0 0.0
(read/write) 1479602 1479602 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210368 210368 0 0.0
.flash.text 1005482 1005482 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060687 1060687 0 0.0
(read/write) 481816 481816 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 240948 240948 0 0.0
.flash.text 1055303 1055303 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680932 680932 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 597048 597048 0 0.0
lock k32w061+release (read/write) 732420 732420 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648136 648136 0 0.0
linux all-clusters-app debug (read only) 2769745 2770369 624 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 243677 243677 0 0.0
.text 2352114 2352738 624 0.0
all-clusters-minimal-app debug (read only) 2646865 2647361 496 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 245597 245597 0 0.0
.text 2228706 2229202 496 0.0
bridge-app debug+rpc (read only) 2030057 2030057 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 168768 168768 0 0.0
.text 1704770 1704770 0 0.0
chip-tool debug (read only) 9669565 9671421 1856 0.0
(read/write) 600848 600848 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569472 569472 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496285 496285 0 0.0
.text 7784261 7786117 1856 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9413852 9415244 1392 0.0
(read/write) 667105 667105 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604872 604872 0 0.0
.dynamic 528 528 0 0.0
.got 14992 14992 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459972 459972 0 0.0
.text 7429556 7430948 1392 0.0
lighting-app debug+rpc (read only) 2319889 2320097 208 0.0
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 187720 187720 0 0.0
.text 1966418 1966626 208 0.0
lock-app debug (read only) 2258649 2258825 176 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 200904 200904 0 0.0
.text 1897426 1897602 176 0.0
ota-provider-app debug (read only) 2067729 2067729 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180184 180184 0 0.0
.text 1728450 1728450 0 0.0
ota-requestor-app debug (read only) 2096529 2096529 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176256 176256 0 0.0
.text 1759714 1759714 0 0.0
shell debug (read only) 2573833 2574361 528 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223794 223794 0 0.0
.text 2190594 2191122 528 0.0
thermostat-no-ble arm64 (read only) 2366708 2366916 208 0.0
(read/write) 177441 177441 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80192 80192 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148164 148164 0 0.0
.text 1988912 1989120 208 0.0
tv-app debug (read only) 2876433 2876433 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222112 222112 0 0.0
.text 2471714 2471714 0 0.0
tv-casting-app debug (read only) 5434009 5435273 1264 0.0
(read/write) 226160 226160 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138920 138920 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 339808 339808 0 0.0
.text 4734562 4735826 1264 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425016 2425016 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387660 1387660 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1186455 1186455 0 0.0
bss 139276 139276 0 0.0
rodata 153592 153592 0 0.0
text 814672 814672 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1135171 1135171 0 0.0
bss 138508 138508 0 0.0
rodata 130156 130156 0 0.0
text 787672 787672 0 0.0
p6 all-clusters-app default (read/write) 2540960 2540960 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499224 1499224 0 0.0
all-clusters-minimal-app default (read/write) 2486928 2486928 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445192 1445192 0 0.0
light-app default (read/write) 2420872 2420872 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379136 1379136 0 0.0
lock-app default (read/write) 2438912 2438912 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397176 1397176 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 779596 779596 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551404 551404 0 0.0
lighting-app tlsr9518adk80d (read/write) 799640 799640 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568146 568146 0 0.0

@jmeg-sfy jmeg-sfy mentioned this pull request Jun 1, 2022
Merged
bzbarsky-apple
bzbarsky-apple requested changes Jun 2, 2022
View reviewed changes
src/app/util/attribute-storage-null-handling.h Outdated Show resolved Hide resolved
src/lib/support/BitMask.h Outdated Show resolved Hide resolved
src/lib/support/BitMask.h Outdated Show resolved Hide resolved
src/lib/support/BitMask.h Outdated Show resolved Hide resolved
src/lib/support/BitMask.h Outdated Show resolved Hide resolved
@woody-apple
Copy link
Contributor

@bzbarsky-apple ?

@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

PR #19008: Size comparison from 43b14a6 to 5539eba

Increases (10 builds for cc13x2_26x2, linux)
platform target config section 43b14a6 5539eba change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162260 162372 112 0.1
pump-controller-app LP_CC2652R7 (read/write) 188916 189044 128 0.1
linux all-clusters-app debug (read only) 2766809 2767305 496 0.0
.text 2348258 2348754 496 0.0
all-clusters-minimal-app debug (read only) 2643961 2644329 368 0.0
.text 2224850 2225218 368 0.0
chip-tool debug (read only) 9591333 9592917 1584 0.0
.text 7716885 7718469 1584 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9345492 9346628 1136 0.0
.text 7372676 7373812 1136 0.0
lighting-app debug+rpc (read only) 2319985 2320049 64 0.0
.text 1965506 1965570 64 0.0
lock-app debug (read only) 2258633 2258665 32 0.0
.text 1896530 1896562 32 0.0
shell debug (read only) 2571793 2572177 384 0.0
.text 2187698 2188082 384 0.0
tv-casting-app debug (read only) 5326841 5327689 848 0.0
.text 4638194 4639042 848 0.0
Decreases (25 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 43b14a6 5539eba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648587 648459 -128 -0.0
.text 563824 563696 -128 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615451 615339 -112 -0.0
.text 541304 541192 -112 -0.0
lock-ftd LP_CC2652R7 (read only) 680651 680539 -112 -0.0
.text 583544 583432 -112 -0.0
lock-mtd LP_CC2652R7 (read only) 630051 629939 -112 -0.0
.text 533056 532944 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 655019 654891 -128 -0.0
.text 570700 570572 -128 -0.0
shell LP_CC2652R7 (read only) 641610 641482 -128 -0.0
.text 559852 559724 -128 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 601990 601878 -112 -0.0
.app_xip_area 461016 460904 -112 -0.0
lock cyw930739m2evb_01 (read/write) 598098 597986 -112 -0.0
.app_xip_area 456996 456884 -112 -0.0
efr32 lighting-app BRD4161A (read only) 915808 915760 -48 -0.0
.text 915800 915752 -48 -0.0
BRD4161A+rpc (read only) 950036 949988 -48 -0.0
.text 950028 949980 -48 -0.0
BRD4161A+rs911x (read only) 787876 787828 -48 -0.0
.text 787868 787820 -48 -0.0
lock-app BRD4161A+wf200 (read only) 955256 955128 -128 -0.0
.text 955248 955120 -128 -0.0
window-app BRD4161A (read only) 900728 900680 -48 -0.0
.text 900720 900672 -48 -0.0
k32w light k32w061+release (read/write) 657892 657764 -128 -0.0
.text 580304 580176 -128 -0.0
lock k32w061+release (read/write) 716864 716736 -128 -0.0
.text 638884 638756 -128 -0.0
linux thermostat-no-ble arm64 (read only) 2366956 2366876 -80 -0.0
.text 1988352 1988272 -80 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2425568 2425440 -128 -0.0
.text 1388212 1388084 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187799 1187687 -112 -0.0
text 814804 814692 -112 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136563 1136451 -112 -0.0
text 787848 787736 -112 -0.0
p6 all-clusters-app default (read/write) 2541744 2541696 -48 -0.0
.text 1500008 1499960 -48 -0.0
all-clusters-minimal-app default (read/write) 2487696 2487664 -32 -0.0
.text 1445960 1445928 -32 -0.0
light-app default (read/write) 2422112 2422064 -48 -0.0
.text 1380376 1380328 -48 -0.0
lock-app default (read/write) 2440168 2440120 -48 -0.0
.text 1398432 1398384 -48 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780856 780672 -184 -0.0
text 552296 552106 -190 -0.0
lighting-app tlsr9518adk80d (read/write) 800900 800708 -192 -0.0
text 569038 568848 -190 -0.0
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 43b14a6 5539eba change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648587 648459 -128 -0.0
(read/write) 158988 158988 0 0.0
.bss 74668 74668 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563824 563696 -128 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615451 615339 -112 -0.0
(read/write) 158160 158160 0 0.0
.bss 73900 73900 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541304 541192 -112 -0.0
lock-ftd LP_CC2652R7 (read only) 680651 680539 -112 -0.0
(read/write) 162260 162372 112 0.1
.bss 72692 72692 0 0.0
.data 3268 3268 0 0.0
.rodata 96627 96627 0 0.0
.text 583544 583432 -112 -0.0
lock-mtd LP_CC2652R7 (read only) 630051 629939 -112 -0.0
(read/write) 145812 145812 0 0.0
.bss 68428 68428 0 0.0
.data 3268 3268 0 0.0
.rodata 96507 96507 0 0.0
.text 533056 532944 -112 -0.0
pump-app LP_CC2652R7 (read only) 663563 663563 0 0.0
(read/write) 180260 180260 0 0.0
.bss 72836 72836 0 0.0
.data 3300 3300 0 0.0
.rodata 85643 85643 0 0.0
.text 577436 577436 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655019 654891 -128 -0.0
(read/write) 188916 189044 128 0.1
.bss 72948 72948 0 0.0
.data 3264 3264 0 0.0
.rodata 83835 83835 0 0.0
.text 570700 570572 -128 -0.0
shell LP_CC2652R7 (read only) 641610 641482 -128 -0.0
(read/write) 154544 154544 0 0.0
.bss 77020 77020 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559852 559724 -128 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 601990 601878 -112 -0.0
.app_xip_area 461016 460904 -112 -0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598098 597986 -112 -0.0
.app_xip_area 456996 456884 -112 -0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596634 596634 0 0.0
.app_xip_area 456656 456656 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915808 915760 -48 -0.0
(read/write) 133280 133280 0 0.0
.bss 131176 131176 0 0.0
.data 2100 2100 0 0.0
.text 915800 915752 -48 -0.0
BRD4161A+rpc (read only) 950036 949988 -48 -0.0
(read/write) 149968 149968 0 0.0
.bss 147664 147664 0 0.0
.data 2304 2304 0 0.0
.text 950028 949980 -48 -0.0
BRD4161A+rs911x (read only) 787876 787828 -48 -0.0
(read/write) 129496 129496 0 0.0
.bss 127396 127396 0 0.0
.data 2100 2100 0 0.0
.text 787868 787820 -48 -0.0
lock-app BRD4161A+wf200 (read only) 955256 955128 -128 -0.0
(read/write) 128332 128332 0 0.0
.bss 126260 126260 0 0.0
.data 2072 2072 0 0.0
.text 955248 955120 -128 -0.0
window-app BRD4161A (read only) 900728 900680 -48 -0.0
(read/write) 133344 133344 0 0.0
.bss 131248 131248 0 0.0
.data 2096 2096 0 0.0
.text 900720 900672 -48 -0.0
k32w light k32w061+release (read/write) 657892 657764 -128 -0.0
.bss 69768 69768 0 0.0
.data 2020 2020 0 0.0
.text 580304 580176 -128 -0.0
lock k32w061+release (read/write) 716864 716736 -128 -0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 638884 638756 -128 -0.0
linux all-clusters-app debug (read only) 2766809 2767305 496 0.0
(read/write) 178344 178344 0 0.0
.bss 86304 86304 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 244573 244573 0 0.0
.text 2348258 2348754 496 0.0
all-clusters-minimal-app debug (read only) 2643961 2644329 368 0.0
(read/write) 170376 170376 0 0.0
.bss 85568 85568 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 246525 246525 0 0.0
.text 2224850 2225218 368 0.0
bridge-app debug+rpc (read only) 2029705 2029705 0 0.0
(read/write) 148000 148000 0 0.0
.bss 72960 72960 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 169760 169760 0 0.0
.text 1703378 1703378 0 0.0
chip-tool debug (read only) 9591333 9592917 1584 0.0
(read/write) 597048 597048 0 0.0
.bss 24032 24032 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 565600 565600 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 494909 494909 0 0.0
.text 7716885 7718469 1584 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9345492 9346628 1136 0.0
(read/write) 662961 662961 0 0.0
.bss 42305 42305 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 600832 600832 0 0.0
.dynamic 528 528 0 0.0
.got 14824 14824 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 458652 458652 0 0.0
.text 7372676 7373812 1136 0.0
lighting-app debug+rpc (read only) 2319985 2320049 64 0.0
(read/write) 153640 153640 0 0.0
.bss 74816 74816 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 188680 188680 0 0.0
.text 1965506 1965570 64 0.0
lock-app debug (read only) 2258633 2258665 32 0.0
(read/write) 148736 148736 0 0.0
.bss 73504 73504 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 201736 201736 0 0.0
.text 1896530 1896562 32 0.0
ota-provider-app debug (read only) 2066505 2066505 0 0.0
(read/write) 141656 141656 0 0.0
.bss 73088 73088 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 181144 181144 0 0.0
.text 1726242 1726242 0 0.0
ota-requestor-app debug (read only) 2093529 2093529 0 0.0
(read/write) 144496 144496 0 0.0
.bss 73792 73792 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 177088 177088 0 0.0
.text 1755858 1755858 0 0.0
shell debug (read only) 2571793 2572177 384 0.0
(read/write) 201752 201752 0 0.0
.bss 117160 117160 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 224626 224626 0 0.0
.text 2187698 2188082 384 0.0
thermostat-no-ble arm64 (read only) 2366956 2366876 -80 -0.0
(read/write) 177601 177601 0 0.0
.bss 87969 87969 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80288 80288 0 0.0
.dynamic 528 528 0 0.0
.got 4800 4800 0 0.0
.init 24 24 0 0.0
.init_array 384 384 0 0.0
.rodata 148828 148828 0 0.0
.text 1988352 1988272 -80 -0.0
tv-app debug (read only) 2876801 2876801 0 0.0
(read/write) 280280 280280 0 0.0
.bss 191112 191112 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 223040 223040 0 0.0
.text 2471106 2471106 0 0.0
tv-casting-app debug (read only) 5326841 5327689 848 0.0
(read/write) 222744 222744 0 0.0
.bss 78696 78696 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 337408 337408 0 0.0
.text 4638194 4639042 848 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425568 2425440 -128 -0.0
.bss 202652 202652 0 0.0
.data 5880 5880 0 0.0
.text 1388212 1388084 -128 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187799 1187687 -112 -0.0
bss 141297 141297 0 0.0
rodata 152832 152832 0 0.0
text 814804 814692 -112 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136563 1136451 -112 -0.0
bss 140526 140526 0 0.0
rodata 129396 129396 0 0.0
text 787848 787736 -112 -0.0
p6 all-clusters-app default (read/write) 2541744 2541696 -48 -0.0
.bss 137192 137192 0 0.0
.data 2808 2808 0 0.0
.text 1500008 1499960 -48 -0.0
all-clusters-minimal-app default (read/write) 2487696 2487664 -32 -0.0
.bss 136416 136416 0 0.0
.data 2752 2752 0 0.0
.text 1445960 1445928 -32 -0.0
light-app default (read/write) 2422112 2422064 -48 -0.0
.bss 129520 129520 0 0.0
.data 2608 2608 0 0.0
.text 1380376 1380328 -48 -0.0
lock-app default (read/write) 2440168 2440120 -48 -0.0
.bss 129336 129336 0 0.0
.data 2576 2576 0 0.0
.text 1398432 1398384 -48 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780856 780672 -184 -0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 552296 552106 -190 -0.0
lighting-app tlsr9518adk80d (read/write) 800900 800708 -192 -0.0
bss 70844 70844 0 0.0
noinit 40416 40416 0 0.0
text 569038 568848 -190 -0.0

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19008: Size comparison from a00e966 to a161db6

Increases (9 builds for linux)
platform target config section a00e966 a161db6 change % change
linux all-clusters-app debug (read only) 2767985 2768609 624 0.0
.text 2349234 2349858 624 0.0
all-clusters-minimal-app debug (read only) 2645105 2645601 496 0.0
.text 2225826 2226322 496 0.0
chip-tool debug (read only) 9595117 9596701 1584 0.0
.text 7720309 7721893 1584 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9348532 9349668 1136 0.0
.text 7375412 7376548 1136 0.0
lighting-app debug+rpc (read only) 2320777 2320969 192 0.0
.text 1966258 1966450 192 0.0
lock-app debug (read only) 2259441 2259601 160 0.0
.text 1897266 1897426 160 0.0
shell debug (read only) 2572969 2573481 512 0.0
.text 2188674 2189186 512 0.0
thermostat-no-ble arm64 (read only) 2367420 2367612 192 0.0
.text 1988896 1989088 192 0.0
tv-casting-app debug (read only) 5327681 5328673 992 0.0
.text 4638962 4639954 992 0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a00e966 a161db6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648675 648675 0 0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563908 563908 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615555 615555 0 0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541404 541404 0 0.0
lock-ftd LP_CC2652R7 (read only) 680751 680751 0 0.0
(read/write) 162072 162072 0 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96687 96687 0 0.0
.text 583580 583580 0 0.0
lock-mtd LP_CC2652R7 (read only) 630151 630151 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96567 96567 0 0.0
.text 533092 533092 0 0.0
pump-app LP_CC2652R7 (read only) 664039 664039 0 0.0
(read/write) 179696 179696 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577712 577712 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655095 655095 0 0.0
(read/write) 188752 188752 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570720 570720 0 0.0
shell LP_CC2652R7 (read only) 641682 641682 0 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559928 559928 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602078 602078 0 0.0
.app_xip_area 461104 461104 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 598178 598178 0 0.0
.app_xip_area 457076 457076 0 0.0
.bss 84072 84072 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596842 596842 0 0.0
.app_xip_area 456864 456864 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915984 915984 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 915976 915976 0 0.0
BRD4161A+rpc (read only) 950196 950196 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950188 950188 0 0.0
BRD4161A+rs911x (read only) 788052 788052 0 0.0
(read/write) 129404 129404 0 0.0
.bss 127308 127308 0 0.0
.data 2096 2096 0 0.0
.text 788044 788044 0 0.0
lock-app BRD4161A+wf200 (read only) 955364 955364 0 0.0
(read/write) 128240 128240 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 955356 955356 0 0.0
window-app BRD4161A (read only) 900904 900904 0 0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 900896 900896 0 0.0
esp32 all-clusters-app c3devkit (read only) 1005568 1005568 0 0.0
(read/write) 1480234 1480234 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 211000 211000 0 0.0
.flash.text 1005568 1005568 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060719 1060719 0 0.0
(read/write) 482432 482432 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241564 241564 0 0.0
.flash.text 1055335 1055335 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657944 657944 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580368 580368 0 0.0
lock k32w061+release (read/write) 716960 716960 0 0.0
.bss 70184 70184 0 0.0
.data 1984 1984 0 0.0
.text 638992 638992 0 0.0
linux all-clusters-app debug (read only) 2767985 2768609 624 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244797 244797 0 0.0
.text 2349234 2349858 624 0.0
all-clusters-minimal-app debug (read only) 2645105 2645601 496 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246717 246717 0 0.0
.text 2225826 2226322 496 0.0
bridge-app debug+rpc (read only) 2030641 2030641 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704274 1704274 0 0.0
chip-tool debug (read only) 9595117 9596701 1584 0.0
(read/write) 596976 596976 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 565600 565600 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 495293 495293 0 0.0
.text 7720309 7721893 1584 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9348532 9349668 1136 0.0
(read/write) 662865 662865 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 600808 600808 0 0.0
.dynamic 528 528 0 0.0
.got 14816 14816 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 459020 459020 0 0.0
.text 7375412 7376548 1136 0.0
lighting-app debug+rpc (read only) 2320777 2320969 192 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966258 1966450 192 0.0
lock-app debug (read only) 2259441 2259601 160 0.0
(read/write) 148664 148664 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67944 67944 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201832 201832 0 0.0
.text 1897266 1897426 160 0.0
ota-provider-app debug (read only) 2066625 2066625 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726290 1726290 0 0.0
ota-requestor-app debug (read only) 2094449 2094449 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756738 1756738 0 0.0
shell debug (read only) 2572969 2573481 512 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224850 224850 0 0.0
.text 2188674 2189186 512 0.0
thermostat-no-ble arm64 (read only) 2367420 2367612 192 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1988896 1989088 192 0.0
tv-app debug (read only) 2877721 2877721 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2471986 2471986 0 0.0
tv-casting-app debug (read only) 5327681 5328673 992 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337504 337504 0 0.0
.text 4638962 4639954 992 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2425752 2425752 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1388396 1388396 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188179 1188179 0 0.0
bss 141277 141277 0 0.0
rodata 153036 153036 0 0.0
text 814984 814984 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136943 1136943 0 0.0
bss 140506 140506 0 0.0
rodata 129600 129600 0 0.0
text 788024 788024 0 0.0
p6 all-clusters-app default (read/write) 2542192 2542192 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1500456 1500456 0 0.0
all-clusters-minimal-app default (read/write) 2488160 2488160 0 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1446424 1446424 0 0.0
light-app default (read/write) 2422304 2422304 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380568 1380568 0 0.0
lock-app default (read/write) 2440344 2440344 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1398608 1398608 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780852 780852 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552246 552246 0 0.0
lighting-app tlsr9518adk80d (read/write) 800888 800888 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568988 568988 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19008: Size comparison from a81171b to 02b9992

Increases (9 builds for linux)
platform target config section a81171b 02b9992 change % change
linux all-clusters-app debug (read only) 2772881 2773505 624 0.0
.text 2352898 2353522 624 0.0
all-clusters-minimal-app debug (read only) 2653041 2653537 496 0.0
.text 2232498 2232994 496 0.0
chip-tool debug (read only) 9667293 9671453 4160 0.0
.text 7757669 7761829 4160 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9419516 9422812 3296 0.0
.text 7411060 7414356 3296 0.0
lighting-app debug+rpc (read only) 2321129 2321321 192 0.0
.text 1966610 1966802 192 0.0
lock-app debug (read only) 2264529 2264689 160 0.0
.text 1901122 1901282 160 0.0
shell debug (read only) 2577833 2578345 512 0.0
.text 2192306 2192818 512 0.0
thermostat-no-ble arm64 (read only) 2367596 2367804 208 0.0
.text 1989072 1989280 208 0.0
tv-casting-app debug (read only) 5328145 5329121 976 0.0
.text 4639394 4640370 976 0.0
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a81171b 02b9992 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 650819 650819 0 0.0
(read/write) 158916 158916 0 0.0
.bss 74596 74596 0 0.0
.data 3404 3404 0 0.0
.rodata 85483 85483 0 0.0
.text 565104 565104 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617587 617587 0 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74955 74955 0 0.0
.text 542400 542400 0 0.0
lock-ftd LP_CC2652R7 (read only) 682959 682959 0 0.0
(read/write) 159872 159872 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97671 97671 0 0.0
.text 584808 584808 0 0.0
lock-mtd LP_CC2652R7 (read only) 632359 632359 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97551 97551 0 0.0
.text 534320 534320 0 0.0
pump-app LP_CC2652R7 (read only) 664063 664063 0 0.0
(read/write) 179672 179672 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577736 577736 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655135 655135 0 0.0
(read/write) 188712 188712 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570760 570760 0 0.0
shell LP_CC2652R7 (read only) 643850 643850 0 0.0
(read/write) 154472 154472 0 0.0
.bss 76948 76948 0 0.0
.data 3408 3408 0 0.0
.rodata 82474 82474 0 0.0
.text 561140 561140 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602102 602102 0 0.0
.app_xip_area 461128 461128 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599210 599210 0 0.0
.app_xip_area 458100 458100 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596874 596874 0 0.0
.app_xip_area 456896 456896 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916016 916016 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916008 916008 0 0.0
BRD4161A+rpc (read only) 950228 950228 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950220 950220 0 0.0
BRD4161A+rs911x (read only) 791212 791212 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791204 791204 0 0.0
lock-app BRD4161A+wf200 (read only) 958076 958076 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958068 958068 0 0.0
window-app BRD4161A (read only) 901064 901064 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901056 901056 0 0.0
k32w light k32w061+release (read/write) 657976 657976 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580400 580400 0 0.0
lock k32w061+release (read/write) 719204 719204 0 0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 641224 641224 0 0.0
linux all-clusters-app debug (read only) 2772881 2773505 624 0.0
(read/write) 178504 178504 0 0.0
.bss 86304 86304 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 245885 245885 0 0.0
.text 2352898 2353522 624 0.0
all-clusters-minimal-app debug (read only) 2653041 2653537 496 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2232498 2232994 496 0.0
bridge-app debug+rpc (read only) 2031089 2031089 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704722 1704722 0 0.0
chip-tool debug (read only) 9667293 9671453 4160 0.0
(read/write) 611152 611152 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 579760 579760 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496989 496989 0 0.0
.text 7757669 7761829 4160 0.1
chip-tool-no-interactive-ipv6only arm64 (read only) 9419516 9422812 3296 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460844 460844 0 0.0
.text 7411060 7414356 3296 0.0
lighting-app debug+rpc (read only) 2321129 2321321 192 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966610 1966802 192 0.0
lock-app debug (read only) 2264529 2264689 160 0.0
(read/write) 148768 148768 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 68008 68008 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1901122 1901282 160 0.0
ota-provider-app debug (read only) 2066833 2066833 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726498 1726498 0 0.0
ota-requestor-app debug (read only) 2094641 2094641 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756930 1756930 0 0.0
shell debug (read only) 2577833 2578345 512 0.0
(read/write) 201912 201912 0 0.0
.bss 117160 117160 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77624 77624 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 225938 225938 0 0.0
.text 2192306 2192818 512 0.0
thermostat-no-ble arm64 (read only) 2367596 2367804 208 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1989072 1989280 208 0.0
tv-app debug (read only) 2878281 2878281 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2472546 2472546 0 0.0
tv-casting-app debug (read only) 5328145 5329121 976 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337536 337536 0 0.0
.text 4639394 4640370 976 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427136 2427136 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389780 1389780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190463 1190463 0 0.0
bss 141293 141293 0 0.0
rodata 154088 154088 0 0.0
text 816204 816204 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139111 1139111 0 0.0
bss 140514 140514 0 0.0
rodata 130744 130744 0 0.0
text 789044 789044 0 0.0
p6 all-clusters-app default (read/write) 2544608 2544608 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502872 1502872 0 0.0
all-clusters-minimal-app default (read/write) 2490472 2490472 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448736 1448736 0 0.0
light-app default (read/write) 2422352 2422352 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380616 1380616 0 0.0
lock-app default (read/write) 2442712 2442712 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400976 1400976 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780900 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552296 552296 0 0.0
lighting-app tlsr9518adk80d (read/write) 800944 800944 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569038 569038 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 3, 2022 •
edited
Loading

PR #19008: Size comparison from a81171b to 6f202ed

Increases (9 builds for linux)
platform target config section a81171b 6f202ed change % change
linux all-clusters-app debug (read only) 2772881 2773505 624 0.0
.text 2352898 2353522 624 0.0
all-clusters-minimal-app debug (read only) 2653041 2653537 496 0.0
.text 2232498 2232994 496 0.0
chip-tool debug (read only) 9667293 9668893 1600 0.0
.text 7757669 7759269 1600 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9419516 9420652 1136 0.0
.text 7411060 7412196 1136 0.0
lighting-app debug+rpc (read only) 2321129 2321321 192 0.0
.text 1966610 1966802 192 0.0
lock-app debug (read only) 2264529 2264689 160 0.0
.text 1901122 1901282 160 0.0
shell debug (read only) 2577833 2578345 512 0.0
.text 2192306 2192818 512 0.0
thermostat-no-ble arm64 (read only) 2367596 2367804 208 0.0
.text 1989072 1989280 208 0.0
tv-casting-app debug (read only) 5328145 5329121 976 0.0
.text 4639394 4640370 976 0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a81171b 6f202ed change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 650819 650819 0 0.0
(read/write) 158916 158916 0 0.0
.bss 74596 74596 0 0.0
.data 3404 3404 0 0.0
.rodata 85483 85483 0 0.0
.text 565104 565104 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617587 617587 0 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74955 74955 0 0.0
.text 542400 542400 0 0.0
lock-ftd LP_CC2652R7 (read only) 682959 682959 0 0.0
(read/write) 159872 159872 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97671 97671 0 0.0
.text 584808 584808 0 0.0
lock-mtd LP_CC2652R7 (read only) 632359 632359 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97551 97551 0 0.0
.text 534320 534320 0 0.0
pump-app LP_CC2652R7 (read only) 664063 664063 0 0.0
(read/write) 179672 179672 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577736 577736 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655135 655135 0 0.0
(read/write) 188712 188712 0 0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570760 570760 0 0.0
shell LP_CC2652R7 (read only) 643850 643850 0 0.0
(read/write) 154472 154472 0 0.0
.bss 76948 76948 0 0.0
.data 3408 3408 0 0.0
.rodata 82474 82474 0 0.0
.text 561140 561140 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602102 602102 0 0.0
.app_xip_area 461128 461128 0 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599210 599210 0 0.0
.app_xip_area 458100 458100 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596874 596874 0 0.0
.app_xip_area 456896 456896 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916016 916016 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916008 916008 0 0.0
BRD4161A+rpc (read only) 950228 950228 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950220 950220 0 0.0
BRD4161A+rs911x (read only) 791212 791212 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791204 791204 0 0.0
lock-app BRD4161A+wf200 (read only) 958076 958076 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958068 958068 0 0.0
window-app BRD4161A (read only) 901064 901064 0 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901056 901056 0 0.0
esp32 all-clusters-app c3devkit (read only) 1006840 1006840 0 0.0
(read/write) 1481330 1481330 0 0.0
.dram0.bss 69160 69160 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212080 212080 0 0.0
.flash.text 1006840 1006840 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1061847 1061847 0 0.0
(read/write) 483508 483508 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242624 242624 0 0.0
.flash.text 1056463 1056463 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657976 657976 0 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580400 580400 0 0.0
lock k32w061+release (read/write) 719204 719204 0 0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 641224 641224 0 0.0
linux all-clusters-app debug (read only) 2772881 2773505 624 0.0
(read/write) 178504 178504 0 0.0
.bss 86304 86304 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 245885 245885 0 0.0
.text 2352898 2353522 624 0.0
all-clusters-minimal-app debug (read only) 2653041 2653537 496 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2232498 2232994 496 0.0
bridge-app debug+rpc (read only) 2031089 2031089 0 0.0
(read/write) 147928 147928 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65528 65528 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1704722 1704722 0 0.0
chip-tool debug (read only) 9667293 9668893 1600 0.0
(read/write) 611152 611152 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 579760 579760 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 496989 496989 0 0.0
.text 7757669 7759269 1600 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9419516 9420652 1136 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460844 460844 0 0.0
.text 7411060 7412196 1136 0.0
lighting-app debug+rpc (read only) 2321129 2321321 192 0.0
(read/write) 153568 153568 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71016 71016 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1966610 1966802 192 0.0
lock-app debug (read only) 2264529 2264689 160 0.0
(read/write) 148768 148768 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 68008 68008 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1901122 1901282 160 0.0
ota-provider-app debug (read only) 2066833 2066833 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726498 1726498 0 0.0
ota-requestor-app debug (read only) 2094641 2094641 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1756930 1756930 0 0.0
shell debug (read only) 2577833 2578345 512 0.0
(read/write) 201912 201912 0 0.0
.bss 117160 117160 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77624 77624 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 225938 225938 0 0.0
.text 2192306 2192818 512 0.0
thermostat-no-ble arm64 (read only) 2367596 2367804 208 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148828 148828 0 0.0
.text 1989072 1989280 208 0.0
tv-app debug (read only) 2878281 2878281 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223104 223104 0 0.0
.text 2472546 2472546 0 0.0
tv-casting-app debug (read only) 5328145 5329121 976 0.0
(read/write) 222672 222672 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135432 135432 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337536 337536 0 0.0
.text 4639394 4640370 976 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427136 2427136 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389780 1389780 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190463 1190463 0 0.0
bss 141293 141293 0 0.0
rodata 154088 154088 0 0.0
text 816204 816204 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139111 1139111 0 0.0
bss 140514 140514 0 0.0
rodata 130744 130744 0 0.0
text 789044 789044 0 0.0
p6 all-clusters-app default (read/write) 2544608 2544608 0 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502872 1502872 0 0.0
all-clusters-minimal-app default (read/write) 2490472 2490472 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448736 1448736 0 0.0
light-app default (read/write) 2422352 2422352 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380616 1380616 0 0.0
lock-app default (read/write) 2442712 2442712 0 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400976 1400976 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780900 780900 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552296 552296 0 0.0
lighting-app tlsr9518adk80d (read/write) 800944 800944 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569038 569038 0 0.0

@andy31415 andy31415 merged commit cb5b1b3 into project-chip:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andy31415 @woody-apple @mrjerryjohns @bzbarsky-apple @jmeg-sfy