[Pump] Update pump cluster server

[ReneJosefsen]

Problem

What is being fixed?

• Current implementation used optional attributes without checking if they were available

Change overview

Added checks for the pumpStatus and controlMode attribute.
If controlMode is not available use the default value of the effectiveControlMode as fallback

Testing

How was this tested?

• Manually tested on CC2652 launchpad

[github-actions]

PR #19105: Size comparison from ee638e1 to 96eaa0d

Increases above 0.2%:

platform	target	config	section	ee638e1	96eaa0d	change	% change
p6	all-clusters-minimal-app	default	.data	2744	2752	8	0.3

Increases (8 builds for cc13x2_26x2, nrfconnect, p6)

platform	target	config	section	ee638e1	96eaa0d	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	648691	648771	80	0.0
			(read/write)	158900	158904	4	0.0
			.data	3404	3408	4	0.1
			.text	563924	564004	80	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	615523	615619	96	0.0
			(read/write)	158072	158076	4	0.0
			.data	3344	3348	4	0.1
			.text	541372	541468	96	0.0
	pump-app	LP_CC2652R7	(read only)	663627	663883	256	0.0
			.data	3300	3304	4	0.1
			.rodata	85643	85787	144	0.2
			.text	577504	577616	112	0.0
	shell	LP_CC2652R7	(read only)	641706	641786	80	0.0
			(read/write)	154456	154460	4	0.0
			.data	3408	3412	4	0.1
			.text	559952	560032	80	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1188179	1188435	256	0.0
			rodata	152780	152924	144	0.1
			text	815236	815344	108	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1136911	1137175	264	0.0
			rodata	129344	129488	144	0.1
			text	788248	788352	104	0.0
p6	all-clusters-app	default	(read/write)	2541760	2542064	304	0.0
			.text	1500024	1500328	304	0.0
	all-clusters-minimal-app	default	(read/write)	2487696	2488016	320	0.0
			.data	2744	2752	8	0.3
			.text	1445960	1446280	320	0.0

Decreases (1 build for cc13x2_26x2)

platform	target	config	section	ee638e1	96eaa0d	change	% change
cc13x2_26x2	pump-app	LP_CC2652R7	(read/write)	180108	179852	-256	-0.1

Full report (28 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	ee638e1	96eaa0d	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	648691	648771	80	0.0
			(read/write)	158900	158904	4	0.0
			.bss	74580	74580	0	0.0
			.data	3404	3408	4	0.1
			.rodata	84531	84531	0	0.0
			.text	563924	564004	80	0.0
	all-clusters-minimal-app	LP_CC2652R7	(read only)	615523	615619	96	0.0
			(read/write)	158072	158076	4	0.0
			.bss	73812	73812	0	0.0
			.data	3344	3348	4	0.1
			.rodata	73915	73915	0	0.0
			.text	541372	541468	96	0.0
	lock-ftd	LP_CC2652R7	(read only)	680755	680755	0	0.0
			(read/write)	162068	162068	0	0.0
			.bss	72604	72604	0	0.0
			.data	3268	3268	0	0.0
			.rodata	96627	96627	0	0.0
			.text	583644	583644	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	630155	630155	0	0.0
			(read/write)	145724	145724	0	0.0
			.bss	68340	68340	0	0.0
			.data	3268	3268	0	0.0
			.rodata	96507	96507	0	0.0
			.text	533156	533156	0	0.0
	pump-app	LP_CC2652R7	(read only)	663627	663883	256	0.0
			(read/write)	180108	179852	-256	-0.1
			.bss	72748	72748	0	0.0
			.data	3300	3304	4	0.1
			.rodata	85643	85787	144	0.2
			.text	577504	577616	112	0.0
	pump-controller-app	LP_CC2652R7	(read only)	655083	655083	0	0.0
			(read/write)	188764	188764	0	0.0
			.bss	72860	72860	0	0.0
			.data	3264	3264	0	0.0
			.rodata	83835	83835	0	0.0
			.text	570768	570768	0	0.0
	shell	LP_CC2652R7	(read only)	641706	641786	80	0.0
			(read/write)	154456	154460	4	0.0
			.bss	76932	76932	0	0.0
			.data	3408	3412	4	0.1
			.rodata	81522	81522	0	0.0
			.text	559952	560032	80	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	602150	602150	0	0.0
			.app_xip_area	461176	461176	0	0.0
			.bss	83912	83912	0	0.0
			.data	744	744	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	598290	598290	0	0.0
			.app_xip_area	457188	457188	0	0.0
			.bss	84072	84072	0	0.0
			.data	712	712	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	596786	596786	0	0.0
			.app_xip_area	456808	456808	0	0.0
			.bss	83044	83044	0	0.0
			.data	620	620	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	915712	915712	0	0.0
			(read/write)	133184	133184	0	0.0
			.bss	131088	131088	0	0.0
			.data	2096	2096	0	0.0
			.text	915704	915704	0	0.0
		BRD4161A+rpc	(read only)	949924	949924	0	0.0
			(read/write)	149876	149876	0	0.0
			.bss	147576	147576	0	0.0
			.data	2300	2300	0	0.0
			.text	949916	949916	0	0.0
		BRD4161A+rs911x	(read only)	787860	787860	0	0.0
			(read/write)	129404	129404	0	0.0
			.bss	127308	127308	0	0.0
			.data	2096	2096	0	0.0
			.text	787852	787852	0	0.0
	lock-app	BRD4161A+wf200	(read only)	955400	955400	0	0.0
			(read/write)	128244	128244	0	0.0
			.bss	126172	126172	0	0.0
			.data	2068	2068	0	0.0
			.text	955392	955392	0	0.0
	window-app	BRD4161A	(read only)	900648	900648	0	0.0
			(read/write)	133256	133256	0	0.0
			.bss	131160	131160	0	0.0
			.data	2092	2092	0	0.0
			.text	900640	900640	0	0.0
k32w	light	k32w061+release	(read/write)	681412	681412	0	0.0
			.bss	80168	80168	0	0.0
			.data	2012	2012	0	0.0
			.text	597528	597528	0	0.0
	lock	k32w061+release	(read/write)	733444	733444	0	0.0
			.bss	80600	80600	0	0.0
			.data	1980	1980	0	0.0
			.text	649160	649160	0	0.0
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	9422628	9422628	0	0.0
			(read/write)	666897	666897	0	0.0
			.bss	42257	42257	0	0.0
			.data	1176	1176	0	0.0
			.data.rel.ro	604672	604672	0	0.0
			.dynamic	528	528	0	0.0
			.got	14984	14984	0	0.0
			.init	24	24	0	0.0
			.init_array	184	184	0	0.0
			.rodata	461372	461372	0	0.0
			.text	7437412	7437412	0	0.0
	thermostat-no-ble	arm64	(read only)	2367164	2367164	0	0.0
			(read/write)	177505	177505	0	0.0
			.bss	87921	87921	0	0.0
			.data	1528	1528	0	0.0
			.data.rel.ro	80264	80264	0	0.0
			.dynamic	528	528	0	0.0
			.got	4792	4792	0	0.0
			.init	24	24	0	0.0
			.init_array	376	376	0	0.0
			.rodata	148796	148796	0	0.0
			.text	1988672	1988672	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2425752	2425752	0	0.0
			.bss	202620	202620	0	0.0
			.data	5872	5872	0	0.0
			.text	1388396	1388396	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1188179	1188435	256	0.0
			bss	141277	141277	0	0.0
			rodata	152780	152924	144	0.1
			text	815236	815344	108	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1136911	1137175	264	0.0
			bss	140506	140506	0	0.0
			rodata	129344	129488	144	0.1
			text	788248	788352	104	0.0
p6	all-clusters-app	default	(read/write)	2541760	2542064	304	0.0
			.bss	137104	137104	0	0.0
			.data	2808	2808	0	0.0
			.text	1500024	1500328	304	0.0
	all-clusters-minimal-app	default	(read/write)	2487696	2488016	320	0.0
			.bss	136328	136328	0	0.0
			.data	2744	2752	8	0.3
			.text	1445960	1446280	320	0.0
	light-app	default	(read/write)	2422144	2422144	0	0.0
			.bss	129432	129432	0	0.0
			.data	2600	2600	0	0.0
			.text	1380408	1380408	0	0.0
	lock-app	default	(read/write)	2440184	2440184	0	0.0
			.bss	129248	129248	0	0.0
			.data	2568	2568	0	0.0
			.text	1398448	1398448	0	0.0
telink	light-switch-app	tlsr9518adk80d	(read/write)	780900	780900	0	0.0
			bss	70564	70564	0	0.0
			noinit	40416	40416	0	0.0
			text	552238	552238	0	0.0
	lighting-app	tlsr9518adk80d	(read/write)	800936	800936	0	0.0
			bss	70824	70824	0	0.0
			noinit	40416	40416	0	0.0
			text	568980	568980	0	0.0