-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 - Retrieve discriminator and setupPINCode from the Configuratio… #1918
Merged
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ESP32_RetrieveDiscriminatorSetupPinCodeConfigurationManager
Jul 30, 2020
Merged
ESP32 - Retrieve discriminator and setupPINCode from the Configuratio… #1918
woody-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ESP32_RetrieveDiscriminatorSetupPinCodeConfigurationManager
Jul 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
July 30, 2020 11:49
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
andy31415
approved these changes
Jul 30, 2020
saurabhst
approved these changes
Jul 30, 2020
woody-apple
approved these changes
Jul 30, 2020
chirag-silabs
pushed a commit
to rosahay-silabs/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…component Merge in WMN_TOOLS/matter from bugfix/icd_copy_contents to silabs_slc_1.3 Squashed commit of the following: commit 02fd193aff2e9bbd46719beebd2eb361552d97a4 Author: Curtis Rahman <curtis.rahman@silabs.com> Date: Wed May 29 12:53:48 2024 -0400 Resolved copy contents issue for ICD component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nManager
Problem
Currently the discriminator and the setupPINCode are hardcoded.
Summary of Changes
At the moment the discriminator and the setupPINCode are values pulled from the Kconfig file. It can be customised via menuconfig.