Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the ThreadMetrics struct with the spec. #19208

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Align the ThreadMetrics struct with the spec. #19208

merged 1 commit into from
Jun 6, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

The optional fields should be optional instead of forcing consumers to
provide garbage values.

Problem

Struct definition does not match spec.

Change overview

Make them match.

Testing

Looked at the generated code.

@bzbarsky-apple
Align the ThreadMetrics struct with the spec.
fe292ee 
The optional fields should be optional instead of forcing consumers to
provide garbage values.
@github-actions
Copy link

github-actions bot commented Jun 4, 2022 •
edited
Loading

PR #19208: Size comparison from 6544002 to fe292ee

Increases (13 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, p6, telink)
platform target config section 6544002 fe292ee change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 655151 655175 24 0.0
.text 570776 570800 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602110 602134 24 0.0
.app_xip_area 461136 461160 24 0.0
efr32 lighting-app BRD4161A (read only) 916016 916032 16 0.0
.text 916008 916024 16 0.0
BRD4161A+rpc (read only) 950244 950260 16 0.0
.text 950236 950252 16 0.0
BRD4161A+rs911x (read only) 791228 791244 16 0.0
.text 791220 791236 16 0.0
window-app BRD4161A (read only) 901056 901088 32 0.0
.text 901048 901080 32 0.0
esp32 all-clusters-app c3devkit (read only) 1007688 1007694 6 0.0
.flash.text 1007688 1007694 6 0.0
k32w light k32w061+release (read/write) 657992 658008 16 0.0
.text 580416 580432 16 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9421636 9422036 400 0.0
.text 7413124 7413524 400 0.0
thermostat-no-ble arm64 (read only) 2367844 2368068 224 0.0
.text 1989344 1989568 224 0.0
p6 light-app default (read/write) 2422368 2422384 16 0.0
.text 1380632 1380648 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780916 780924 8 0.0
text 552312 552318 6 0.0
lighting-app tlsr9518adk80d text 569054 569060 6 0.0
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, p6)
platform target config section 6544002 fe292ee change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 188696 188672 -24 -0.0
shell LP_CC2652R7 (read only) 644602 644594 -8 -0.0
.text 561860 561852 -8 -0.0
esp32 all-clusters-app m5stack (read only) 1062651 1062643 -8 -0.0
.flash.text 1057267 1057259 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 817008 817004 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 789056 789052 -4 -0.0
p6 all-clusters-app default (read/write) 2545624 2545608 -16 -0.0
.text 1503888 1503872 -16 -0.0
lock-app default (read/write) 2442728 2442712 -16 -0.0
.text 1400992 1400976 -16 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6544002 fe292ee change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651579 651579 0 0.0
(read/write) 158924 158924 0 0.0
.bss 74604 74604 0 0.0
.data 3404 3404 0 0.0
.rodata 85523 85523 0 0.0
.text 565824 565824 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617595 617595 0 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74955 74955 0 0.0
.text 542408 542408 0 0.0
lock-ftd LP_CC2652R7 (read only) 682967 682967 0 0.0
(read/write) 159864 159864 0 0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97671 97671 0 0.0
.text 584816 584816 0 0.0
lock-mtd LP_CC2652R7 (read only) 632367 632367 0 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97551 97551 0 0.0
.text 534328 534328 0 0.0
pump-app LP_CC2652R7 (read only) 664079 664079 0 0.0
(read/write) 179656 179656 0 0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85847 85847 0 0.0
.text 577752 577752 0 0.0
pump-controller-app LP_CC2652R7 (read only) 655151 655175 24 0.0
(read/write) 188696 188672 -24 -0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83895 83895 0 0.0
.text 570776 570800 24 0.0
shell LP_CC2652R7 (read only) 644602 644594 -8 -0.0
(read/write) 154480 154480 0 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 82506 82506 0 0.0
.text 561860 561852 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602110 602134 24 0.0
.app_xip_area 461136 461160 24 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599218 599218 0 0.0
.app_xip_area 458108 458108 0 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596890 596890 0 0.0
.app_xip_area 456912 456912 0 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916016 916032 16 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916008 916024 16 0.0
BRD4161A+rpc (read only) 950244 950260 16 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950236 950252 16 0.0
BRD4161A+rs911x (read only) 791228 791244 16 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791220 791236 16 0.0
lock-app BRD4161A+wf200 (read only) 958092 958092 0 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958084 958084 0 0.0
window-app BRD4161A (read only) 901056 901088 32 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901048 901080 32 0.0
esp32 all-clusters-app c3devkit (read only) 1007688 1007694 6 0.0
(read/write) 1481482 1481482 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212232 212232 0 0.0
.flash.text 1007688 1007694 6 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062651 1062643 -8 -0.0
(read/write) 483652 483652 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242768 242768 0 0.0
.flash.text 1057267 1057259 -8 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657992 658008 16 0.0
.bss 69760 69760 0 0.0
.data 2016 2016 0 0.0
.text 580416 580432 16 0.0
lock k32w061+release (read/write) 719220 719220 0 0.0
.bss 70192 70192 0 0.0
.data 1988 1988 0 0.0
.text 641240 641240 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9421636 9422036 400 0.0
(read/write) 677153 677153 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 614968 614968 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 460900 460900 0 0.0
.text 7413124 7413524 400 0.0
thermostat-no-ble arm64 (read only) 2367844 2368068 224 0.0
(read/write) 177505 177505 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148820 148820 0 0.0
.text 1989344 1989568 224 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427200 2427200 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389844 1389844 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191407 1191407 0 0.0
bss 141297 141297 0 0.0
rodata 154232 154232 0 0.0
text 817008 817004 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139127 1139127 0 0.0
bss 140514 140514 0 0.0
rodata 130744 130744 0 0.0
text 789056 789052 -4 -0.0
p6 all-clusters-app default (read/write) 2545624 2545608 -16 -0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503888 1503872 -16 -0.0
all-clusters-minimal-app default (read/write) 2490488 2490488 0 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448752 1448752 0 0.0
light-app default (read/write) 2422368 2422384 16 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380632 1380648 16 0.0
lock-app default (read/write) 2442728 2442712 -16 -0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1400992 1400976 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 780916 780924 8 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552312 552318 6 0.0
lighting-app tlsr9518adk80d (read/write) 800960 800960 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569054 569060 6 0.0

@isiu-apple isiu-apple merged commit 8953dcc into project-chip:master Jun 6, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-threadmetrics-struct branch June 6, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
app controller darwin examples linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @mrjerryjohns @isiu-apple