Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MW320 to all-clusters-app. #19302

Merged
merged 33 commits into from
Jun 24, 2022
Merged

Added MW320 to all-clusters-app. #19302

merged 33 commits into from
Jun 24, 2022

Conversation

nxptest
Copy link
Contributor

@nxptest nxptest commented Jun 8, 2022

Problem

What is being fixed? Examples:

  • Added MW320 to all-clusters-app.

Change overview

  • Example are added under directory "example/all-clusters-app/nxp/mw320".

Testing

Rebase to master and confirm build is all right.

Test pairing / on-off / switch / bind functions.

nxptest and others added 15 commits June 8, 2022 09:58
@nxptest
Added MW320 to all-clusters-app.
307182a 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Added draft README for MW320 all clusters app.
ec6a3d7 
Removed some unused files.

Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Update README.md
0285bde 
Added basic and building information.
@nxptest
Updated MW320 SDK to commit 3d93e61.
f555228 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Added image file for README.
9490e23 
Image used to show bring up messages of MW320.
@nxptest
Update README.md
31b4da7 
Added flashing information.
@nxptest
Update README.md
ad790f6
@nxptest
Update README.md
80d59a5 
Added "$" for commands.
@nxptest
Update README.md
271e883
@crlonxp @nxptest
Add the private emberAfExternalAttributeReadCallback() to fix the rea…
57dd584 
…d commission_info error in pairing

Signed-off-by: Chin-Ran Lo <chin-ran.lo@nxp.com>
@nxptest
Update README.md
35d3d7a
@crlonxp @nxptest
Enable Matter console messages on mw320
11a9f3a
@crlonxp @nxptest
Add binding function to mw320
41d9987
@nxptest
Update README.md
70b470f
@nxptest
Fixed compile error.
3446bb0 
Functin prototype is changed.

Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@restyled-io restyled-io bot mentioned this pull request Jun 8, 2022
Closed
@CLAassistant
Copy link

CLAassistant commented Jun 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nxptest
Fixed misspelling.
2e7763b 
Changed default SSID too.

Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Removed unused code.
5b1f44c 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@restyled-io restyled-io bot mentioned this pull request Jun 15, 2022
Closed
@andy31415
Copy link
Contributor

@nxptest - merge conflicts

@nxptest
Merge branch 'master' into TE9_upstream_pr
c67241f 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Copy link
Contributor Author

nxptest commented Jun 18, 2022

@andy31415 I resolved the merge conflicts. Thanks for your help.

@nxptest
Copy link
Contributor Author

nxptest commented Jun 22, 2022

@andy31415 What should I do to let this PR be merged? Thanks.

@woody-apple
Copy link
Contributor

@nxptest I approved the run, will merge once it passes CI!

@nxptest
Copy link
Contributor Author

nxptest commented Jun 23, 2022

@woody-apple Thanks for your help. I will check failed items.

@nxptest
Copy link
Contributor Author

nxptest commented Jun 23, 2022 •
edited
Loading

@woody-apple It looks like misspell does not happen in this PR.

Run igsekor/pyspelling-any@v0.0.2
/usr/bin/docker run --name igsekorpyspellingany_677f5b --label 72882e --workdir /github/workspace --rm -e INPUT_TOKEN -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_RUN_ATTEMPT -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_REF_NAME -e GITHUB_REF_PROTECTED -e GITHUB_REF_TYPE -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e GITHUB_STEP_SUMMARY -e RUNNER_OS -e RUNNER_ARCH -e RUNNER_NAME -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/connectedhomeip/connectedhomeip":"/github/workspace" igsekor/pyspelling-any
Starting...
Setup languages and spelling tool...
Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 3 not upgraded.
Using PySpelling according to configuration from .spellcheck.yml
**_Misspelled words:
examples/lighting-app/tizen/README.md

LightingApp
SDB
gdbserver

!!!Spelling check failed!!!_**
Files in repository contain spelling errors

@nxptest
Removed unused image.
dc4b62d 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Fixed checking error by Lint Action.
1031ce1 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Removed unused code.
c1e3f84 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Copy link
Contributor Author

nxptest commented Jun 23, 2022

@woody-apple I added patch to pass checking by Lint Action. I did not find misspell on my forked repository. However from detail information got from here, it looks like the misspell is not related to this PR.

@bzbarsky-apple
Copy link
Contributor

@nxptest Please resolve the merge conflict? The EFR32 CI timed out, but I can retrigger that as needed...

@nxptest
Merge branch 'master' into TE9_upstream_pr
9091538 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@nxptest
Copy link
Contributor Author

nxptest commented Jun 24, 2022

@bzbarsky-apple The merge conflict is resolved. Thanks for your help.

@nxptest
Fixed merge error.
47e83be 
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

PR #19302: Size comparison from ecabce0 to 47e83be

Increases (1 build for nrfconnect)
platform target config section ecabce0 47e83be change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 796060 796064 4 0.0
Decreases (1 build for telink)
platform target config section ecabce0 47e83be change % change
telink lighting-app tlsr9518adk80d text 577684 577682 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ecabce0 47e83be change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660539 660539 0 0.0
(read/write) 191532 191532 0 0.0
.bss 74964 74964 0 0.0
.data 3352 3352 0 0.0
.rodata 87059 87059 0 0.0
.text 573168 573168 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649431 649431 0 0.0
(read/write) 158520 158520 0 0.0
.bss 74252 74252 0 0.0
.data 3352 3352 0 0.0
.rodata 90671 90671 0 0.0
.text 558440 558440 0 0.0
lock-ftd LP_CC2652R7 (read only) 663523 663523 0 0.0
(read/write) 178692 178692 0 0.0
.bss 71996 71996 0 0.0
.data 3276 3276 0 0.0
.rodata 75179 75179 0 0.0
.text 587864 587864 0 0.0
lock-mtd LP_CC2652R7 (read only) 612939 612939 0 0.0
(read/write) 145124 145124 0 0.0
.bss 67732 67732 0 0.0
.data 3276 3276 0 0.0
.rodata 75059 75059 0 0.0
.text 537392 537392 0 0.0
pump-app LP_CC2652R7 (read only) 673439 673439 0 0.0
(read/write) 169640 169640 0 0.0
.bss 72092 72092 0 0.0
.data 3276 3276 0 0.0
.rodata 87831 87831 0 0.0
.text 585124 585124 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659319 659319 0 0.0
(read/write) 183872 183872 0 0.0
.bss 72204 72204 0 0.0
.data 3272 3272 0 0.0
.rodata 83671 83671 0 0.0
.text 575168 575168 0 0.0
shell LP_CC2652R7 (read only) 690378 690378 0 0.0
(read/write) 157196 157196 0 0.0
.bss 77268 77268 0 0.0
.data 3356 3356 0 0.0
.rodata 109922 109922 0 0.0
.text 580144 580144 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 592610 592610 0 0.0
.app_xip_area 462732 462732 0 0.0
.bss 72848 72848 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594218 594218 0 0.0
.app_xip_area 464132 464132 0 0.0
.bss 73048 73048 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595238 595238 0 0.0
.app_xip_area 466232 466232 0 0.0
.bss 72032 72032 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1071860 1071860 0 0.0
.bss 133716 133716 0 0.0
.data 2044 2044 0 0.0
.text 936080 936080 0 0.0
BRD4161A+rpc (read/write) 1125932 1125932 0 0.0
.bss 150404 150404 0 0.0
.data 2256 2256 0 0.0
.text 973252 973252 0 0.0
BRD4161A+rs911x (read/write) 936552 936552 0 0.0
.bss 140088 140088 0 0.0
.data 2044 2044 0 0.0
.text 794396 794396 0 0.0
lock-app BRD4161A+wf200 (read/write) 1116852 1116852 0 0.0
.bss 140536 140536 0 0.0
.data 2056 2056 0 0.0
.text 974240 974240 0 0.0
window-app BRD4161A (read/write) 1057112 1057112 0 0.0
.bss 133788 133788 0 0.0
.data 2072 2072 0 0.0
.text 921232 921232 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014324 1014324 0 0.0
(read/write) 1485698 1485698 0 0.0
.dram0.bss 71424 71424 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214224 214224 0 0.0
.flash.text 1014324 1014324 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068575 1068575 0 0.0
(read/write) 487800 487800 0 0.0
.dram0.bss 76936 76936 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244724 244724 0 0.0
.flash.text 1063191 1063191 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 662232 662232 0 0.0
.bss 70396 70396 0 0.0
.data 1988 1988 0 0.0
.text 584048 584048 0 0.0
lock k32w061+release (read/write) 694528 694528 0 0.0
.bss 70868 70868 0 0.0
.data 2000 2000 0 0.0
.text 615860 615860 0 0.0
linux all-clusters-app debug (read only) 2939105 2939105 0 0.0
(read/write) 177040 177040 0 0.0
.bss 84192 84192 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 84632 84632 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261597 261597 0 0.0
.text 2501186 2501186 0 0.0
all-clusters-minimal-app debug (read only) 2792913 2792913 0 0.0
(read/write) 168944 168944 0 0.0
.bss 83520 83520 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 77272 77272 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263229 263229 0 0.0
.text 2355538 2355538 0 0.0
bridge-app debug+rpc (read only) 2296897 2296897 0 0.0
(read/write) 147872 147872 0 0.0
.bss 71616 71616 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66696 66696 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196416 196416 0 0.0
.text 1939394 1939394 0 0.0
chip-tool debug (read only) 10168413 10168413 0 0.0
(read/write) 610600 610600 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578800 578800 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508645 508645 0 0.0
.text 8251733 8251733 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9904764 9904764 0 0.0
(read/write) 675281 675281 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614200 614200 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471452 471452 0 0.0
.text 7894404 7894404 0 0.0
lighting-app debug+rpc (read only) 2533665 2533665 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72096 72096 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71848 71848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212168 212168 0 0.0
.text 2151826 2151826 0 0.0
lock-app debug (read only) 2495849 2495849 0 0.0
(read/write) 146904 146904 0 0.0
.bss 70528 70528 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68824 68824 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 227016 227016 0 0.0
.text 2104322 2104322 0 0.0
ota-provider-app debug (read only) 2304809 2304809 0 0.0
(read/write) 140712 140712 0 0.0
.bss 70176 70176 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62808 62808 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202072 202072 0 0.0
.text 1940610 1940610 0 0.0
ota-requestor-app debug (read only) 2421881 2421881 0 0.0
(read/write) 147584 147584 0 0.0
.bss 72544 72544 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205920 205920 0 0.0
.text 2045458 2045458 0 0.0
shell debug (read only) 2612817 2612817 0 0.0
(read/write) 196056 196056 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77768 77768 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231666 231666 0 0.0
.text 2221538 2221538 0 0.0
thermostat-no-ble arm64 (read only) 2579164 2579164 0 0.0
(read/write) 180593 180593 0 0.0
.bss 87905 87905 0 0.0
.data 1696 1696 0 0.0
.data.rel.ro 82888 82888 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164812 164812 0 0.0
.text 2175296 2175296 0 0.0
tv-app debug (read only) 3082313 3082313 0 0.0
(read/write) 277800 277800 0 0.0
.bss 187720 187720 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247840 247840 0 0.0
.text 2647682 2647682 0 0.0
tv-casting-app debug (read only) 5573513 5573513 0 0.0
(read/write) 184048 184048 0 0.0
.bss 72872 72872 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102544 102544 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341929 341929 0 0.0
.text 4955426 4955426 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2444192 2444192 0 0.0
.bss 214724 214724 0 0.0
.data 5872 5872 0 0.0
.text 1406836 1406836 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1203259 1203259 0 0.0
bss 143646 143646 0 0.0
rodata 156436 156436 0 0.0
text 824272 824272 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1150607 1150607 0 0.0
bss 142882 142882 0 0.0
rodata 132768 132768 0 0.0
text 796060 796064 4 0.0
p6 all-clusters-app default (read/write) 2556024 2556024 0 0.0
.bss 149872 149872 0 0.0
.data 2768 2768 0 0.0
.text 1514288 1514288 0 0.0
all-clusters-minimal-app default (read/write) 2501872 2501872 0 0.0
.bss 149152 149152 0 0.0
.data 2768 2768 0 0.0
.text 1460136 1460136 0 0.0
light-app default (read/write) 2432632 2432632 0 0.0
.bss 141232 141232 0 0.0
.data 2584 2584 0 0.0
.text 1390896 1390896 0 0.0
lock-app default (read/write) 2458896 2458896 0 0.0
.bss 141080 141080 0 0.0
.data 2600 2600 0 0.0
.text 1417160 1417160 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 793188 793188 0 0.0
bss 71924 71924 0 0.0
noinit 40416 40416 0 0.0
text 561222 561222 0 0.0
lighting-app tlsr9518adk80d (read/write) 812900 812900 0 0.0
bss 72172 72172 0 0.0
noinit 40416 40416 0 0.0
text 577684 577682 -2 -0.0

@nxptest
Copy link
Contributor Author

nxptest commented Jun 24, 2022

@bzbarsky-apple Failure of 'Tests/Test Suites -Darwin' is due to timeout.

@Damian-Nordic Damian-Nordic merged commit 2d0c529 into project-chip:master Jun 24, 2022
@nxptest nxptest deleted the TE9_upstream_pr branch June 27, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crlonxp crlonxp crlonxp left review comments

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples lib lwip platform review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nxptest @CLAassistant @andy31415 @woody-apple @bzbarsky-apple @crlonxp @Damian-Nordic @restyled-commits