Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle Properly manage operational key lifecycle for fail-safe #19358

Closed
wants to merge 27 commits into from
Closed

Restyle Properly manage operational key lifecycle for fail-safe #19358

wants to merge 27 commits into from

Commits on Jun 7, 2022

  1. Properly manage operational key lifecycle for fail-safe 

    - Fail-safe did not properly manage the roll-back of operational keys
- Operational key storage being centralized by value in FabricTable
  prevented ability to back keys by hardware/OS and allow the rollback
  of keys on failsafe expiry
- CASE code was using "raw" FabricInfo * which could go stale on UpdateNOC
  or after fail-safe expiry.

This PR:
- Adds an OperationalKeystore interface
- Make the FabricTable use the OperationalKeystore for when
  a commissionable node (with Opcreds cluster) is being commissioned
- Retain legacy controller behavior that allows injection of operational
  keys
- Simplifies the fail-safe handling lifecycle
- Add logging to fail-safe handling
- Add logging to general commissioning cluster
- Make CASE use ScopedNodeId everywhere
- Implement IsForUpdateNOC in fail-safe and opcreds cluster

Fixes #19072
Issue #18633
Fixes #16443
    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    f29b087 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into keystore-wip2

    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    afe825d View commit details
    Browse the repository at this point in the history

  3. Fix merge of upstream

    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    538eed3 View commit details
    Browse the repository at this point in the history

  4. Restyled by whitespace

    @restyled-commits
    restyled-commits committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d7d2be9 View commit details
    Browse the repository at this point in the history

  5. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    7adf8df View commit details
    Browse the repository at this point in the history

  6. Revert unintended testing changes

    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    cfe632e View commit details
    Browse the repository at this point in the history

  7. Add remove operation

    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    09e9f93 View commit details
    Browse the repository at this point in the history

  8. Fix CI and add tests to support further tests

    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    1f63076 View commit details
    Browse the repository at this point in the history

  9. Fix more CI

    @tcarmelveilleux
    tcarmelveilleux committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    1037160 View commit details
    Browse the repository at this point in the history

  10. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    a719d77 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Darwin changes to use the new setup

    @bzbarsky-apple
    bzbarsky-apple committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    65742b1 View commit details
    Browse the repository at this point in the history

  2. Added unit test and HasOpKeypairForFabric()

    @tcarmelveilleux
    tcarmelveilleux committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9350b1f View commit details
    Browse the repository at this point in the history

  3. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    b44d4d7 View commit details
    Browse the repository at this point in the history

  4. Restyled by gn

    @restyled-commits
    restyled-commits committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7f422cd View commit details
    Browse the repository at this point in the history

  5. Apply review comments from @msandstedt

    @tcarmelveilleux
    tcarmelveilleux committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    2d01768 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #4 from bzbarsky-apple/testing 

    Darwin changes to use the new setup
    @tcarmelveilleux
    tcarmelveilleux authored Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a7062a3 View commit details
    Browse the repository at this point in the history

  7. Add plumbing for init of controllers

    @tcarmelveilleux
    tcarmelveilleux committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6d36c2c View commit details
    Browse the repository at this point in the history

  8. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    f89a544 View commit details
    Browse the repository at this point in the history

  9. Fix darwin tests

    @bzbarsky-apple
    bzbarsky-apple committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    bb698d3 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #5 from bzbarsky-apple/testing 

    Fix darwin tests
    @tcarmelveilleux
    tcarmelveilleux authored Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d145381 View commit details
    Browse the repository at this point in the history

  11. Fix CI and address review comments

    @tcarmelveilleux
    tcarmelveilleux committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a3f25a2 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'upstream/master' into keystore-wip2

    @tcarmelveilleux
    tcarmelveilleux committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    95f98d6 View commit details
    Browse the repository at this point in the history

  13. Fix comment typos

    @tcarmelveilleux
    tcarmelveilleux committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    59cb65a View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Apply review comments from @bzbarsky-apple and @tehampson

    @tcarmelveilleux
    tcarmelveilleux committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    622121b View commit details
    Browse the repository at this point in the history

  2. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f3d9cfb View commit details
    Browse the repository at this point in the history

  3. Fix more comments

    @tcarmelveilleux
    tcarmelveilleux committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    9b5a0e4 View commit details
    Browse the repository at this point in the history

  4. Restyled by clang-format

    @restyled-commits
    restyled-commits committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e351173 View commit details
    Browse the repository at this point in the history