Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable COTA feature #19815

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Enable COTA feature #19815

merged 2 commits into from
Jun 21, 2022

Conversation

Morozov-5F
Copy link
Contributor

Problem

Change overview

  • Enabled COTA feature because tests expect it to be there

Testing

  • Run all the DL tests against the Linux lock app

@Morozov-5F Morozov-5F changed the title Feature/enable cota feature Enable cota feature Jun 21, 2022
@Morozov-5F Morozov-5F changed the title Enable cota feature Enable COTA feature Jun 21, 2022
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19815: Size comparison from 39073b3 to 56302ac

Increases (8 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6)
platform target config section 39073b3 56302ac change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660135 8 0.0
.text 572576 572584 8 0.0
lock-ftd LP_CC2652R7 (read only) 691511 691535 24 0.0
.rodata 99527 99551 24 0.0
lock-mtd LP_CC2652R7 (read only) 640919 640951 32 0.0
.rodata 99407 99431 24 0.0
.text 541020 541028 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 610602 610626 24 0.0
.app_xip_area 467076 467100 24 0.0
k32w lock k32w061+release (read/write) 722132 722156 24 0.0
.text 645128 645152 24 0.0
linux lock-app debug (read/write) 146544 146576 32 0.0
.data.rel.ro 68568 68600 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2439048 2439072 24 0.0
.text 1401692 1401716 24 0.0
p6 lock-app default (read/write) 2452688 2452712 24 0.0
.text 1410952 1410976 24 0.0
Decreases (4 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 39073b3 56302ac change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 190744 190736 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 149472 149448 -24 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 795316 795312 -4 -0.0
telink light-switch-app tlsr9518adk80d text 560392 560390 -2 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 39073b3 56302ac change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660135 8 0.0
(read/write) 190744 190736 -8 -0.0
.bss 73764 73764 0 0.0
.data 3356 3356 0 0.0
.rodata 87239 87239 0 0.0
.text 572576 572584 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648947 648947 0 0.0
(read/write) 157324 157324 0 0.0
.bss 73052 73052 0 0.0
.data 3356 3356 0 0.0
.rodata 90771 90771 0 0.0
.text 557856 557856 0 0.0
lock-ftd LP_CC2652R7 (read only) 691511 691535 24 0.0
(read/write) 149472 149448 -24 -0.0
.bss 70764 70764 0 0.0
.data 3280 3280 0 0.0
.rodata 99527 99551 24 0.0
.text 591500 591500 0 0.0
lock-mtd LP_CC2652R7 (read only) 640919 640951 32 0.0
(read/write) 143896 143896 0 0.0
.bss 66500 66500 0 0.0
.data 3280 3280 0 0.0
.rodata 99407 99431 24 0.0
.text 541020 541028 8 0.0
pump-app LP_CC2652R7 (read only) 672799 672799 0 0.0
(read/write) 169072 169072 0 0.0
.bss 70884 70884 0 0.0
.data 3280 3280 0 0.0
.rodata 87903 87903 0 0.0
.text 584412 584412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 658675 658675 0 0.0
(read/write) 183308 183308 0 0.0
.bss 70996 70996 0 0.0
.data 3276 3276 0 0.0
.rodata 83747 83747 0 0.0
.text 574448 574448 0 0.0
shell LP_CC2652R7 (read only) 689870 689870 0 0.0
(read/write) 156496 156496 0 0.0
.bss 76060 76060 0 0.0
.data 3360 3360 0 0.0
.rodata 110022 110022 0 0.0
.text 579536 579536 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 613246 613246 0 0.0
.app_xip_area 469896 469896 0 0.0
.bss 86304 86304 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610602 610626 24 0.0
.app_xip_area 467076 467100 24 0.0
.bss 86480 86480 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 617134 617134 0 0.0
.app_xip_area 474672 474672 0 0.0
.bss 85472 85472 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013698 0 0.0
(read/write) 1483554 1483554 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214080 214080 0 0.0
.flash.text 1013698 1013698 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068163 1068163 0 0.0
(read/write) 485640 485640 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244580 244580 0 0.0
.flash.text 1062779 1062779 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659604 659604 0 0.0
.bss 68764 68764 0 0.0
.data 1992 1992 0 0.0
.text 583048 583048 0 0.0
lock k32w061+release (read/write) 722132 722156 24 0.0
.bss 69204 69204 0 0.0
.data 2000 2000 0 0.0
.text 645128 645152 24 0.0
linux all-clusters-app debug (read only) 2936105 2936105 0 0.0
(read/write) 177072 177072 0 0.0
.bss 84160 84160 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261149 261149 0 0.0
.text 2498514 2498514 0 0.0
all-clusters-minimal-app debug (read only) 2789817 2789817 0 0.0
(read/write) 168976 168976 0 0.0
.bss 83488 83488 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 262685 262685 0 0.0
.text 2352866 2352866 0 0.0
bridge-app debug+rpc (read only) 2292513 2292513 0 0.0
(read/write) 147840 147840 0 0.0
.bss 71552 71552 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 195936 195936 0 0.0
.text 1935394 1935394 0 0.0
chip-tool debug (read only) 10147117 10147117 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510389 510389 0 0.0
.text 8230997 8230997 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9886988 9886988 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473180 473180 0 0.0
.text 7877380 7877380 0 0.0
lighting-app debug+rpc (read only) 2525209 2525209 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72032 72032 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 211688 211688 0 0.0
.text 2143730 2143730 0 0.0
lock-app debug (read only) 2463905 2463905 0 0.0
(read/write) 146544 146576 32 0.0
.bss 70432 70432 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68600 32 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225384 225384 0 0.0
.text 2074130 2074130 0 0.0
ota-provider-app debug (read only) 2301857 2301857 0 0.0
(read/write) 140680 140680 0 0.0
.bss 70112 70112 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 201624 201624 0 0.0
.text 1937986 1937986 0 0.0
ota-requestor-app debug (read only) 2417665 2417665 0 0.0
(read/write) 147392 147392 0 0.0
.bss 72416 72416 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205280 205280 0 0.0
.text 2041906 2041906 0 0.0
shell debug (read only) 2609921 2609921 0 0.0
(read/write) 196088 196088 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231378 231378 0 0.0
.text 2218786 2218786 0 0.0
thermostat-no-ble arm64 (read only) 2575988 2575988 0 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164196 164196 0 0.0
.text 2172720 2172720 0 0.0
tv-app debug (read only) 3073777 3073777 0 0.0
(read/write) 277768 277768 0 0.0
.bss 187656 187656 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247296 247296 0 0.0
.text 2639618 2639618 0 0.0
tv-casting-app debug (read only) 5539297 5539297 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72840 72840 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341257 341257 0 0.0
.text 4921810 4921810 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439048 2439072 24 0.0
.bss 208212 208212 0 0.0
.data 5864 5864 0 0.0
.text 1401692 1401716 24 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199927 1199927 0 0.0
bss 141606 141606 0 0.0
rodata 156312 156312 0 0.0
text 823096 823096 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1147887 1147887 0 0.0
bss 140858 140858 0 0.0
rodata 132840 132840 0 0.0
text 795316 795312 -4 -0.0
p6 all-clusters-app default (read/write) 2555392 2555392 0 0.0
.bss 143392 143392 0 0.0
.data 2776 2776 0 0.0
.text 1513656 1513656 0 0.0
all-clusters-minimal-app default (read/write) 2501240 2501240 0 0.0
.bss 142672 142672 0 0.0
.data 2776 2776 0 0.0
.text 1459504 1459504 0 0.0
light-app default (read/write) 2432000 2432000 0 0.0
.bss 134752 134752 0 0.0
.data 2592 2592 0 0.0
.text 1390264 1390264 0 0.0
lock-app default (read/write) 2452688 2452712 24 0.0
.bss 134576 134576 0 0.0
.data 2600 2600 0 0.0
.text 1410952 1410976 24 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790472 790472 0 0.0
bss 69900 69900 0 0.0
noinit 40416 40416 0 0.0
text 560392 560390 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 810184 810184 0 0.0
bss 70148 70148 0 0.0
noinit 40416 40416 0 0.0
text 576852 576852 0 0.0

@andy31415 andy31415 merged commit e5b77e4 into project-chip:master Jun 21, 2022
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 22, 2022
Closed
@Morozov-5F Morozov-5F deleted the feature/enable-cota-feature branch July 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morozov-5F @andy31415 @bzbarsky-apple