Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SessionManager::Shutdown to actually shut-down sessions #20487

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix SessionManager::Shutdown to actually shut-down sessions #20487

merged 1 commit into from
Jul 8, 2022

Commits on Jul 8, 2022

  1. Fix SessionManager::Shutdown to actually shut-down sessions 

    SessionManager::Shutdown() wasn't actually shutting down any sessions
that were resident in the session table.

This meant that they would only get torn down on program termination,
which causes issues in the Python REPL since it results in Log prints
being emitted well after we've actually disconnected the logging
subsystem.
    @mrjerryjohns
    mrjerryjohns committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    2e07871 View commit details
    Browse the repository at this point in the history