-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update darwin framework tool build #20582
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:UpdateDarwinFrameworkToolBuild
Jul 14, 2022
Merged
Update darwin framework tool build #20582
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:UpdateDarwinFrameworkToolBuild
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
robszewczyk
July 11, 2022 22:43
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
July 11, 2022 22:43
krypton36
force-pushed
the
UpdateDarwinFrameworkToolBuild
branch
from
July 11, 2022 22:52
9d2b32e
to
4469959
Compare
PR #20582: Size comparison from 0d703bb to 4469959 Decreases (4 builds for cyw30739, nrfconnect, telink)
Full report (12 builds for cyw30739, k32w, linux, mbed, nrfconnect, telink)
|
krypton36
force-pushed
the
UpdateDarwinFrameworkToolBuild
branch
from
July 11, 2022 23:29
4469959
to
f863915
Compare
PR #20582: Size comparison from 0d703bb to f863915 Increases (4 builds for cc13x2_26x2, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739)
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
UpdateDarwinFrameworkToolBuild
branch
from
July 12, 2022 00:17
f863915
to
2cd3da6
Compare
PR #20582: Size comparison from 0d703bb to 2cd3da6 Increases (3 builds for cc13x2_26x2, esp32)
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Jul 12, 2022
bzbarsky-apple
approved these changes
Jul 13, 2022
examples/darwin-framework-tool/commands/clusters/ClusterCommandBridge.h
Outdated
Show resolved
Hide resolved
krypton36
force-pushed
the
UpdateDarwinFrameworkToolBuild
branch
from
July 13, 2022 16:13
2cd3da6
to
871111a
Compare
krypton36
force-pushed
the
UpdateDarwinFrameworkToolBuild
branch
from
July 13, 2022 16:20
871111a
to
d83dc55
Compare
PR #20582: Size comparison from 51e41f9 to d83dc55 Increases (4 builds for cc13x2_26x2, cyw30739, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 13, 2022
examples/darwin-framework-tool/commands/clusters/ClusterCommandBridge.h
Outdated
Show resolved
Hide resolved
krypton36
force-pushed
the
UpdateDarwinFrameworkToolBuild
branch
from
July 13, 2022 18:27
d83dc55
to
fa6f4eb
Compare
PR #20582: Size comparison from cbabee6 to fa6f4eb Increases (3 builds for cc13x2_26x2, esp32)
Decreases (5 builds for cc13x2_26x2, cyw30739, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jul 14, 2022
andy31415
pushed a commit
that referenced
this pull request
Jul 14, 2022
shubhamdp
pushed a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Darwin-framework-tool is building libCHIP and linking to it via examples/chip-tool:chip-tool-utils and depending on source files.
Change overview
Testing