[chip-tool] Add subscribe-all command #20868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda and
mrjerryjohns
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #20868: Size comparison from e4cfa0a to 041b687 Increases above 0.2%:
Increases (5 builds for cyw30739, esp32, linux)
Decreases (4 builds for bl602, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
force-pushed
the
ChipTool_SubscribeAll
branch
from
041b687
to
f04c0fb
Compare
|
PR #20868: Size comparison from fcd6594 to f04c0fb Increases above 0.2%:
Increases (5 builds for esp32, linux, telink)
Decreases (2 builds for nrfconnect, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 19, 2022
|
Fast tracking tests |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
* [chip-tool] Update read-all command such that an arbitrary number of attributes/events can be used * [chip-tool] Add subscribe-all command to chip-tool * Update generated code
woody-apple
added a commit
that referenced
this pull request
Jul 20, 2022
Comment on lines
+478
to
+479
| "\nCommand targetting a combination of attribute and event paths needs to have has many clusters and " | ||
| "endpoints than the number of attribute and events combined.\n" |
There was a problem hiding this comment.
"... needs to have the same number of clusters and endpoints specified as there are attribute and event ids combined".
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* [chip-tool] Update read-all command such that an arbitrary number of attributes/events can be used * [chip-tool] Add subscribe-all command to chip-tool * Update generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no command in
chip-toolto subscribe to both an attribute and an event into a single interaction.#fix #20479
Change overview
read-allto be more granular. The user can choose which attributes and events that needs to be readsubscribe-allcommand tochip-toolTesting
It was tested by the commands: