[size-opt] Optimize DefaultStorageKeyAllocator code size #20926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that calling Format() for each key costs non-negligible amount of flash while it's not really needed for constant keys. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
rgoliver,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #20926: Size comparison from fcd6594 to 1a6ca18 Increases above 0.2%:
Increases (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (26 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 19, 2022
msandstedt
approved these changes
Jul 19, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
It turns out that calling Format() for each key costs non-negligible amount of flash while it's not really needed for constant keys. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
woody-apple
added a commit
that referenced
this pull request
Jul 19, 2022
…0941) It turns out that calling Format() for each key costs non-negligible amount of flash while it's not really needed for constant keys. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> Co-authored-by: Damian Królik <66667989+Damian-Nordic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It turns out that calling
DefaultStorageKeyAllocator::Format()for each key costs non-negligible amount of flash while it's not really needed for constant keys.Change overview
Change
DefaultStorageKeyAllocatorso that using constant keys can be easily optimized by compilers.That small optimization saves almost 1kB of flash on some ARM examples.
Changed static methods of the class to non-static to unify the way the class is used.
Testing
Unit tests + tested commissioning and control after the device reboot.