-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS TvCasting app: Add support for additional Media commands to MatterTvCastingBridge Framework #21027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rTvCastingBridge lib
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
July 20, 2022 22:17
pullapprove
bot
requested review from
vijs,
vivien-apple,
mspang,
saurabhst,
wbschiller,
selissia,
xylophone21,
tecimovic,
yufengwangca,
tehampson,
yunhanw-google and
turon
July 20, 2022 22:17
PR #21027: Size comparison from 8145ce3 to 9e80775 Increases (3 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 20, 2022
chrisdecenzo
approved these changes
Jul 22, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…rTvCastingBridge lib (#21027)
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…rTvCastingBridge lib (project-chip#21027)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The iOS tv-casting library does not support sending Media commands other than the Content Launcher: LaunchURL. See #20060
(This PR is similar to previous Android PR: #20973)
Change overview
Add support to the MatterTvCasting Bridge Framework to allow sending Matter Media commands beyond LaunchURL.
TBD: UI updates to the Android tv-casting-app to send these new commands will be added in a follow-up PR (to let this PR be readable/reviewable)
Testing
Built and tested the iOS tv-casting-app to ensure it can still send the Content Launcher Launch URL command.