[ESP32] Fix namespace for unique id and added rotating device id unique id key in chip-factory namespace #22063
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdp
force-pushed
the
esp32_unique_id
branch
from
c076ff0
to
6eda047
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
mspang,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #22063: Size comparison from a8d12af to 6eda047 Increases (4 builds for esp32, psoc6, telink)
Decreases (3 builds for nrfconnect, psoc6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
dhrishi
reviewed
Aug 22, 2022
dhrishi
approved these changes
Aug 22, 2022
tcarmelveilleux
approved these changes
Aug 22, 2022
unique id key in chip-factory namespace Unique-id should be changed after every factory reset and to do that it should be stored in chip-config namespace. Earlier it was stored in chip-factory which is not erased on factory reset.
shubhamdp
force-pushed
the
esp32_unique_id
branch
from
6eda047
to
fdd64ff
Compare
|
PR #22063: Size comparison from 48f87f3 to fdd64ff Increases (7 builds for esp32, nrfconnect, psoc6)
Decreases (3 builds for bl602, cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ject-chip#22063) unique id key in chip-factory namespace Unique-id should be changed after every factory reset and to do that it should be stored in chip-config namespace. Earlier it was stored in chip-factory which is not erased on factory reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unique-id should be changed after every factory reset and to do that it
should be stored in chip-config namespace.
Earlier it was stored in chip-factory which is not erased on factory reset.
Change overview
Testing
Flashed the generated partition and made sure the value of rotating device id unique id is same as that was flashed.