Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chip Over Bluez Implementation #2223

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Aug 18, 2020

-- Implement CHIPBluezHelper based upon the Thread Bluez Gio code from
openthread.
-- Implement BLEManager and corresponding state machine and event
handling module.
-- Implement TestCHIPoBLEStackMgr test
-- Current code suport CHIPoBLE peripheral mode.
-- Validated via repeatedly creating BLE connection, CHIP BTP communication via characteristic C1
and C2

Fix #2025

@yunhanw-google yunhanw-google force-pushed the feature/add_chip_bluez_implementation branch 12 times, most recently from 4cd7682 to bae6b17 Compare August 19, 2020 03:46
-- Implement CHIPBluezHelper based upon the Thread Bluez Gio code from
openthread.
-- Implement BLEManager and corresponding state machine and event
handling module.
-- Implement TestCHIPoBLEStackMgr test
-- Current code suport CHIPoBLE peripheral mode.
-- Validated via repeatedly creating BLE connection, CHIP BTP communication via characteristic C1
and C2

Fix project-chip#2025
@yunhanw-google yunhanw-google force-pushed the feature/add_chip_bluez_implementation branch from bae6b17 to 110cacd Compare August 19, 2020 04:07
@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
[Unmapped],0,1
.debug_line,0,-5


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
chip-standalone-demo.out .eh_frame 8 8
chip-standalone-demo.out .text -32 -32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_info,0,332
.debug_str,0,135
.debug_abbrev,0,35
[Unmapped],0,21
.strtab,0,19
.debug_macro,0,14
.eh_frame,8,8
.text,-32,-32
.debug_ranges,0,-48
.debug_line,0,-86
.debug_loc,0,-550


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


};

enum
{
kMaxConnections = MIN(BLE_LAYER_NUM_BLE_ENDPOINTS, NRF_SDH_BLE_PERIPHERAL_LINK_COUNT),
kMaxConnections = 1, // TODO: right max connection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a github issue for these TODOs? Thinking of a TODO format like

TODO(#issueid): ....

so that they are tracked and also greppable when we fix them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I would address it when adding bluez central support where there are multiple ble connection. #2027

@yunhanw-google
Copy link
Contributor Author

@BroderickCarlin / @saurabhst / @jelderton ?
Thanks

@BroderickCarlin BroderickCarlin merged commit e860aab into project-chip:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ChipOverBluez Peripheral feature in Linux Device Layer
5 participants