-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chip Over Bluez Implementation #2223
Add Chip Over Bluez Implementation #2223
Conversation
29767ca
to
acf4983
Compare
4cd7682
to
bae6b17
Compare
-- Implement CHIPBluezHelper based upon the Thread Bluez Gio code from openthread. -- Implement BLEManager and corresponding state machine and event handling module. -- Implement TestCHIPoBLEStackMgr test -- Current code suport CHIPoBLE peripheral mode. -- Validated via repeatedly creating BLE connection, CHIP BTP communication via characteristic C1 and C2 Fix project-chip#2025
bae6b17
to
110cacd
Compare
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
}; | ||
|
||
enum | ||
{ | ||
kMaxConnections = MIN(BLE_LAYER_NUM_BLE_ENDPOINTS, NRF_SDH_BLE_PERIPHERAL_LINK_COUNT), | ||
kMaxConnections = 1, // TODO: right max connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a github issue for these TODOs? Thinking of a TODO format like
TODO(#issueid): ....
so that they are tracked and also greppable when we fix them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I would address it when adding bluez central support where there are multiple ble connection. #2027
@BroderickCarlin / @saurabhst / @jelderton ? |
-- Implement CHIPBluezHelper based upon the Thread Bluez Gio code from
openthread.
-- Implement BLEManager and corresponding state machine and event
handling module.
-- Implement TestCHIPoBLEStackMgr test
-- Current code suport CHIPoBLE peripheral mode.
-- Validated via repeatedly creating BLE connection, CHIP BTP communication via characteristic C1
and C2
Fix #2025