Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf5-demo] Print QR code on boot #2233

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

erjiaqing
Copy link
Contributor

No description provided.

{
abort();
}
// void * __cxa_begin_catch(void *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.../chip/chip-demo-202008/third_party/pigweed/repo/.environment/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/9.3.1/../../../../arm-none-eabi/lib/thumb/v7e-m+fp/hard/libstdc++_nano.a(eh_catch.o): in function `__cxa_get_exception_ptr':
eh_catch.cc:(.text.__cxa_get_exception_ptr+0x0): multiple definition of `__cxa_get_exception_ptr'; obj/third_party/connectedhomeip/examples/platform/nrf528xx/app/support/chip-nrf52840-lock-example.CXXExceptionStubs.cpp.o:.../source/chip/chip-nrf5-qrcode/examples/lock-app/nrf5/out/debug/../../third_party/connectedhomeip/examples/platform/nrf528xx/app/support/CXXExceptionStubs.cpp:77: first defined here

This is caused by STL exceptions introduced by setup payload, which is also the reason of the huge size increase, this is expected to be removed after we have another setup payload implemtation without stl.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete instead of commenting out. I generally would try to avoid commented out code.

Copy link
Contributor

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 155576 155576
chip-nrf52840-lock-example.out .bss 0 5736
chip-nrf52840-lock-example.out .data 636 636
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_info,0,317308
.debug_str,0,166467
.text,155576,155576
.strtab,0,115445
.debug_frame,0,87288
.symtab,0,82048
.debug_loc,0,58599
.debug_line,0,43263
[Unmapped],0,41029
.debug_abbrev,0,14883
.debug_macro,0,12606
.debug_ranges,0,9432
.bss,5736,0
.debug_aranges,0,928
.data,636,636
.stabstr,0,52


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


{
abort();
}
// void * __cxa_begin_catch(void *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete instead of commenting out. I generally would try to avoid commented out code.

@woody-apple woody-apple merged commit 52ca3a2 into project-chip:master Aug 19, 2020
@erjiaqing erjiaqing deleted the chip-nrf5-qrcode branch January 29, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants