-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf5-demo] Print QR code on boot #2233
Conversation
{ | ||
abort(); | ||
} | ||
// void * __cxa_begin_catch(void *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.../chip/chip-demo-202008/third_party/pigweed/repo/.environment/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/9.3.1/../../../../arm-none-eabi/lib/thumb/v7e-m+fp/hard/libstdc++_nano.a(eh_catch.o): in function `__cxa_get_exception_ptr':
eh_catch.cc:(.text.__cxa_get_exception_ptr+0x0): multiple definition of `__cxa_get_exception_ptr'; obj/third_party/connectedhomeip/examples/platform/nrf528xx/app/support/chip-nrf52840-lock-example.CXXExceptionStubs.cpp.o:.../source/chip/chip-nrf5-qrcode/examples/lock-app/nrf5/out/debug/../../third_party/connectedhomeip/examples/platform/nrf528xx/app/support/CXXExceptionStubs.cpp:77: first defined here
This is caused by STL exceptions introduced by setup payload, which is also the reason of the huge size increase, this is expected to be removed after we have another setup payload implemtation without stl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete instead of commenting out. I generally would try to avoid commented out code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
{ | ||
abort(); | ||
} | ||
// void * __cxa_begin_catch(void *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete instead of commenting out. I generally would try to avoid commented out code.
No description provided.