-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist the endpoints that were discovered to maintain endpointIds across restart of tv-app #22354
Merged
+266
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22354: Size comparison from 29e8d65 to b593da7 Increases (6 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (3 builds for bl602, cc13x2_26x2, nrfconnect)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
b593da7
to
acc5202
Compare
PR #22354: Size comparison from b6aac34 to acc5202 Increases (5 builds for esp32, k32w, psoc6, qpg, telink)
Decreases (3 builds for esp32, psoc6)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
61fddf6
to
a20e20d
Compare
@amitnj - please try to not force-push changes to branches as this loses all history of comments in files. This makes it much harder to figure out where I had comments before. |
andy31415
reviewed
Sep 12, 2022
andy31415
approved these changes
Sep 12, 2022
Accepted for 1.0: examples change only |
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ross restart of tv-app (project-chip#22354) * Persist the endpoints that were discovered to maintain endpointIds across startup. * Refactor to remove commissioner initialization from AppImpl to TvApp. * Restyled by google-java-format * Restyled by clang-format * Roll back change because of lint error. * Address review comments regarding memory alocation and logs. * Restyled by google-java-format * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The endpoint that tv-app adds are not persisted across restarts. This would mean that commissioning will have to be repeated for the same set of endpoints across restarts of the tv-app.
Fixes #22527
Change overview
The java layer of the tv-app now persists the endpointIds added for content apps and uses that at the start to pass in the desired endpointId when adding the content app to the content app platform.
Missing documentation from a previous PR was also added.
Testing
Manually using the tv-casting-app.