-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrity protect unencrypted portion of message header #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
August 19, 2020 14:30
woody-apple
approved these changes
Aug 19, 2020
balducci-apple
approved these changes
Aug 19, 2020
andy31415
reviewed
Aug 19, 2020
andy31415
approved these changes
Aug 19, 2020
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
BroderickCarlin
approved these changes
Aug 19, 2020
saurabhst
approved these changes
Aug 19, 2020
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Aug 22, 2020
…ect-chip#2237)" This reverts commit dc89961.
mspang
pushed a commit
to mspang/connectedhomeip
that referenced
this pull request
Aug 25, 2020
…#2237) * Integrity protect unencrypted portion of message header * more descriptive function name and comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unencrypted portion of message header is not integrity protected.
Summary of Changes
Use unencrypted header as AAD (additional authenticated data) during encryption and decryption. The encryption operation includes AAD when MAC tag is generated.