Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[darwin] ROOT LEAK: <chip::DeviceLayer::Internal::Ble*DelegateImpl #22374

Merged
merged 2 commits into from
Sep 3, 2022
Merged

[darwin] ROOT LEAK: <chip::DeviceLayer::Internal::Ble*DelegateImpl #22374

merged 2 commits into from
Sep 3, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

When restarting the Matter stack, the BLEManagerImpl leaks some delegates.

The steps to reproduce are the following:

leaks -atExit -- ./out/debug/standalone/darwin-framework-tool interactive start
#once in interative mode, press Ctrl+^
quit()

Change overview

  • free the delegate objects

Testing

Can't see the leaks after that.

@vivien-apple vivien-apple self-assigned this Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited
Loading

PR #22374: Size comparison from 3522317 to 75d73a2

Increases (4 builds for cc13x2_26x2, nrfconnect, psoc6)
platform target config section 3522317 75d73a2 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676411 676419 8 0.0
.text 598864 598872 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815004 815008 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21914340 21914341 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22294086 22294087 1 0.0
Decreases (3 builds for cc13x2_26x2, esp32, psoc6)
platform target config section 3522317 75d73a2 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 165308 165300 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 490924 490916 -8 -0.0
.flash.rodata 247464 247456 -8 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26452059 26452058 -1 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 3522317 75d73a2 change % change
bl602 lighting-app bl602 (read/write) 1386190 1386190 0 0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052584 1052584 0 0.0
bl602+rpc (read/write) 1431846 1431846 0 0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084344 1084344 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675359 675359 0 0.0
(read/write) 176048 176048 0 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89215 89215 0 0.0
.text 585832 585832 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640071 640071 0 0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78367 78367 0 0.0
.text 561384 561384 0 0.0
lock-ftd LP_CC2652R7 (read only) 676411 676419 8 0.0
(read/write) 165308 165300 -8 -0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77067 77067 0 0.0
.text 598864 598872 8 0.0
lock-mtd LP_CC2652R7 (read only) 659379 659379 0 0.0
(read/write) 178028 178028 0 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102323 102323 0 0.0
.text 556576 556576 0 0.0
pump-app LP_CC2652R7 (read only) 685247 685247 0 0.0
(read/write) 157176 157176 0 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90079 90079 0 0.0
.text 594684 594684 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669739 669739 0 0.0
(read/write) 172796 172796 0 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85627 85627 0 0.0
.text 583632 583632 0 0.0
shell LP_CC2652R7 (read only) 666010 666010 0 0.0
(read/write) 180916 180916 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85770 85770 0 0.0
.text 579924 579924 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586882 586882 0 0.0
.app_xip_area 463540 463540 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592634 592634 0 0.0
.app_xip_area 464508 464508 0 0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599818 599818 0 0.0
.app_xip_area 477196 477196 0 0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108528 1108528 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970104 970104 0 0.0
BRD4161A+rpc (read/write) 972188 972188 0 0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819072 819072 0 0.0
BRD4161A+rs911x (read/write) 1002244 1002244 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830992 830992 0 0.0
lock-app BRD4161A+wf200 (read/write) 1150304 1150304 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995964 995964 0 0.0
window-app BRD4161A (read/write) 1099768 1099768 0 0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959880 959880 0 0.0
esp32 all-clusters-app c3devkit (read only) 1033912 1033912 0 0.0
(read/write) 1493646 1493646 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218160 218160 0 0.0
.flash.text 1033912 1033912 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086515 1086515 0 0.0
(read/write) 490924 490916 -8 -0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247464 247456 -8 -0.0
.flash.text 1081131 1081131 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648204 648204 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572696 572696 0 0.0
lock k32w0+release (read/write) 705216 705216 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629252 629252 0 0.0
linux all-clusters-app debug (read only) 3045113 3045113 0 0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275435 275435 0 0.0
.text 2590242 2590242 0 0.0
all-clusters-minimal-app debug (read only) 2880897 2880897 0 0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275595 275595 0 0.0
.text 2428642 2428642 0 0.0
bridge-app debug+rpc (read only) 2378681 2378681 0 0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204296 204296 0 0.0
.text 2011474 2011474 0 0.0
chip-tool debug (read only) 10944537 10944537 0 0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 569045 569045 0 0.0
.text 8854676 8854676 0 0.0
chip-tool-ipv6only arm64 (read only) 10319348 10319348 0 0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499300 499300 0 0.0
.text 8167636 8167636 0 0.0
lighting-app debug+rpc (read only) 2604105 2604105 0 0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221104 221104 0 0.0
.text 2211810 2211810 0 0.0
lock-app debug (read only) 2587105 2587105 0 0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238128 238128 0 0.0
.text 2182034 2182034 0 0.0
ota-provider-app debug (read only) 2364345 2364345 0 0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210104 210104 0 0.0
.text 1990482 1990482 0 0.0
ota-requestor-app debug (read only) 2529609 2529609 0 0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216832 216832 0 0.0
.text 2139874 2139874 0 0.0
shell debug (read only) 2613401 2613401 0 0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235538 235538 0 0.0
.text 2219154 2219154 0 0.0
thermostat-no-ble arm64 (read only) 2363012 2363012 0 0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141404 141404 0 0.0
.text 1983568 1983568 0 0.0
tv-app debug (read only) 3191689 3191689 0 0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260104 260104 0 0.0
.text 2741554 2741554 0 0.0
tv-casting-app debug (read only) 5510017 5510017 0 0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 345073 345073 0 0.0
.text 4893042 4893042 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455184 2455184 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417828 1417828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181087 0 0.0
bss 143641 143641 0 0.0
rodata 143504 143504 0 0.0
text 815004 815008 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160283 1160283 0 0.0
bss 142868 142868 0 0.0
rodata 135092 135092 0 0.0
text 803400 803400 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742748 1742748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221450 1221450 0 0.0
.debug_aranges 111728 111728 0 0.0
.debug_frame 372968 372968 0 0.0
.debug_info 26715435 26715435 0 0.0
.debug_line 3657402 3657402 0 0.0
.debug_loc 3573108 3573108 0 0.0
.debug_ranges 338424 338424 0 0.0
.debug_str 3427409 3427409 0 0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570588 570588 0 0.0
.symtab 421488 421488 0 0.0
.text 1542976 1542976 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685948 1685948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213289 1213289 0 0.0
.debug_aranges 111200 111200 0 0.0
.debug_frame 376048 376048 0 0.0
.debug_info 26452059 26452058 -1 -0.0
.debug_line 3677918 3677918 0 0.0
.debug_loc 3560745 3560745 0 0.0
.debug_ranges 337040 337040 0 0.0
.debug_str 3416414 3416414 0 0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535062 535062 0 0.0
.symtab 408080 408080 0 0.0
.text 1486912 1486912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603196 1603196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048108 1048108 0 0.0
.debug_aranges 103376 103376 0 0.0
.debug_frame 346316 346316 0 0.0
.debug_info 21914340 21914341 1 0.0
.debug_line 3248383 3248383 0 0.0
.debug_loc 3259088 3259088 0 0.0
.debug_ranges 302512 302512 0 0.0
.debug_str 3221680 3221680 0 0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468361 468361 0 0.0
.symtab 375168 375168 0 0.0
.text 1412392 1412392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640892 1640892 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055543 1055543 0 0.0
.debug_aranges 104048 104048 0 0.0
.debug_frame 349144 349144 0 0.0
.debug_info 22294086 22294087 1 0.0
.debug_line 3257204 3257204 0 0.0
.debug_loc 3298941 3298941 0 0.0
.debug_ranges 305856 305856 0 0.0
.debug_str 3249101 3249101 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474564 0 0.0
.symtab 378352 378352 0 0.0
.text 1445056 1445056 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129172 1129172 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576268 576268 0 0.0
lock-app qpg6105+debug (read/write) 1100184 1100184 0 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547284 547284 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 809004 809004 0 0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571480 571480 0 0.0
lighting-app tlsr9518adk80d (read/write) 830912 830912 0 0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589604 589604 0 0.0

@andy31415
Copy link
Contributor

Accepted for 1.0: platform specific change.

bzbarsky-apple
bzbarsky-apple approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, can this line in scripts/tests/chiptest/lsan-mac-suppressions.txt be removed?

:leak:[BleConnection initWithDiscriminator:]

src/platform/Darwin/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Darwin/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited
Loading

PR #22374: Size comparison from 3522317 to 948e38c

Increases (6 builds for cc13x2_26x2)
platform target config section 3522317 948e38c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 176048 176072 24 0.0
lock-ftd LP_CC2652R7 (read/write) 165308 165316 8 0.0
lock-mtd LP_CC2652R7 (read/write) 178028 178052 24 0.0
pump-app LP_CC2652R7 (read/write) 157176 157200 24 0.0
pump-controller-app LP_CC2652R7 (read/write) 172796 172820 24 0.0
shell LP_CC2652R7 (read/write) 180916 180940 24 0.0
Decreases (44 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
platform target config section 3522317 948e38c change % change
bl602 lighting-app bl602 (read/write) 1386190 1386174 -16 -0.0
.text 1052584 1052568 -16 -0.0
bl602+rpc (read/write) 1431846 1431822 -24 -0.0
.text 1084344 1084324 -20 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675359 675335 -24 -0.0
.text 585832 585808 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640071 640047 -24 -0.0
.text 561384 561360 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 676411 676403 -8 -0.0
.text 598864 598856 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 659379 659355 -24 -0.0
.text 556576 556552 -24 -0.0
pump-app LP_CC2652R7 (read only) 685247 685223 -24 -0.0
.text 594684 594660 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 669739 669715 -24 -0.0
.text 583632 583608 -24 -0.0
shell LP_CC2652R7 (read only) 666010 665986 -24 -0.0
.text 579924 579900 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586882 586866 -16 -0.0
.app_xip_area 463540 463524 -16 -0.0
lock cyw930739m2evb_01 (read/write) 592634 592610 -24 -0.0
.app_xip_area 464508 464484 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599818 599794 -24 -0.0
.app_xip_area 477196 477172 -24 -0.0
efr32 lighting-app BRD4161A (read/write) 1108528 1108512 -16 -0.0
.text 970104 970088 -16 -0.0
BRD4161A+rpc (read/write) 972188 972156 -32 -0.0
.text 819072 819040 -32 -0.0
BRD4161A+rs911x (read/write) 1002244 1002228 -16 -0.0
.text 830992 830976 -16 -0.0
lock-app BRD4161A+wf200 (read/write) 1150304 1150288 -16 -0.0
.text 995964 995948 -16 -0.0
window-app BRD4161A (read/write) 1099768 1099752 -16 -0.0
.text 959880 959864 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1033912 1033884 -28 -0.0
.flash.text 1033912 1033884 -28 -0.0
m5stack (read only) 1086515 1086503 -12 -0.0
(read/write) 490924 490916 -8 -0.0
.flash.rodata 247464 247456 -8 -0.0
.flash.text 1081131 1081119 -12 -0.0
k32w light k32w0+release (read/write) 648204 648188 -16 -0.0
.text 572696 572680 -16 -0.0
lock k32w0+release (read/write) 705216 705184 -32 -0.0
.text 629252 629220 -32 -0.0
linux all-clusters-app debug (read only) 3045113 3045065 -48 -0.0
.text 2590242 2590194 -48 -0.0
all-clusters-minimal-app debug (read only) 2880897 2880865 -32 -0.0
.text 2428642 2428610 -32 -0.0
bridge-app debug+rpc (read only) 2378681 2378665 -16 -0.0
.text 2011474 2011458 -16 -0.0
chip-tool debug (read only) 10944537 10944361 -176 -0.0
.text 8854676 8854500 -176 -0.0
chip-tool-ipv6only arm64 (read only) 10319348 1031920 -144 -0.0
.text 8167636 8167492 -144 -0.0
lighting-app debug+rpc (read only) 2604105 2604057 -48 -0.0
.text 2211810 2211762 -48 -0.0
lock-app debug (read only) 2587105 2587073 -32 -0.0
.text 2182034 2182002 -32 -0.0
ota-provider-app debug (read only) 2364345 2364313 -32 -0.0
.text 1990482 1990450 -32 -0.0
ota-requestor-app debug (read only) 2529609 2529561 -48 -0.0
.text 2139874 2139826 -48 -0.0
shell debug (read only) 2613401 2613369 -32 -0.0
.text 2219154 2219122 -32 -0.0
thermostat-no-ble arm64 (read only) 2363012 2362964 -48 -0.0
.text 1983568 1983520 -48 -0.0
tv-app debug (read only) 3191689 3191545 -144 -0.0
.text 2741554 2741410 -144 -0.0
tv-casting-app debug (read only) 5510017 5509873 -144 -0.0
.text 4893042 4892898 -144 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181055 -32 -0.0
text 815004 814976 -28 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160283 1160251 -32 -0.0
text 803400 803372 -28 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1742748 1742732 -16 -0.0
.debug_frame 372968 372964 -4 -0.0
.debug_info 26715435 26715280 -155 -0.0
.debug_line 3657402 3657380 -22 -0.0
.debug_loc 3573108 3573063 -45 -0.0
.debug_str 3427409 3427396 -13 -0.0
.strtab 570588 570587 -1 -0.0
.text 1542976 1542960 -16 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1685948 1685932 -16 -0.0
.debug_frame 376048 376044 -4 -0.0
.debug_info 26452059 26451904 -155 -0.0
.debug_line 3677918 3677896 -22 -0.0
.debug_loc 3560745 3560700 -45 -0.0
.debug_str 3416414 3416401 -13 -0.0
.strtab 535062 535061 -1 -0.0
.text 1486912 1486896 -16 -0.0
light cy8ckit_062s2_43012 (read/write) 1603196 1603180 -16 -0.0
.debug_frame 346316 346312 -4 -0.0
.debug_info 21914340 21914186 -154 -0.0
.debug_line 3248383 3248361 -22 -0.0
.debug_loc 3259088 3259042 -46 -0.0
.debug_str 3221680 3221667 -13 -0.0
.strtab 468361 468360 -1 -0.0
.text 1412392 1412376 -16 -0.0
lock cy8ckit_062s2_43012 (read/write) 1640892 1640876 -16 -0.0
.debug_frame 349144 349140 -4 -0.0
.debug_info 22294086 22293933 -153 -0.0
.debug_line 3257204 3257182 -22 -0.0
.debug_loc 3298941 3298895 -46 -0.0
.debug_str 3249101 3249088 -13 -0.0
.strtab 474564 474563 -1 -0.0
.text 1445056 1445040 -16 -0.0
qpg lighting-app qpg6105+debug (read/write) 1129172 1129140 -32 -0.0
.text 576268 576236 -32 -0.0
lock-app qpg6105+debug (read/write) 1100184 1100160 -24 -0.0
.text 547284 547260 -24 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 809004 808972 -32 -0.0
text 571480 571452 -28 -0.0
lighting-app tlsr9518adk80d (read/write) 830912 830888 -24 -0.0
text 589604 589576 -28 -0.0
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 3522317 948e38c change % change
bl602 lighting-app bl602 (read/write) 1386190 1386174 -16 -0.0
.bss 120298 120298 0 0.0
.data 4488 4488 0 0.0
.text 1052584 1052568 -16 -0.0
bl602+rpc (read/write) 1431846 1431822 -24 -0.0
.bss 127730 127730 0 0.0
.data 4600 4600 0 0.0
.text 1084344 1084324 -20 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675359 675335 -24 -0.0
(read/write) 176048 176072 24 0.0
.bss 74300 74300 0 0.0
.data 3380 3380 0 0.0
.rodata 89215 89215 0 0.0
.text 585832 585808 -24 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640071 640047 -24 -0.0
(read/write) 157868 157868 0 0.0
.bss 73572 73572 0 0.0
.data 3380 3380 0 0.0
.rodata 78367 78367 0 0.0
.text 561384 561360 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 676411 676403 -8 -0.0
(read/write) 165308 165316 8 0.0
.bss 71500 71500 0 0.0
.data 3304 3304 0 0.0
.rodata 77067 77067 0 0.0
.text 598864 598856 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 659379 659355 -24 -0.0
(read/write) 178028 178052 24 0.0
.bss 67188 67188 0 0.0
.data 3304 3304 0 0.0
.rodata 102323 102323 0 0.0
.text 556576 556552 -24 -0.0
pump-app LP_CC2652R7 (read only) 685247 685223 -24 -0.0
(read/write) 157176 157200 24 0.0
.bss 71436 71436 0 0.0
.data 3296 3296 0 0.0
.rodata 90079 90079 0 0.0
.text 594684 594660 -24 -0.0
pump-controller-app LP_CC2652R7 (read only) 669739 669715 -24 -0.0
(read/write) 172796 172820 24 0.0
.bss 71548 71548 0 0.0
.data 3292 3292 0 0.0
.rodata 85627 85627 0 0.0
.text 583632 583608 -24 -0.0
shell LP_CC2652R7 (read only) 666010 665986 -24 -0.0
(read/write) 180916 180940 24 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 85770 85770 0 0.0
.text 579924 579900 -24 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586882 586866 -16 -0.0
.app_xip_area 463540 463524 -16 -0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592634 592610 -24 -0.0
.app_xip_area 464508 464484 -24 -0.0
.bss 70560 70560 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599818 599794 -24 -0.0
.app_xip_area 477196 477172 -24 -0.0
.bss 65088 65088 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1108528 1108512 -16 -0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 970104 970088 -16 -0.0
BRD4161A+rpc (read/write) 972188 972156 -32 -0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 819072 819040 -32 -0.0
BRD4161A+rs911x (read/write) 1002244 1002228 -16 -0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 830992 830976 -16 -0.0
lock-app BRD4161A+wf200 (read/write) 1150304 1150288 -16 -0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 995964 995948 -16 -0.0
window-app BRD4161A (read/write) 1099768 1099752 -16 -0.0
.bss 137772 137772 0 0.0
.data 2096 2096 0 0.0
.text 959880 959864 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1033912 1033884 -28 -0.0
(read/write) 1493646 1493646 0 0.0
.dram0.bss 71120 71120 0 0.0
.dram0.data 13696 13696 0 0.0
.flash.rodata 218160 218160 0 0.0
.flash.text 1033912 1033884 -28 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1086515 1086503 -12 -0.0
(read/write) 490924 490916 -8 -0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 247464 247456 -8 -0.0
.flash.text 1081131 1081119 -12 -0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 648204 648188 -16 -0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 572696 572680 -16 -0.0
lock k32w0+release (read/write) 705216 705184 -32 -0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 629252 629220 -32 -0.0
linux all-clusters-app debug (read only) 3045113 3045065 -48 -0.0
(read/write) 156032 156032 0 0.0
.bss 61792 61792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85768 85768 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 275435 275435 0 0.0
.text 2590242 2590194 -48 -0.0
all-clusters-minimal-app debug (read only) 2880897 2880865 -32 -0.0
(read/write) 147632 147632 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 275595 275595 0 0.0
.text 2428642 2428610 -32 -0.0
bridge-app debug+rpc (read only) 2378681 2378665 -16 -0.0
(read/write) 127752 127752 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67640 67640 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 204296 204296 0 0.0
.text 2011474 2011458 -16 -0.0
chip-tool debug (read only) 10944537 10944361 -176 -0.0
(read/write) 657320 657320 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 622288 622288 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 569045 569045 0 0.0
.text 8854676 8854500 -176 -0.0
chip-tool-ipv6only arm64 (read only) 10319348 1031920 -144 -0.0
(read/write) 705169 705169 0 0.0
.bss 33297 33297 0 0.0
.data 3280 3280 0 0.0
.data.rel.ro 649784 649784 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 499300 499300 0 0.0
.text 8167636 8167492 -144 -0.0
lighting-app debug+rpc (read only) 2604105 2604057 -48 -0.0
(read/write) 130536 130536 0 0.0
.bss 49792 49792 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72680 72680 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 221104 221104 0 0.0
.text 2211810 2211762 -48 -0.0
lock-app debug (read only) 2587105 2587073 -32 -0.0
(read/write) 125712 125712 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69688 69688 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 238128 238128 0 0.0
.text 2182034 2182002 -32 -0.0
ota-provider-app debug (read only) 2364345 2364313 -32 -0.0
(read/write) 119144 119144 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63512 63512 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 210104 210104 0 0.0
.text 1990482 1990450 -32 -0.0
ota-requestor-app debug (read only) 2529609 2529561 -48 -0.0
(read/write) 127552 127552 0 0.0
.bss 50368 50368 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68920 68920 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 216832 216832 0 0.0
.text 2139874 2139826 -48 -0.0
shell debug (read only) 2613401 2613369 -32 -0.0
(read/write) 142184 142184 0 0.0
.bss 57704 57704 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77376 77376 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 235538 235538 0 0.0
.text 2219154 2219122 -32 -0.0
thermostat-no-ble arm64 (read only) 2363012 2362964 -48 -0.0
(read/write) 141857 141857 0 0.0
.bss 55233 55233 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 76112 76112 0 0.0
.dynamic 560 560 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 141404 141404 0 0.0
.text 1983568 1983520 -48 -0.0
tv-app debug (read only) 3191689 3191545 -144 -0.0
(read/write) 258040 258040 0 0.0
.bss 167352 167352 0 0.0
.data 4752 4752 0 0.0
.data.rel.ro 79368 79368 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 260104 260104 0 0.0
.text 2741554 2741410 -144 -0.0
tv-casting-app debug (read only) 5510017 5509873 -144 -0.0
(read/write) 160536 160536 0 0.0
.bss 51352 51352 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100304 100304 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 345073 345073 0 0.0
.text 4893042 4892898 -144 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455184 2455184 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1417828 1417828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1181087 1181055 -32 -0.0
bss 143641 143641 0 0.0
rodata 143504 143504 0 0.0
text 815004 814976 -28 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160283 1160251 -32 -0.0
bss 142868 142868 0 0.0
rodata 135092 135092 0 0.0
text 803400 803372 -28 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841960 841960 0 0.0
(read/write) 1742748 1742732 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188720 188720 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221450 1221450 0 0.0
.debug_aranges 111728 111728 0 0.0
.debug_frame 372968 372964 -4 -0.0
.debug_info 26715435 26715280 -155 -0.0
.debug_line 3657402 3657380 -22 -0.0
.debug_loc 3573108 3573063 -45 -0.0
.debug_ranges 338424 338424 0 0.0
.debug_str 3427409 3427396 -13 -0.0
.heap 841960 841960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570588 570587 -1 -0.0
.symtab 421488 421488 0 0.0
.text 1542976 1542960 -16 -0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842696 842696 0 0.0
(read/write) 1685948 1685932 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187984 187984 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1213289 1213289 0 0.0
.debug_aranges 111200 111200 0 0.0
.debug_frame 376048 376044 -4 -0.0
.debug_info 26452059 26451904 -155 -0.0
.debug_line 3677918 3677896 -22 -0.0
.debug_loc 3560745 3560700 -45 -0.0
.debug_ranges 337040 337040 0 0.0
.debug_str 3416414 3416401 -13 -0.0
.heap 842696 842696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535062 535061 -1 -0.0
.symtab 408080 408080 0 0.0
.text 1486912 1486896 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850928 850928 0 0.0
(read/write) 1603196 1603180 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179960 179960 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1048108 1048108 0 0.0
.debug_aranges 103376 103376 0 0.0
.debug_frame 346316 346312 -4 -0.0
.debug_info 21914340 21914186 -154 -0.0
.debug_line 3248383 3248361 -22 -0.0
.debug_loc 3259088 3259042 -46 -0.0
.debug_ranges 302512 302512 0 0.0
.debug_str 3221680 3221667 -13 -0.0
.heap 850928 850928 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 468361 468360 -1 -0.0
.symtab 375168 375168 0 0.0
.text 1412392 1412376 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640892 1640876 -16 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1055543 1055543 0 0.0
.debug_aranges 104048 104048 0 0.0
.debug_frame 349144 349140 -4 -0.0
.debug_info 22294086 22293933 -153 -0.0
.debug_line 3257204 3257182 -22 -0.0
.debug_loc 3298941 3298895 -46 -0.0
.debug_ranges 305856 305856 0 0.0
.debug_str 3249101 3249088 -13 -0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474564 474563 -1 -0.0
.symtab 378352 378352 0 0.0
.text 1445056 1445040 -16 -0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1129172 1129140 -32 -0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 576268 576236 -32 -0.0
lock-app qpg6105+debug (read/write) 1100184 1100160 -24 -0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 547284 547260 -24 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 809004 808972 -32 -0.0
bss 71344 71344 0 0.0
noinit 43488 43488 0 0.0
text 571480 571452 -28 -0.0
lighting-app tlsr9518adk80d (read/write) 830912 830888 -24 -0.0
bss 72200 72200 0 0.0
noinit 43488 43488 0 0.0
text 589604 589576 -28 -0.0

@bzbarsky-apple bzbarsky-apple merged commit ba8a495 into project-chip:master Sep 3, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@vivien-apple @bzbarsky-apple @isiu-apple
[darwin] ROOT LEAK: <chip::DeviceLayer::Internal::Ble*DelegateImpl (p…
36e3dd5 
…roject-chip#22374)

* [darwin] ROOT LEAK: <chip::DeviceLayer::Internal::Ble*DelegateImpl

* Apply suggestions from code review

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@vivien-apple vivien-apple

Labels
darwin platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @andy31415 @tcarmelveilleux @bzbarsky-apple