[Silabs] Update the efr32 Thermostat app #23408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
|
PR #23408: Size comparison from eeb4cdc to ead2cd9 Increases (13 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, linux, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
reviewed
Nov 2, 2022
andy31415
approved these changes
Nov 2, 2022
|
@andy31415 thank you Andrei, i will adress your comments once i am back from csa MM |
jepenven-silabs
approved these changes
Nov 11, 2022
…lable, add a LCD UI for thermostat
jmartinez-silabs
force-pushed
the
update_thermostat
branch
from
ead2cd9
to
7d27f1f
Compare
|
PR #23408: Size comparison from b87a86b to 7d27f1f Increases (9 builds for bl602, cc13x2_26x2, efr32, linux, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, linux, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Update the efr32 Thermostat app, Use the temperature sensor when available, add a LCD UI for thermostat * Address PR comments, Cleanup rebase and regen
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Update the efr32 Thermostat app, Use the temperature sensor when available, add a LCD UI for thermostat * Address PR comments, Cleanup rebase and regen
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Dec 19, 2022
Merge in WMN_TOOLS/matter from cherry-pick/9a41c9c3d97 to silabs_1.0
Squashed commit of the following:
commit a3d26430db3e4f5b7dc360625c96af0eccdc9005
Author: Junior Martinez <junior.martinez@silabs.com>
Date: Wed Nov 23 10:24:41 2022 -0500
update the zap file for this branch versions, add missing header in efr32_sdk.gni on this branch
commit 7c1b1657bec71351344afcaf14e8a06b43bcb8c0
Author: Junior Martinez <junior.martinez@silabs.com>
Date: Tue Nov 22 17:02:22 2022 -0500
regen zap config to match the zap version of this branch
commit e5b46dc0f3a45008e77ee43dc7411e29930a98cd
Author: jmartinez-silabs <67972863+jmartinez-silabs@users.noreply.github.com>
Date: Tue Nov 15 02:20:57 2022 +0100
[Silabs] Update the efr32 Thermostat app (project-chip#23408)
* Update the efr32 Thermostat app, Use the temperature sensor when available, add a LCD UI for thermostat
* Address PR comments, Cleanup rebase and regen
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Dec 19, 2022
Merge in WMN_TOOLS/matter from cherry-pick/9a41c9c3d97 to silabs_1.0
Squashed commit of the following:
commit a3d26430db3e4f5b7dc360625c96af0eccdc9005
Author: Junior Martinez <junior.martinez@silabs.com>
Date: Wed Nov 23 10:24:41 2022 -0500
update the zap file for this branch versions, add missing header in efr32_sdk.gni on this branch
commit 7c1b1657bec71351344afcaf14e8a06b43bcb8c0
Author: Junior Martinez <junior.martinez@silabs.com>
Date: Tue Nov 22 17:02:22 2022 -0500
regen zap config to match the zap version of this branch
commit e5b46dc0f3a45008e77ee43dc7411e29930a98cd
Author: jmartinez-silabs <67972863+jmartinez-silabs@users.noreply.github.com>
Date: Tue Nov 15 02:20:57 2022 +0100
[Silabs] Update the efr32 Thermostat app (project-chip#23408)
* Update the efr32 Thermostat app, Use the temperature sensor when available, add a LCD UI for thermostat
* Address PR comments, Cleanup rebase and regen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample thermostat for efr32 was really bare bones.
Update the application to better reflect what a matter thermostat can be.
Use the temperature sensor on silabs boards that have one available, else use an array of sampled temperatures.
Add UI on the LCD of the WSTK dev kits to show thermostat cluster information. (e.g Mode, Temperature, Set points.)
Enable the Thermostat User Interface Configuration cluster for better interopablitity with some Matter Controler hubs