Split DefaultStorageKeyAllocator into Keys and Allocator
#23422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rally const-safe and immutable
…e new format. Persisted counter is the only one remaining
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel and
lazarkov
|
PR #23422: Size comparison from 16f49ea to ce282f6 Increases above 0.2%:
Increases (31 builds for bl702, cc13x2_26x2, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (39 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 2, 2022
…| xargs sd '(\W)StorageKey(\W)' '${1}StorageKeyName${2}'\`
|
PR #23422: Size comparison from 5bf3e3f to b6ea150 Increases above 0.2%:
Increases (7 builds for bl702, linux, nrfconnect, telink)
Decreases (16 builds for bl702, k32w, linux, nrfconnect, qpg, telink)
Full report (16 builds for bl702, k32w, linux, nrfconnect, qpg, telink)
|
tcarmelveilleux
approved these changes
Nov 3, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…-chip#23422) * Separate out key allocation from storage keys. Make storage keys generally const-safe and immutable * Convert a lot of usage of default storage key allocator into using the new format. Persisted counter is the only one remaining * Fix some compilations * More compile fixes. Minmdns compiles * Restyle * Fix binding table test to compile * One more compile fix for tests * ran `rg '\WStorageKey\W' | grep -v third_party/ | cut -f1 -d: | uniq | xargs sd '(\W)StorageKey(\W)' '${1}StorageKeyName${2}'\` * Restyle * Also update StorageKey at the beginning of the line
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…-chip#23422) * Separate out key allocation from storage keys. Make storage keys generally const-safe and immutable * Convert a lot of usage of default storage key allocator into using the new format. Persisted counter is the only one remaining * Fix some compilations * More compile fixes. Minmdns compiles * Restyle * Fix binding table test to compile * One more compile fix for tests * ran `rg '\WStorageKey\W' | grep -v third_party/ | cut -f1 -d: | uniq | xargs sd '(\W)StorageKey(\W)' '${1}StorageKeyName${2}'\` * Restyle * Also update StorageKey at the beginning of the line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultStorageKeyAllocatoris a mutable object that is shared among different uses. This makes the api strange to use: you need to pass in an allocator that getssetand that value gets passed around. The same allocator may hold different values at different times.This changes to have a generally immutable
StorageKeyobject that is used for keys and the Allocator only allocates such keys.