Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add --skip-commissioning-complete optional parameter for … #23701

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[chip-tool] Add --skip-commissioning-complete optional parameter for … #23701

merged 1 commit into from
Dec 2, 2022

Conversation

vivien-apple
Copy link
Contributor

…non-concurrent connection use case

In non-concurrent commissioning flow, the commissioning-complete command is done over a different connection. There is not way to exercise this scenario using chip-tool at the moment (unless manually doing all the PASE session steps...).

This PR set the right boolean flag in CommissioningParameters so it can be done.

@vivien-apple vivien-apple self-assigned this Nov 21, 2022
@pullapprove pullapprove bot requested a review from msandstedt November 21, 2022 13:48
@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited
Loading

PR #23701: Size comparison from 494f5f5 to 2e8fd96

Increases (4 builds for cc13x2_26x2, cyw30739, esp32, linux)
platform target config section 494f5f5 2e8fd96 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 171808 171816 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588446 8 0.0
.app_xip_area 464648 464656 8 0.0
esp32 all-clusters-app c3devkit (read only) 1214664 1214666 2 0.0
.flash.text 1214664 1214666 2 0.0
linux chip-tool-ipv6only arm64 .rodata 519292 519308 16 0.0
Decreases (7 builds for cc13x2_26x2, linux, psoc6, telink)
platform target config section 494f5f5 2e8fd96 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 677295 677287 -8 -0.0
.text 599464 599456 -8 -0.0
linux chip-tool-ipv6only arm64 (read only) 10447340 10446396 -944 -0.0
.text 8269476 8268516 -960 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26758664 26758663 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22227200 22227199 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 792000 791992 -8 -0.0
text 555312 555308 -4 -0.0
lighting-app tlsr9518adk80d text 625626 625622 -4 -0.0
ota-requestor-app tlsr9518adk80d text 566672 566670 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 494f5f5 2e8fd96 change % change
bl602 lighting-app bl602 (read/write) 1377446 1377446 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1061182 1061182 0 0.0
bl602+rpc (read/write) 1423310 1423310 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1092656 1092656 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196999 1196999 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524244 1524244 0 0.0
.debug_aranges 132384 132384 0 0.0
.debug_frame 485640 485640 0 0.0
.debug_info 39158234 39158234 0 0.0
.debug_line 5276300 5276300 0 0.0
.debug_loc 3373203 3373203 0 0.0
.debug_ranges 361240 361240 0 0.0
.debug_str 3474842 3474842 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116680 116680 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568313 568313 0 0.0
.symtab 172032 172032 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957188 957188 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285539 1285539 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668414 1668414 0 0.0
.debug_aranges 140480 140480 0 0.0
.debug_frame 512976 512976 0 0.0
.debug_info 43429604 43429604 0 0.0
.debug_line 5673694 5673694 0 0.0
.debug_loc 3567814 3567814 0 0.0
.debug_ranges 384760 384760 0 0.0
.debug_str 3872439 3872439 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130424 130424 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628463 628463 0 0.0
.symtab 190176 190176 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031170 1031170 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679603 679603 0 0.0
(read/write) 171932 171932 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89923 89923 0 0.0
.text 589368 589368 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643859 643859 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79059 79059 0 0.0
.text 564480 564480 0 0.0
lock-ftd LP_CC2652R7 (read only) 677295 677287 -8 -0.0
(read/write) 171808 171816 8 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77351 77351 0 0.0
.text 599464 599456 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 661995 661995 0 0.0
(read/write) 182364 182364 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103435 103435 0 0.0
.text 558080 558080 0 0.0
pump-app LP_CC2652R7 (read only) 690167 690167 0 0.0
(read/write) 159672 159672 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90871 90871 0 0.0
.text 598812 598812 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674139 674139 0 0.0
(read/write) 175796 175796 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86427 86427 0 0.0
.text 587232 587232 0 0.0
shell LP_CC2652R7 (read only) 670822 670822 0 0.0
(read/write) 183032 183032 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86670 86670 0 0.0
.text 583836 583836 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588446 8 0.0
.app_xip_area 464648 464656 8 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592210 592210 0 0.0
.app_xip_area 463124 463124 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544810 544810 0 0.0
.app_xip_area 426540 426540 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975820 975820 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821372 821372 0 0.0
BRD4161A+rs911x (read/write) 1036720 1036720 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 847948 847948 0 0.0
BRD4187C (read/write) 1148544 1148544 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 982776 982776 0 0.0
lock-app BRD4161A+wf200 (read/write) 1161360 1161360 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1001052 1001052 0 0.0
window-app BRD4187C (read/write) 1141268 1141268 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974060 974060 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214664 1214666 2 0.0
(read/write) 1786670 1786670 0 0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256496 256496 0 0.0
.flash.text 1214664 1214666 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225427 1225427 0 0.0
(read/write) 562636 562636 0 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313608 313608 0 0.0
.flash.text 1220043 1220043 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662724 662724 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564396 564396 0 0.0
light k32w0+release (read/write) 673256 673256 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593556 593556 0 0.0
lock k32w0+release (read/write) 634284 634284 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553804 553804 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10447340 10446396 -944 -0.0
(read/write) 707697 707697 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 651984 651984 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519292 519308 16 0.0
.text 8269476 8268516 -960 -0.0
thermostat-no-ble arm64 (read only) 2387012 2387012 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145068 145068 0 0.0
.text 1998048 1998048 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453656 2453656 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1416300 1416300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1189583 1189583 0 0.0
bss 145285 145285 0 0.0
rodata 144804 144804 0 0.0
text 818414 818414 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1168963 1168963 0 0.0
bss 144512 144512 0 0.0
rodata 136592 136592 0 0.0
text 806932 806932 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748228 1748228 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235661 1235661 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371588 371588 0 0.0
.debug_info 27020981 27020981 0 0.0
.debug_line 3691677 3691677 0 0.0
.debug_loc 3616499 3616499 0 0.0
.debug_ranges 341008 341008 0 0.0
.debug_str 3444213 3444213 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571950 571950 0 0.0
.symtab 421904 421904 0 0.0
.text 1548464 1548464 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690748 1690748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227552 1227552 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374668 374668 0 0.0
.debug_info 26758664 26758663 -1 -0.0
.debug_line 3712661 3712661 0 0.0
.debug_loc 3604105 3604105 0 0.0
.debug_ranges 339624 339624 0 0.0
.debug_str 3433225 3433225 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536039 536039 0 0.0
.symtab 408336 408336 0 0.0
.text 1491720 1491720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1608924 1608924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062079 1062079 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 344980 344980 0 0.0
.debug_info 22227200 22227199 -1 -0.0
.debug_line 3281782 3281782 0 0.0
.debug_loc 3301540 3301540 0 0.0
.debug_ranges 304904 304904 0 0.0
.debug_str 3238811 3238811 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472364 472364 0 0.0
.symtab 376704 376704 0 0.0
.text 1418080 1418080 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642436 1642436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064054 1064054 0 0.0
.debug_aranges 102816 102816 0 0.0
.debug_frame 346832 346832 0 0.0
.debug_info 22446758 22446758 0 0.0
.debug_line 3276610 3276610 0 0.0
.debug_loc 3323117 3323117 0 0.0
.debug_ranges 306288 306288 0 0.0
.debug_str 3255068 3255068 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474151 474151 0 0.0
.symtab 378368 378368 0 0.0
.text 1446600 1446600 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152208 1152208 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 599308 599308 0 0.0
lock-app qpg6105+debug (read/write) 1117640 1117640 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 564736 564736 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939068 939068 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650282 650282 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 877036 877036 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614240 614240 0 0.0
light-switch-app tlsr9518adk80d (read/write) 792000 791992 -8 -0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555312 555308 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 876576 876576 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625626 625622 -4 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 806468 806468 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566672 566670 -2 -0.0

@vivien-apple vivien-apple force-pushed the ChipTool_SkipCommissioningComplete branch from 2e8fd96 to cbfee08 Compare December 2, 2022 15:22
@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

PR #23701: Size comparison from f9d9457 to cbfee08

Increases (8 builds for linux, nrfconnect, psoc6, qpg, telink)
platform target config section f9d9457 cbfee08 change % change
linux chip-tool debug .rodata 602085 602117 32 0.0
chip-tool-ipv6only arm64 .rodata 528364 528396 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 819844 819848 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22219814 22219815 1 0.0
qpg lock-app qpg6105+debug (read/write) 1116732 1116740 8 0.0
.text 563828 563836 8 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 704828 704830 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 966392 966400 8 0.0
text 662748 662750 2 0.0
thermostat tlsr9518adk80d text 650078 650080 2 0.0
Decreases (6 builds for bl602, bl702, esp32, linux, telink)
platform target config section f9d9457 cbfee08 change % change
bl602 lighting-app bl602 .text 1037744 1037742 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 43436133 43436132 -1 -0.0
.text 1029904 1029902 -2 -0.0
esp32 all-clusters-app m5stack (read/write) 564163 564159 -4 -0.0
.flash.rodata 314076 314072 -4 -0.0
linux chip-tool debug (read only) 11230801 11229473 -1328 -0.0
.text 9102228 9100868 -1360 -0.0
chip-tool-ipv6only arm64 (read only) 10605148 10604220 -928 -0.0
.text 8418276 8417316 -960 -0.0
telink lighting-app tlsr9518adk80d (read/write) 1035236 1035228 -8 -0.0
text 720050 720048 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section f9d9457 cbfee08 change % change
bl602 lighting-app bl602 (read/write) 1354990 1354990 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037744 1037742 -2 -0.0
bl602+rpc (read/write) 1400774 1400774 0 0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069162 1069162 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195407 1195407 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1526654 1526654 0 0.0
.debug_aranges 132448 132448 0 0.0
.debug_frame 485912 485912 0 0.0
.debug_info 39140238 39140238 0 0.0
.debug_line 5139542 5139542 0 0.0
.debug_loc 3373902 3373902 0 0.0
.debug_ranges 363496 363496 0 0.0
.debug_str 3472839 3472839 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116320 116320 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568431 568431 0 0.0
.symtab 171984 171984 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955966 955966 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283851 1283851 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1674812 1674812 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 513384 513384 0 0.0
.debug_info 43436133 43436132 -1 -0.0
.debug_line 5530557 5530557 0 0.0
.debug_loc 3568999 3568999 0 0.0
.debug_ranges 387064 387064 0 0.0
.debug_str 3875237 3875237 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130032 130032 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628653 628653 0 0.0
.symtab 190160 190160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029904 1029902 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679459 679459 0 0.0
(read/write) 172068 172068 0 0.0
.bss 81220 81220 0 0.0
.data 3380 3380 0 0.0
.rodata 89963 89963 0 0.0
.text 589184 589184 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643707 643707 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79099 79099 0 0.0
.text 564288 564288 0 0.0
lock-ftd LP_CC2652R7 (read only) 676999 676999 0 0.0
(read/write) 172096 172096 0 0.0
.bss 78876 78876 0 0.0
.data 3304 3304 0 0.0
.rodata 77391 77391 0 0.0
.text 599128 599128 0 0.0
lock-mtd LP_CC2652R7 (read only) 661787 661787 0 0.0
(read/write) 182564 182564 0 0.0
.bss 74132 74132 0 0.0
.data 3304 3304 0 0.0
.rodata 103475 103475 0 0.0
.text 557832 557832 0 0.0
pump-app LP_CC2652R7 (read only) 689927 689927 0 0.0
(read/write) 159904 159904 0 0.0
.bss 78844 78844 0 0.0
.data 3296 3296 0 0.0
.rodata 90911 90911 0 0.0
.text 598532 598532 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673835 673835 0 0.0
(read/write) 176100 176100 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86459 86459 0 0.0
.text 586896 586896 0 0.0
shell LP_CC2652R7 (read only) 670670 670670 0 0.0
(read/write) 183176 183176 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86710 86710 0 0.0
.text 583644 583644 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588326 588326 0 0.0
.app_xip_area 464584 464584 0 0.0
.bss 66200 66200 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592026 592026 0 0.0
.app_xip_area 462988 462988 0 0.0
.bss 71488 71488 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551506 551506 0 0.0
.app_xip_area 433268 433268 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976116 976116 0 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821676 821676 0 0.0
BRD4161A+rs911x (read/write) 1037616 1037616 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 848856 848856 0 0.0
BRD4187C (read/write) 1149188 1149188 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983428 983428 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163288 1163288 0 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1002952 1002952 0 0.0
window-app BRD4187C (read/write) 1141720 1141720 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974520 974520 0 0.0
esp32 all-clusters-app c3devkit (read only) 1218690 1218690 0 0.0
(read/write) 1790922 1790922 0 0.0
.dram0.bss 76984 76984 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248280 248280 0 0.0
.flash.text 1218690 1218690 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1232843 1232843 0 0.0
(read/write) 564163 564159 -4 -0.0
.dram0.bss 82144 82144 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314076 314072 -4 -0.0
.flash.text 1227459 1227459 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662516 662516 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564188 564188 0 0.0
light k32w0+release (read/write) 673080 673080 0 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593388 593388 0 0.0
lock k32w0+release (read/write) 634036 634036 0 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553564 553564 0 0.0
linux all-clusters-app debug (read only) 3111225 3111225 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2645506 2645506 0 0.0
all-clusters-minimal-app debug (read only) 2934905 2934905 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2472770 2472770 0 0.0
bridge-app debug+rpc (read only) 2427489 2427489 0 0.0
(read/write) 129576 129576 0 0.0
.bss 50976 50976 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210848 210848 0 0.0
.text 2049282 2049282 0 0.0
chip-tool debug (read only) 11230801 11229473 -1328 -0.0
(read/write) 659648 659648 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624384 624384 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 602085 602117 32 0.0
.text 9102228 9100868 -1360 -0.0
chip-tool-ipv6only arm64 (read only) 10605148 10604220 -928 -0.0
(read/write) 707729 707729 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652040 652040 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 528364 528396 32 0.0
.text 8418276 8417316 -960 -0.0
lighting-app debug+rpc (read only) 2661073 2661073 0 0.0
(read/write) 132328 132328 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2256674 2256674 0 0.0
lock-app debug (read only) 2620105 2620105 0 0.0
(read/write) 127344 127344 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2204290 2204290 0 0.0
ota-provider-app debug (read only) 2412401 2412401 0 0.0
(read/write) 120872 120872 0 0.0
.bss 47904 47904 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216552 216552 0 0.0
.text 2027298 2027298 0 0.0
ota-requestor-app debug (read only) 2580961 2580961 0 0.0
(read/write) 129216 129216 0 0.0
.bss 50432 50432 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223600 223600 0 0.0
.text 2179714 2179714 0 0.0
shell debug (read only) 2643681 2643681 0 0.0
(read/write) 142936 142936 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2244690 2244690 0 0.0
thermostat-no-ble arm64 (read only) 2421980 2421980 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033168 2033168 0 0.0
tv-app debug (read only) 3283025 3283025 0 0.0
(read/write) 262120 262120 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2820658 2820658 0 0.0
tv-casting-app debug (read only) 5623321 5623321 0 0.0
(read/write) 162048 162048 0 0.0
.bss 52088 52088 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101408 101408 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355833 355833 0 0.0
.text 4991362 4991362 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463328 2463328 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1425972 1425972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190747 1190747 0 0.0
bss 145285 145285 0 0.0
rodata 144448 144448 0 0.0
text 819844 819848 4 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360874 1360874 0 0.0
bss 105224 105224 0 0.0
rodata 211552 211552 0 0.0
text 759606 759606 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136391 1136391 0 0.0
bss 144520 144520 0 0.0
rodata 120764 120764 0 0.0
text 790016 790016 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1748412 1748412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238033 1238033 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371612 371612 0 0.0
.debug_info 27007603 27007603 0 0.0
.debug_line 3704191 3704191 0 0.0
.debug_loc 3616351 3616351 0 0.0
.debug_ranges 345536 345536 0 0.0
.debug_str 3442381 3442381 0 0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571557 571557 0 0.0
.symtab 421952 421952 0 0.0
.text 1548656 1548656 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690940 1690940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229924 1229924 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374668 374668 0 0.0
.debug_info 26745246 26745246 0 0.0
.debug_line 3723128 3723128 0 0.0
.debug_loc 3603957 3603957 0 0.0
.debug_ranges 344152 344152 0 0.0
.debug_str 3431393 3431393 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535646 535646 0 0.0
.symtab 408384 408384 0 0.0
.text 1491912 1491912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609132 1609132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064721 1064721 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 345004 345004 0 0.0
.debug_info 22219814 22219815 1 0.0
.debug_line 3290452 3290452 0 0.0
.debug_loc 3301819 3301819 0 0.0
.debug_ranges 308288 308288 0 0.0
.debug_str 3236979 3236979 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471971 471971 0 0.0
.symtab 376752 376752 0 0.0
.text 1418296 1418296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1642572 1642572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066637 1066637 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346800 346800 0 0.0
.debug_info 22438317 22438317 0 0.0
.debug_line 3290203 3290203 0 0.0
.debug_loc 3323247 3323247 0 0.0
.debug_ranges 310144 310144 0 0.0
.debug_str 3252822 3252822 0 0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473633 473633 0 0.0
.symtab 378352 378352 0 0.0
.text 1446744 1446744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150868 1150868 0 0.0
.bss 97620 97620 0 0.0
.data 840 840 0 0.0
.text 597968 597968 0 0.0
lock-app qpg6105+debug (read/write) 1116732 1116740 8 0.0
.bss 93092 93092 0 0.0
.data 836 836 0 0.0
.text 563828 563836 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092516 1092516 0 0.0
bss 99808 99808 0 0.0
text 739666 739666 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1031692 1031692 0 0.0
bss 99032 99032 0 0.0
text 704828 704830 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953280 953280 0 0.0
bss 91272 91272 0 0.0
text 651454 651454 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1035236 1035228 -8 -0.0
bss 100420 100420 0 0.0
text 720050 720048 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 966392 966400 8 0.0
bss 92228 92228 0 0.0
text 662748 662750 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 954028 954028 0 0.0
bss 92664 92664 0 0.0
text 650078 650080 2 0.0

@vivien-apple vivien-apple merged commit 35422eb into project-chip:master Dec 2, 2022
@wqx6
Copy link
Contributor

wqx6 commented Dec 15, 2022

@vivien-apple Hi, Vivien, I am confused of this.

In non-concurrent commissioning flow, the commissioning-complete command is done over a different connection.

But in SPEC, the commissioning-complete command is sent over the operational network in both concurrent and non-concurrent commissioning flow.

@vivien-apple
Copy link
Contributor Author

@vivien-apple Hi, Vivien, I am confused of this.

In non-concurrent commissioning flow, the commissioning-complete command is done over a different connection.

But in SPEC, the commissioning-complete command is sent over the operational network in both concurrent and non-concurrent commissioning flow.

This is correct. The commissioning-complete command is sent over the operational network in both concurrent and non-concurrent commissioning flow.
That said, the commissioning-complete command may be sent by a different node. Without this patch the commissioner node was always the one sending commissioning-complete. While this patch allows to stop at step 12 of the commissioning flow, and then open a CASE connection from a different node over the operational network before sending the commissioning-complete command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees

@vivien-apple vivien-apple

Labels
examples fast track review - pending tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @wqx6 @andy31415 @bzbarsky-apple