-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Allow use of certifcates stored on the HDD for factory data #24274
Merged
Damian-Nordic
merged 3 commits into
project-chip:master
from
deveritec-rosc:fd_nordic_hdd_certs
Jan 6, 2023
Merged
[nrfconnect] Allow use of certifcates stored on the HDD for factory data #24274
Damian-Nordic
merged 3 commits into
project-chip:master
from
deveritec-rosc:fd_nordic_hdd_certs
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… factory data Instead of just allow usage for the default certificates or certificates generated on demand also add the possibility to use certificates already located on the HDD. This makes it easier to use generated test DCL certificates.
PR #24274: Size comparison from 5f3dda9 to 729f00b Increases (12 builds for bl602, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for efr32, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Signed-off-by: Robert Schulze <robert.schulze@deveritec.com>
Damian-Nordic
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the indentation issue, lgtm. Thanks!
bzbarsky-apple
approved these changes
Jan 5, 2023
PR #24274: Size comparison from 08e1711 to 7ab7072 Increases (9 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702, cc13x2_26x2, esp32, k32w, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Signed-off-by: Robert Schulze <robert.schulze@deveritec.com>
PR #24274: Size comparison from 08e1711 to 5d3d3a3 Increases (9 builds for bl602, bl702, esp32, psoc6)
Decreases (20 builds for bl702, esp32, nrfconnect, qpg, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ata (project-chip#24274) * [nrfconnect] Allow use of certifcates stored somewhere on the HDD for factory data Instead of just allow usage for the default certificates or certificates generated on demand also add the possibility to use certificates already located on the HDD. This makes it easier to use generated test DCL certificates. * [nrfconnect] Rename options and provide help string Signed-off-by: Robert Schulze <robert.schulze@deveritec.com> * [nrfconnect] fix indententaion error in Kconfig Signed-off-by: Robert Schulze <robert.schulze@deveritec.com> Signed-off-by: Robert Schulze <robert.schulze@deveritec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation only allows to use either
This commit also add the possibility to use certificates already located on the HDD.
It makes it easier to use certificates and keys generated based on the test DCL.