-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ballast configuration cluster in all-clusters-app #24517
Merged
bzbarsky-apple
merged 7 commits into
project-chip:master
from
markus-becker-tridonic-com:enable-ballast-configuration-in-all-clusters-app
Jan 23, 2023
Merged
Enable ballast configuration cluster in all-clusters-app #24517
bzbarsky-apple
merged 7 commits into
project-chip:master
from
markus-becker-tridonic-com:enable-ballast-configuration-in-all-clusters-app
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24517: Size comparison from 8ad1073 to e0c1859 Increases (17 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 19, 2023
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
markus-becker-tridonic-com
force-pushed
the
enable-ballast-configuration-in-all-clusters-app
branch
2 times, most recently
from
January 19, 2023 14:46
d959909
to
a562810
Compare
markus-becker-tridonic-com
changed the title
Draft: Enable ballast configuration cluster in all-clusters-app
Enable ballast configuration cluster in all-clusters-app
Jan 19, 2023
pullapprove
bot
requested review from
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google and
mrjerryjohns
January 19, 2023 14:47
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
xylophone21 and
yunhanw-google
January 19, 2023 14:47
PR #24517: Size comparison from 3c0c875 to a562810 Increases above 0.2%:
Increases (13 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect)
Decreases (4 builds for bl702, cc13x2_26x2)
Full report (37 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, k32w, linux, nrfconnect)
|
andy31415
reviewed
Jan 19, 2023
andy31415
approved these changes
Jan 19, 2023
markus-becker-tridonic-com
force-pushed
the
enable-ballast-configuration-in-all-clusters-app
branch
from
January 20, 2023 07:57
a562810
to
2cf0ff7
Compare
Added comments on the attribute sets of Ballast Configuration cluster and deprecated attributes. Some automated whitespace corrections.
markus-becker-tridonic-com
force-pushed
the
enable-ballast-configuration-in-all-clusters-app
branch
from
January 20, 2023 08:53
1a08503
to
0c345ba
Compare
PR #24517: Size comparison from cbc8fc4 to 04b30cc Increases above 0.2%:
Increases (22 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, k32w, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Jan 20, 2023
@markus-becker-tridonic-com If you get a chance to merge markus-becker-tridonic-com#1 into this PR before it merges to master, that would be great. If not, just let me know and I will do that as a followup. |
Handle the attribute rename correctly in Darwin APIs.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…p#24517) * Correct attribute name IntrinsicBallastFactor. Added comments on the attribute sets of Ballast Configuration cluster and deprecated attributes. Some automated whitespace corrections. * Enable BallastConfiguration cluster in all-cluster-app * Add cluster init function for BallastConfiguration * Regenerate generated code. * fix codegen clang-format * Handle the attribute rename correctly in Darwin APIs. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ballast Configuration cluster was available in the data model XML, but wasn't enabled in any example app. controller-app has the client side already enabled.