-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos various tests with yaml tests parser attempt3 #24599
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Typos_VariousTestsWithYamlTestsParser_attempt3
Jan 24, 2023
Merged
Typos various tests with yaml tests parser attempt3 #24599
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Typos_VariousTestsWithYamlTestsParser_attempt3
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt3
branch
from
January 23, 2023 21:20
908fac0
to
29b83e6
Compare
bzbarsky-apple
approved these changes
Jan 23, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
pjzander-signify
January 23, 2023 21:20
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
xylophone21,
yufengwangca and
yunhanw-google
January 23, 2023 21:20
andy31415
approved these changes
Jan 23, 2023
PR #24599: Size comparison from ec03137 to 29b83e6 Increases (2 builds for bl702, telink)
Decreases (10 builds for bl702, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
approved these changes
Jan 24, 2023
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt3
branch
from
January 24, 2023 08:36
29b83e6
to
2e79eb1
Compare
PR #24599: Size comparison from d15be4c to 2e79eb1 Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (11 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt3
branch
from
January 24, 2023 10:09
2e79eb1
to
a361512
Compare
PR #24599: Size comparison from d15be4c to a361512 Increases (3 builds for bl602, cc13x2_26x2)
Decreases (9 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Jan 24, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [matter_yamltests] Make definitions.py more strict about casing * Fix various typos in src/app/tests/suites/ yaml tests (project-chip#3 attempt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The various typos in the written YAML tests force the parser to be less strict and reduce the consistency of the test suite. This PR fix a bunch of them and removes some
lower()
calls from the parser.