Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks in MTRAsyncCallbackQueueWorkItem. #24817

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix memory leaks in MTRAsyncCallbackQueueWorkItem. #24817

merged 1 commit into from
Feb 2, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

The item API pretty much requires a readyHandler that holds a reference to the item. Instead of assuming all consumers use __weak correctly to hold that reference, manually break cycles in MTRAsyncCallbackQueueWorkItem.

@bzbarsky-apple
Fix memory leaks in MTRAsyncCallbackQueueWorkItem.
1dea9a9 
The item API pretty much requires a readyHandler that holds a reference to the
item.  Instead of assuming all consumers use __weak correctly to hold that
reference, manually break cycles in MTRAsyncCallbackQueueWorkItem.
@github-actions github-actions bot added the darwin label Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited
Loading

PR #24817: Size comparison from 94c7f68 to 1dea9a9

Increases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
platform target config section 94c7f68 1dea9a9 change % change
bl602 lighting-app bl602+rpc (read/write) 1390898 1390906 8 0.0
.text 1053448 1053450 2 0.0
bl702 lighting-app bl702 .debug_info 40210594 40210595 1 0.0
.text 951806 951808 2 0.0
bl702+rpc (read/write) 1276383 1276399 16 0.0
.debug_info 44607076 44607077 1 0.0
.text 1028832 1028834 2 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660507 660515 8 0.0
.text 557240 557248 8 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 763844 763848 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27076091 27076092 1 0.0
light cy8ckit_062s2_43012 .debug_info 22500527 22500528 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22724313 22724314 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 952184 952192 8 0.0
text 648044 648046 2 0.0
light-switch-app tlsr9518adk80d text 593070 593072 2 0.0
lighting-app tlsr9518adk80d text 658466 658468 2 0.0
ota-requestor-app tlsr9518adk80d text 604438 604440 2 0.0
thermostat tlsr9518adk80d text 594648 594650 2 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 94c7f68 1dea9a9 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183316 183308 -8 -0.0
telink all-clusters-app tlsr9518adk80d text 685750 685748 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 94c7f68 1dea9a9 change % change
bl602 lighting-app bl602 (read/write) 1345714 1345714 0 0.0
.bss 94826 94826 0 0.0
.data 9736 9736 0 0.0
.text 1022772 1022772 0 0.0
bl602+rpc (read/write) 1390898 1390906 8 0.0
.bss 102874 102874 0 0.0
.data 10128 10128 0 0.0
.text 1053448 1053450 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183691 1183691 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550344 1550344 0 0.0
.debug_aranges 134104 134104 0 0.0
.debug_frame 491108 491108 0 0.0
.debug_info 40210594 40210595 1 0.0
.debug_line 5266876 5266876 0 0.0
.debug_loc 3400982 3400982 0 0.0
.debug_ranges 371752 371752 0 0.0
.debug_str 3535301 3535301 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106768 106768 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572034 572034 0 0.0
.symtab 173280 173280 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951806 951808 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276383 1276399 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698758 1698758 0 0.0
.debug_aranges 142328 142328 0 0.0
.debug_frame 518812 518812 0 0.0
.debug_info 44607076 44607077 1 0.0
.debug_line 5665344 5665344 0 0.0
.debug_loc 3597273 3597273 0 0.0
.debug_ranges 395456 395456 0 0.0
.debug_str 3938539 3938539 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121312 121312 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632631 632631 0 0.0
.symtab 191632 191632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028832 1028834 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677095 677095 0 0.0
(read/write) 174120 174120 0 0.0
.bss 80908 80908 0 0.0
.data 3384 3384 0 0.0
.rodata 87527 87527 0 0.0
.text 589252 589252 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641103 641103 0 0.0
(read/write) 157600 157600 0 0.0
.bss 80100 80100 0 0.0
.data 3384 3384 0 0.0
.rodata 77479 77479 0 0.0
.text 563304 563304 0 0.0
lock-ftd LP_CC2652R7 (read only) 674171 674171 0 0.0
(read/write) 174388 174388 0 0.0
.bss 78340 78340 0 0.0
.data 3312 3312 0 0.0
.rodata 76323 76323 0 0.0
.text 597368 597368 0 0.0
lock-mtd LP_CC2652R7 (read only) 660507 660515 8 0.0
(read/write) 183316 183308 -8 -0.0
.bss 73604 73604 0 0.0
.data 3312 3312 0 0.0
.rodata 102787 102787 0 0.0
.text 557240 557248 8 0.0
pump-app LP_CC2652R7 (read only) 687071 687071 0 0.0
(read/write) 162224 162224 0 0.0
.bss 78308 78308 0 0.0
.data 3276 3276 0 0.0
.rodata 90447 90447 0 0.0
.text 596144 596144 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672495 672495 0 0.0
(read/write) 176912 176912 0 0.0
.bss 78420 78420 0 0.0
.data 3300 3300 0 0.0
.rodata 86527 86527 0 0.0
.text 585488 585488 0 0.0
shell LP_CC2652R7 (read only) 668350 668350 0 0.0
(read/write) 184936 184936 0 0.0
.bss 82980 82980 0 0.0
.data 3380 3380 0 0.0
.rodata 84262 84262 0 0.0
.text 583776 583776 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584042 584042 0 0.0
.app_xip_area 460828 460828 0 0.0
.bss 65664 65664 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587894 587894 0 0.0
.app_xip_area 459384 459384 0 0.0
.bss 70952 70952 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549546 549546 0 0.0
.app_xip_area 431812 431812 0 0.0
.bss 60224 60224 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037792 1037792 0 0.0
.bss 181592 181592 0 0.0
.data 2044 2044 0 0.0
.text 854132 854132 0 0.0
BRD4187C (read/write) 1151080 1151080 0 0.0
.bss 132888 132888 0 0.0
.data 2544 2544 0 0.0
.text 991052 991052 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065536 1065536 0 0.0
.bss 153120 153120 0 0.0
.data 2052 2052 0 0.0
.text 910344 910344 0 0.0
window-app BRD4187C (read/write) 1145972 1145972 0 0.0
.bss 134392 134392 0 0.0
.data 2572 2572 0 0.0
.text 984412 984412 0 0.0
esp32 all-clusters-app c3devkit (read only) 1046984 1046984 0 0.0
(read/write) 1518658 1518658 0 0.0
.dram0.bss 77992 77992 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220648 220648 0 0.0
.flash.text 1046984 1046984 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1098807 1098807 0 0.0
(read/write) 500287 500287 0 0.0
.dram0.bss 83040 83040 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 249404 249404 0 0.0
.flash.text 1093423 1093423 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659592 659592 0 0.0
.bss 76592 76592 0 0.0
.data 2112 2112 0 0.0
.text 561776 561776 0 0.0
light k32w0+release (read/write) 671564 671564 0 0.0
.bss 74376 74376 0 0.0
.data 2064 2064 0 0.0
.text 592396 592396 0 0.0
lock k32w0+release (read/write) 631068 631068 0 0.0
.bss 75144 75144 0 0.0
.data 2084 2084 0 0.0
.text 551112 551112 0 0.0
linux all-clusters-app debug (read only) 3156321 3156321 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283851 283851 0 0.0
.text 2686978 2686978 0 0.0
all-clusters-minimal-app debug (read only) 2972273 2972273 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282539 282539 0 0.0
.text 2507570 2507570 0 0.0
bridge-app debug (read only) 2525473 2525473 0 0.0
(read/write) 132352 132352 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68968 68968 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 214048 214048 0 0.0
.text 2138962 2138962 0 0.0
chip-tool debug (read only) 11643265 11643265 0 0.0
(read/write) 655568 655568 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619512 619512 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 651301 651301 0 0.0
.text 9468660 9468660 0 0.0
chip-tool-ipv6only arm64 (read only) 11040332 11040332 0 0.0
(read/write) 704920 704920 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648336 648336 0 0.0
.dynamic 560 560 0 0.0
.got 14128 14128 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 577084 577084 0 0.0
.text 8789956 8789956 0 0.0
lighting-app debug+rpc (read only) 2693097 2693097 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229984 229984 0 0.0
.text 2285682 2285682 0 0.0
lock-app debug (read only) 2656417 2656417 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246280 246280 0 0.0
.text 2237554 2237554 0 0.0
ota-provider-app debug (read only) 2225945 2225945 0 0.0
(read/write) 106512 106512 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51608 51608 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197576 197576 0 0.0
.text 1887778 1887778 0 0.0
ota-requestor-app debug (read only) 2387441 2387441 0 0.0
(read/write) 114240 114240 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56376 56376 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204528 204528 0 0.0
.text 2033298 2033298 0 0.0
shell debug (read only) 2685769 2685769 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73136 73136 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241938 241938 0 0.0
.text 2283314 2283314 0 0.0
thermostat-no-ble arm64 (read only) 2507500 2507500 0 0.0
(read/write) 144712 144712 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76992 76992 0 0.0
.dynamic 560 560 0 0.0
.got 5400 5400 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2094720 2094720 0 0.0
tv-app debug (read only) 3315609 3315609 0 0.0
(read/write) 259632 259632 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270648 270648 0 0.0
.text 2850162 2850162 0 0.0
tv-casting-app debug (read only) 5700961 5700961 0 0.0
(read/write) 164632 164632 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102568 102568 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365428 365428 0 0.0
.text 5049842 5049842 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463640 2463640 0 0.0
.bss 215924 215924 0 0.0
.data 5880 5880 0 0.0
.text 1426284 1426284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160972 1160972 0 0.0
bss 143563 143563 0 0.0
rodata 133448 133448 0 0.0
text 804108 804108 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366240 1366240 0 0.0
bss 106022 106022 0 0.0
rodata 210880 210880 0 0.0
text 763844 763848 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107156 1107156 0 0.0
bss 142719 142719 0 0.0
rodata 110592 110592 0 0.0
text 774104 774104 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840840 840840 0 0.0
(read/write) 1756012 1756012 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189832 189832 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251867 1251867 0 0.0
.debug_aranges 111368 111368 0 0.0
.debug_frame 373856 373856 0 0.0
.debug_info 27520219 27520219 0 0.0
.debug_line 3780152 3780152 0 0.0
.debug_loc 3674912 3674912 0 0.0
.debug_ranges 362408 362408 0 0.0
.debug_str 3486134 3486134 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577911 577911 0 0.0
.symtab 424736 424736 0 0.0
.text 0 0 0 0.0
1555120 1555120 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841656 841656 0 0.0
(read/write) 1697796 1697796 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189024 189024 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237538 1237538 0 0.0
.debug_aranges 110632 110632 0 0.0
.debug_frame 376300 376300 0 0.0
.debug_info 27076091 27076092 1 0.0
.debug_line 3788498 3788498 0 0.0
.debug_loc 3658642 3658642 0 0.0
.debug_ranges 360376 360376 0 0.0
.debug_str 3471887 3471887 0 0.0
.heap 841656 841656 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539119 539119 0 0.0
.symtab 410016 410016 0 0.0
.text 1497720 1497720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849976 849976 0 0.0
(read/write) 1611332 1611332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180904 180904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071872 1071872 0 0.0
.debug_aranges 102840 102840 0 0.0
.debug_frame 346744 346744 0 0.0
.debug_info 22500527 22500528 1 0.0
.debug_line 3340931 3340931 0 0.0
.debug_loc 3336889 3336889 0 0.0
.debug_ranges 319552 319552 0 0.0
.debug_str 3275133 3275133 0 0.0
.heap 849976 849976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474324 474324 0 0.0
.symtab 377792 377792 0 0.0
.text 1419576 1419576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844992 844992 0 0.0
(read/write) 1645484 1645484 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185880 185880 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073576 1073576 0 0.0
.debug_aranges 103280 103280 0 0.0
.debug_frame 348676 348676 0 0.0
.debug_info 22724313 22724314 1 0.0
.debug_line 3342771 3342771 0 0.0
.debug_loc 3359550 3359550 0 0.0
.debug_ranges 321464 321464 0 0.0
.debug_str 3292359 3292359 0 0.0
.heap 844992 844992 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477700 477700 0 0.0
.symtab 379952 379952 0 0.0
.text 1448744 1448744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147860 1147860 0 0.0
.bss 99908 99908 0 0.0
.data 848 848 0 0.0
.text 594960 594960 0 0.0
lock-app qpg6105+debug (read/write) 1115732 1115732 0 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 562828 562828 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015636 1015636 0 0.0
bss 98012 98012 0 0.0
text 685750 685748 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952184 952192 8 0.0
bss 97060 97060 0 0.0
text 648044 648046 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857616 857616 0 0.0
bss 89184 89184 0 0.0
text 579026 579026 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873316 873316 0 0.0
bss 89272 89272 0 0.0
text 593070 593072 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950632 950632 0 0.0
bss 97420 97420 0 0.0
text 658466 658468 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887476 887476 0 0.0
bss 90220 90220 0 0.0
text 604438 604440 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877524 877524 0 0.0
bss 90660 90660 0 0.0
text 594648 594650 2 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit c3a5b9e into project-chip:master Feb 2, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-work-item-leaks branch February 2, 2023 17:52
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Fix memory leaks in MTRAsyncCallbackQueueWorkItem. (project-chip#24817)
f2a8fc4 
The item API pretty much requires a readyHandler that holds a reference to the
item.  Instead of assuming all consumers use __weak correctly to hold that
reference, manually break cycles in MTRAsyncCallbackQueueWorkItem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @jtung-apple