-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some building issues with src/darwin/Framework #24922
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFramework_BuildFailures
Feb 9, 2023
Merged
Fix some building issues with src/darwin/Framework #24922
yufengwangca
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFramework_BuildFailures
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 8, 2023 17:27
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 8, 2023 17:27
PR #24922: Size comparison from c49ee00 to 34f10c3 Increases (3 builds for bl602, bl702, cc32xx)
Decreases (1 build for qpg)
Full report (11 builds for bl602, bl702, cc32xx, k32w, mbed, qpg)
|
vivien-apple
force-pushed
the
DarwinFramework_BuildFailures
branch
from
February 8, 2023 18:29
34f10c3
to
43afa63
Compare
bzbarsky-apple
approved these changes
Feb 8, 2023
yufengwangca
approved these changes
Feb 9, 2023
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Feb 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While building the darwin framework with some local config I got some build issues. Those are the fixes that got the build to succeeds for me.