Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More light UI - ability to test HS color control in a virual manner #25065

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

andy31415
Copy link
Contributor

Updated some UI elements:

  • better indent
  • brightness switched to a slider
  • big yellow light on/off display
  • big color display for HS color

image

@github-actions
Copy link

PR #25065: Size comparison from a6d2883 to b5510ab

Increases (3 builds for bl602, bl702)
platform target config section a6d2883 b5510ab change % change
bl602 lighting-app bl602 .text 1023524 1023526 2 0.0
bl602+rpc .text 1054458 1054460 2 0.0
bl702 lighting-app bl702 .debug_info 40624236 40624238 2 0.0
.text 952920 952924 4 0.0
Decreases (1 build for bl702)
platform target config section a6d2883 b5510ab change % change
bl702 lighting-app bl702+rpc .debug_info 45033171 45033170 -1 -0.0
.text 1030320 1030318 -2 -0.0
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
platform target config section a6d2883 b5510ab change % change
bl602 lighting-app bl602 (read/write) 1347010 1347010 0 0.0
.bss 94810 94810 0 0.0
.data 9736 9736 0 0.0
.text 1023524 1023526 2 0.0
bl602+rpc (read/write) 1392458 1392458 0 0.0
.bss 102858 102858 0 0.0
.data 10128 10128 0 0.0
.text 1054458 1054460 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185363 1185363 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69913 69913 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1551885 1551885 0 0.0
.debug_aranges 134280 134280 0 0.0
.debug_frame 491764 491764 0 0.0
.debug_info 40624236 40624238 2 0.0
.debug_line 5277493 5277493 0 0.0
.debug_loc 3409452 3409452 0 0.0
.debug_ranges 371744 371744 0 0.0
.debug_str 3559730 3559730 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107328 107328 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572957 572957 0 0.0
.symtab 173536 173536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 952920 952924 4 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1278519 1278519 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77961 77961 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1700393 1700393 0 0.0
.debug_aranges 142512 142512 0 0.0
.debug_frame 519512 519512 0 0.0
.debug_info 45033171 45033170 -1 -0.0
.debug_line 5676500 5676500 0 0.0
.debug_loc 3606370 3606370 0 0.0
.debug_ranges 395512 395512 0 0.0
.debug_str 3963222 3963222 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121968 121968 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634016 634016 0 0.0
.symtab 192000 192000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030320 1030318 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640577 640577 0 0.0
(read/write) 204100 204100 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197504 197504 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 930806 930806 0 0.0
.debug_aranges 87360 87360 0 0.0
.debug_frame 299864 299864 0 0.0
.debug_info 20307078 20307078 0 0.0
.debug_line 2654650 2654650 0 0.0
.debug_loc 2787110 2787110 0 0.0
.debug_ranges 280904 280904 0 0.0
.debug_str 3001983 3001983 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105665 105665 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375952 375952 0 0.0
.symtab 255888 255888 0 0.0
.text 532792 532792 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12001540 12001540 0 0.0
(read/write) 727720 727720 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670008 670008 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 584148 584148 0 0.0
.text 9690628 9690628 0 0.0
thermostat-no-ble arm64 (read only) 2512388 2512388 0 0.0
(read/write) 145256 145256 0 0.0
.bss 56472 56472 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151136 151136 0 0.0
.text 2099136 2099136 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464912 2464912 0 0.0
.bss 215908 215908 0 0.0
.data 5880 5880 0 0.0
.text 1427556 1427556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162552 1162552 0 0.0
bss 143539 143539 0 0.0
rodata 134468 134468 0 0.0
text 804656 804656 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108548 1108548 0 0.0
bss 142695 142695 0 0.0
rodata 111456 111456 0 0.0
text 774636 774636 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367836 1367836 0 0.0
bss 106002 106002 0 0.0
rodata 211900 211900 0 0.0
text 764428 764428 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149220 1149220 0 0.0
.bss 99908 99908 0 0.0
.data 848 848 0 0.0
.text 596320 596320 0 0.0
lock-app qpg6105+debug (read/write) 1116964 1116964 0 0.0
.bss 96404 96404 0 0.0
.data 860 860 0 0.0
.text 564060 564060 0 0.0

@andy31415 andy31415 merged commit 48706bd into project-chip:master Feb 16, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…roject-chip#25065)

* Add color display in the light UI ... friendlier UI

* Restyle

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants