Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emberAfSendDefaultResponse. #25080

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Remove emberAfSendDefaultResponse. #25080

merged 1 commit into from
Feb 15, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

  • The various emberAfBasicClusterMfgSpecificPingCallback functions in examples all had the wrong signature, so wouldn't be called even if those examples enabled that non-standard command. Which the examples don't.
  • scenes-client.h/cpp was dead code, and not really fixable to work with Matter: the behavior expected of clients is very different from ZCL, and the code in this file would be replaced by a mix of TLV decoding of the ViewScene response and bits in CommandSender that already exist.
  • The declaration of emberAfGetCommandApsFrame that is being removed does not have a corresponding implementation, so it was just dead and misleading code.

@bzbarsky-apple
Remove emberAfSendDefaultResponse.
d8df1c6 
* The various emberAfBasicClusterMfgSpecificPingCallback functions in examples
  all had the wrong signature, so wouldn't be called even if those examples
  enabled that non-standard command.  Which the examples don't.
* scenes-client.h/cpp was dead code, and not really fixable to work with Matter:
  the behavior expected of clients is very different from ZCL, and the code in
  this file would be replaced by a mix of TLV decoding of the ViewScene response
  and bits in CommandSender that already exist.
* The declaration of emberAfGetCommandApsFrame that is being removed does not
  have a corresponding implementation, so it was just dead and misleading code.
@bzbarsky-apple bzbarsky-apple force-pushed the remove-send-default-response branch from 3ed7bac to d8df1c6 Compare February 15, 2023 16:36
@github-actions
Copy link

github-actions bot commented Feb 15, 2023 •
edited
Loading

PR #25080: Size comparison from 6c1cb33 to d8df1c6

Increases (7 builds for cc13x2_26x2, esp32)
platform target config section 6c1cb33 d8df1c6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171540 171548 8 0.0
lock-ftd LP_CC2652R7 (read/write) 172448 172464 16 0.0
lock-mtd LP_CC2652R7 (read/write) 181268 181292 24 0.0
pump-app LP_CC2652R7 (read/write) 160092 160116 24 0.0
pump-controller-app LP_CC2652R7 (read/write) 175004 175036 32 0.0
shell LP_CC2652R7 (read/write) 182340 182364 24 0.0
esp32 all-clusters-app m5stack .flash.rodata 250540 250544 4 0.0
Decreases (38 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6c1cb33 d8df1c6 change % change
bl602 lighting-app bl602 .text 1025366 1025364 -2 -0.0
bl602+rpc .text 1056046 1056044 -2 -0.0
bl702 lighting-app bl702 .debug_abbrev 1552720 1552710 -10 -0.0
.debug_aranges 134368 134352 -16 -0.0
.debug_frame 492396 492328 -68 -0.0
.debug_info 40652730 40652227 -503 -0.0
.debug_line 5282033 5281765 -268 -0.0
.debug_loc 3413875 3413565 -310 -0.0
.debug_ranges 372176 372160 -16 -0.0
.debug_str 3562662 3562437 -225 -0.0
.text 954766 954764 -2 -0.0
bl702+rpc .debug_abbrev 1701210 1701200 -10 -0.0
.debug_aranges 142600 142584 -16 -0.0
.debug_frame 520144 520076 -68 -0.0
.debug_info 45062086 45061584 -502 -0.0
.debug_line 5681029 5680761 -268 -0.0
.debug_loc 3610751 3610441 -310 -0.0
.debug_ranges 395944 395928 -16 -0.0
.debug_str 3966166 3965941 -225 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679675 679659 -16 -0.0
.bss 80908 80900 -8 -0.0
.text 590980 590964 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643083 643051 -32 -0.0
.text 564544 564512 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 676119 676103 -16 -0.0
.text 598904 598888 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 662555 662531 -24 -0.0
.text 558760 558736 -24 -0.0
pump-app LP_CC2652R7 (read only) 689211 689179 -32 -0.0
.bss 78316 78308 -8 -0.0
.text 597816 597784 -32 -0.0
pump-controller-app LP_CC2652R7 (read only) 674411 674379 -32 -0.0
.text 587008 586976 -32 -0.0
shell LP_CC2652R7 (read only) 670946 670914 -32 -0.0
.bss 82980 82972 -8 -0.0
.text 585504 585472 -32 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931232 931222 -10 -0.0
.debug_aranges 87448 87432 -16 -0.0
.debug_frame 300176 300120 -56 -0.0
.debug_info 20331215 20330603 -612 -0.0
.debug_line 2657689 2657492 -197 -0.0
.debug_loc 2790247 2789925 -322 -0.0
.debug_ranges 281336 281320 -16 -0.0
.debug_str 3004452 3004227 -225 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585990 585958 -32 -0.0
.app_xip_area 462752 462720 -32 -0.0
lock cyw930739m2evb_01 (read/write) 589770 589746 -24 -0.0
.app_xip_area 461236 461212 -24 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551018 550986 -32 -0.0
.app_xip_area 433284 433260 -24 -0.0
.bss 60224 60216 -8 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1067288 1067256 -32 -0.0
.text 912084 912052 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 1049656 1049634 -22 -0.0
.flash.text 1049656 1049634 -22 -0.0
m5stack (read only) 1101519 1101511 -8 -0.0
(read/write) 501431 501427 -4 -0.0
.dram0.bss 83040 83032 -8 -0.0
.flash.text 1096135 1096127 -8 -0.0
k32w contact k32w0+release (read/write) 669756 669716 -40 -0.0
.bss 77668 77660 -8 -0.0
.text 570776 570744 -32 -0.0
light k32w0+release (read/write) 668820 668788 -32 -0.0
.text 570156 570124 -32 -0.0
lock k32w0+release (read/write) 625416 625384 -32 -0.0
.text 545056 545024 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release .bss 215932 215924 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164000 1163968 -32 -0.0
bss 143563 143559 -4 -0.0
text 806148 806120 -28 -0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1369356 1369276 -80 -0.0
bss 106026 106022 -4 -0.0
text 765916 765888 -28 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1109620 1109588 -32 -0.0
bss 142719 142715 -4 -0.0
text 775692 775664 -28 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_abbrev 1254734 1254724 -10 -0.0
.debug_aranges 111504 111488 -16 -0.0
.debug_frame 374600 374544 -56 -0.0
.debug_info 28053817 28053205 -612 -0.0
.debug_line 3792795 3792594 -201 -0.0
.debug_loc 3684779 3684399 -380 -0.0
.debug_ranges 363064 363048 -16 -0.0
.debug_str 3512768 3512543 -225 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_abbrev 1240277 1240267 -10 -0.0
.debug_aranges 110768 110752 -16 -0.0
.debug_frame 377036 376980 -56 -0.0
.debug_info 27600759 27600148 -611 -0.0
.debug_line 3801260 3801059 -201 -0.0
.debug_loc 3668394 3668014 -380 -0.0
.debug_ranges 361032 361016 -16 -0.0
.debug_str 3498521 3498296 -225 -0.0
light cy8ckit_062s2_43012 .debug_abbrev 1074704 1074694 -10 -0.0
.debug_aranges 102976 102960 -16 -0.0
.debug_frame 347296 347240 -56 -0.0
.debug_info 22942034 22941424 -610 -0.0
.debug_line 3353260 3353060 -200 -0.0
.debug_loc 3347831 3347449 -382 -0.0
.debug_ranges 320208 320192 -16 -0.0
.debug_str 3301478 3301253 -225 -0.0
lock cy8ckit_062s2_43012 .debug_abbrev 1076447 1076437 -10 -0.0
.debug_aranges 103416 103400 -16 -0.0
.debug_frame 349172 349116 -56 -0.0
.debug_info 23171049 23170438 -611 -0.0
.debug_line 3354873 3354670 -203 -0.0
.debug_loc 3369605 3369193 -412 -0.0
.debug_ranges 322120 322104 -16 -0.0
.debug_str 3318282 3318057 -225 -0.0
qpg lighting-app qpg6105+debug (read/write) 1150492 1150460 -32 -0.0
.text 597592 597560 -32 -0.0
lock-app qpg6105+debug (read/write) 1117820 1117788 -32 -0.0
.text 564916 564884 -32 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1015380 1015348 -32 -0.0
bss 97936 97928 -8 -0.0
text 686350 686326 -24 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 951392 951360 -32 -0.0
bss 96988 96980 -8 -0.0
text 648200 648174 -26 -0.0
contact-sensor-app tlsr9518adk80d (read/write) 855804 855780 -24 -0.0
text 578632 578610 -22 -0.0
light-switch-app tlsr9518adk80d (read/write) 871564 871540 -24 -0.0
text 592678 592656 -22 -0.0
lighting-app tlsr9518adk80d (read/write) 949516 949492 -24 -0.0
bss 97344 97336 -8 -0.0
text 658700 658678 -22 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 882988 882956 -32 -0.0
bss 90144 90136 -8 -0.0
text 602514 602494 -20 -0.0
thermostat tlsr9518adk80d (read/write) 875864 875840 -24 -0.0
text 594302 594280 -22 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6c1cb33 d8df1c6 change % change
bl602 lighting-app bl602 (read/write) 1349038 1349038 0 0.0
.bss 94834 94834 0 0.0
.data 9736 9736 0 0.0
.text 1025366 1025364 -2 -0.0
bl602+rpc (read/write) 1394214 1394214 0 0.0
.bss 102882 102882 0 0.0
.data 10128 10128 0 0.0
.text 1056046 1056044 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187387 1187387 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1552720 1552710 -10 -0.0
.debug_aranges 134368 134352 -16 -0.0
.debug_frame 492396 492328 -68 -0.0
.debug_info 40652730 40652227 -503 -0.0
.debug_line 5282033 5281765 -268 -0.0
.debug_loc 3413875 3413565 -310 -0.0
.debug_ranges 372176 372160 -16 -0.0
.debug_str 3562662 3562437 -225 -0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107488 107488 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 573911 573911 0 0.0
.symtab 173568 173568 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
954766 954764 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1280543 1280543 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1701210 1701200 -10 -0.0
.debug_aranges 142600 142584 -16 -0.0
.debug_frame 520144 520076 -68 -0.0
.debug_info 45062086 45061584 -502 -0.0
.debug_line 5681029 5680761 -268 -0.0
.debug_loc 3610751 3610441 -310 -0.0
.debug_ranges 395944 395928 -16 -0.0
.debug_str 3966166 3965941 -225 -0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122128 122128 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634970 634970 0 0.0
.symtab 192032 192032 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1032160 1032160 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679675 679659 -16 -0.0
(read/write) 171540 171548 8 0.0
.bss 80908 80900 -8 -0.0
.data 3384 3384 0 0.0
.rodata 88379 88379 0 0.0
.text 590980 590964 -16 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643083 643051 -32 -0.0
(read/write) 157600 157600 0 0.0
.bss 80100 80100 0 0.0
.data 3384 3384 0 0.0
.rodata 78219 78219 0 0.0
.text 564544 564512 -32 -0.0
lock-ftd LP_CC2652R7 (read only) 676119 676103 -16 -0.0
(read/write) 172448 172464 16 0.0
.bss 78348 78348 0 0.0
.data 3312 3312 0 0.0
.rodata 76735 76735 0 0.0
.text 598904 598888 -16 -0.0
lock-mtd LP_CC2652R7 (read only) 662555 662531 -24 -0.0
(read/write) 181268 181292 24 0.0
.bss 73604 73604 0 0.0
.data 3312 3312 0 0.0
.rodata 103315 103315 0 0.0
.text 558760 558736 -24 -0.0
pump-app LP_CC2652R7 (read only) 689211 689179 -32 -0.0
(read/write) 160092 160116 24 0.0
.bss 78316 78308 -8 -0.0
.data 3276 3276 0 0.0
.rodata 90915 90915 0 0.0
.text 597816 597784 -32 -0.0
pump-controller-app LP_CC2652R7 (read only) 674411 674379 -32 -0.0
(read/write) 175004 175036 32 0.0
.bss 78428 78428 0 0.0
.data 3300 3300 0 0.0
.rodata 86923 86923 0 0.0
.text 587008 586976 -32 -0.0
shell LP_CC2652R7 (read only) 670946 670914 -32 -0.0
(read/write) 182340 182364 24 0.0
.bss 82980 82972 -8 -0.0
.data 3380 3380 0 0.0
.rodata 85130 85130 0 0.0
.text 585504 585472 -32 -0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 641793 641793 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931232 931222 -10 -0.0
.debug_aranges 87448 87432 -16 -0.0
.debug_frame 300176 300120 -56 -0.0
.debug_info 20331215 20330603 -612 -0.0
.debug_line 2657689 2657492 -197 -0.0
.debug_loc 2790247 2789925 -322 -0.0
.debug_ranges 281336 281320 -16 -0.0
.debug_str 3004452 3004227 -225 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376342 376342 0 0.0
.symtab 256016 256016 0 0.0
.text 0 0 0 0.0
533972 533972 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585990 585958 -32 -0.0
.app_xip_area 462752 462720 -32 -0.0
.bss 65680 65680 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589770 589746 -24 -0.0
.app_xip_area 461236 461212 -24 -0.0
.bss 70968 70968 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551018 550986 -32 -0.0
.app_xip_area 433284 433260 -24 -0.0
.bss 60224 60216 -8 -0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1040448 1040448 0 0.0
.bss 181608 181608 0 0.0
.data 2044 2044 0 0.0
.text 856772 856772 0 0.0
BRD4187C (read/write) 1137576 1137576 0 0.0
.bss 133288 133288 0 0.0
.data 2532 2532 0 0.0
.text 977160 977160 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067288 1067256 -32 -0.0
.bss 153128 153128 0 0.0
.data 2052 2052 0 0.0
.text 912084 912052 -32 -0.0
window-app BRD4187C (read/write) 1138608 1138608 0 0.0
.bss 134880 134880 0 0.0
.data 2572 2572 0 0.0
.text 976560 976560 0 0.0
esp32 all-clusters-app c3devkit (read only) 1049656 1049634 -22 -0.0
(read/write) 1585338 1585338 0 0.0
.dram0.bss 77992 77992 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 221792 221792 0 0.0
.flash.text 1049656 1049634 -22 -0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1101519 1101511 -8 -0.0
(read/write) 501431 501427 -4 -0.0
.dram0.bss 83040 83032 -8 -0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 250540 250544 4 0.0
.flash.text 1096135 1096127 -8 -0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 669756 669716 -40 -0.0
.bss 77668 77660 -8 -0.0
.data 2200 2200 0 0.0
.text 570776 570744 -32 -0.0
light k32w0+release (read/write) 668820 668788 -32 -0.0
.bss 77364 77364 0 0.0
.data 2188 2188 0 0.0
.text 570156 570124 -32 -0.0
lock k32w0+release (read/write) 625416 625384 -32 -0.0
.bss 75500 75500 0 0.0
.data 2132 2132 0 0.0
.text 545056 545024 -32 -0.0
linux chip-tool-ipv6only arm64 (read only) 12012612 12012612 0 0.0
(read/write) 728632 728632 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670872 670872 0 0.0
.dynamic 560 560 0 0.0
.got 15304 15304 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 584660 584660 0 0.0
.text 9699124 9699124 0 0.0
thermostat-no-ble arm64 (read only) 2516868 2516868 0 0.0
(read/write) 145320 145320 0 0.0
.bss 56488 56488 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151232 151232 0 0.0
.text 2103344 2103344 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467848 2467848 0 0.0
.bss 215932 215924 -8 -0.0
.data 5880 5880 0 0.0
.text 1430492 1430492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164000 1163968 -32 -0.0
bss 143563 143559 -4 -0.0
rodata 134428 134428 0 0.0
text 806148 806120 -28 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1369356 1369276 -80 -0.0
bss 106026 106022 -4 -0.0
rodata 211868 211868 0 0.0
text 765916 765888 -28 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1109620 1109588 -32 -0.0
bss 142719 142715 -4 -0.0
rodata 111472 111472 0 0.0
text 775692 775664 -28 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840832 840832 0 0.0
(read/write) 1760172 1760172 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189840 189840 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1254734 1254724 -10 -0.0
.debug_aranges 111504 111488 -16 -0.0
.debug_frame 374600 374544 -56 -0.0
.debug_info 28053817 28053205 -612 -0.0
.debug_line 3792795 3792594 -201 -0.0
.debug_loc 3684779 3684399 -380 -0.0
.debug_ranges 363064 363048 -16 -0.0
.debug_str 3512768 3512543 -225 -0.0
.heap 840832 840832 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 579468 579468 0 0.0
.symtab 425232 425232 0 0.0
.text 1559272 1559272 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841648 841648 0 0.0
(read/write) 1701052 1701052 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189032 189032 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1240277 1240267 -10 -0.0
.debug_aranges 110768 110752 -16 -0.0
.debug_frame 377036 376980 -56 -0.0
.debug_info 27600759 27600148 -611 -0.0
.debug_line 3801260 3801059 -201 -0.0
.debug_loc 3668394 3668014 -380 -0.0
.debug_ranges 361032 361016 -16 -0.0
.debug_str 3498521 3498296 -225 -0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540079 540079 0 0.0
.symtab 410512 410512 0 0.0
.text 1500968 1500968 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849960 849960 0 0.0
(read/write) 1614340 1614340 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180920 180920 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074704 1074694 -10 -0.0
.debug_aranges 102976 102960 -16 -0.0
.debug_frame 347296 347240 -56 -0.0
.debug_info 22942034 22941424 -610 -0.0
.debug_line 3353260 3353060 -200 -0.0
.debug_loc 3347831 3347449 -382 -0.0
.debug_ranges 320208 320192 -16 -0.0
.debug_str 3301478 3301253 -225 -0.0
.heap 849960 849960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475861 475861 0 0.0
.symtab 378288 378288 0 0.0
.text 1422568 1422568 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844984 844984 0 0.0
(read/write) 1648156 1648156 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185888 185888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1076447 1076437 -10 -0.0
.debug_aranges 103416 103400 -16 -0.0
.debug_frame 349172 349116 -56 -0.0
.debug_info 23171049 23170438 -611 -0.0
.debug_line 3354873 3354670 -203 -0.0
.debug_loc 3369605 3369193 -412 -0.0
.debug_ranges 322120 322104 -16 -0.0
.debug_str 3318282 3318057 -225 -0.0
.heap 844984 844984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478613 478613 0 0.0
.symtab 380480 380480 0 0.0
.text 1451408 1451408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150492 1150460 -32 -0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597592 597560 -32 -0.0
lock-app qpg6105+debug (read/write) 1117820 1117788 -32 -0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564916 564884 -32 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015380 1015348 -32 -0.0
bss 97936 97928 -8 -0.0
text 686350 686326 -24 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951392 951360 -32 -0.0
bss 96988 96980 -8 -0.0
text 648200 648174 -26 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 855804 855780 -24 -0.0
bss 89108 89108 0 0.0
text 578632 578610 -22 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871564 871540 -24 -0.0
bss 89192 89192 0 0.0
text 592678 592656 -22 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949516 949492 -24 -0.0
bss 97344 97336 -8 -0.0
text 658700 658678 -22 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882988 882956 -32 -0.0
bss 90144 90136 -8 -0.0
text 602514 602494 -20 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875864 875840 -24 -0.0
bss 90584 90584 0 0.0
text 594302 594280 -22 -0.0

@andy31415 andy31415 merged commit e294edb into project-chip:master Feb 15, 2023
@bzbarsky-apple bzbarsky-apple deleted the remove-send-default-response branch February 15, 2023 20:37
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Remove emberAfSendDefaultResponse. (project-chip#25080)
3001cda 
* The various emberAfBasicClusterMfgSpecificPingCallback functions in examples
  all had the wrong signature, so wouldn't be called even if those examples
  enabled that non-standard command.  Which the examples don't.
* scenes-client.h/cpp was dead code, and not really fixable to work with Matter:
  the behavior expected of clients is very different from ZCL, and the code in
  this file would be replaced by a mix of TLV decoding of the ViewScene response
  and bits in CommandSender that already exist.
* The declaration of emberAfGetCommandApsFrame that is being removed does not
  have a corresponding implementation, so it was just dead and misleading code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @jtung-apple @andy31415