Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cluster-objects response struct in DoorLockServer::getUserCommandHandler. #25092

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Use cluster-objects response struct in DoorLockServer::getUserCommandHandler. #25092

merged 1 commit into from
Feb 17, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Get rids of some manual TLV use and use of emberAfCurrentEndpoint().

@github-actions github-actions bot added the app label Feb 15, 2023
@github-actions
Copy link

PR #25092: Size comparison from 80ee243 to 21150ee

Increases above 0.2%:

platform target config section 80ee243 21150ee change % change
cc32xx lock CC3235SF_LAUNCHXL .strtab 376514 377759 1245 0.3
Increases (3 builds for cc32xx, qpg)
platform target config section 80ee243 21150ee change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 642233 376 0.1
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338088 20342775 4687 0.0
.debug_line 2657822 2658250 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1
qpg lighting-app qpg6105+debug (read/write) 1150516 1150524 8 0.0
.text 597616 597624 8 0.0
lock-app qpg6105+debug (read/write) 1117820 1118052 232 0.0
.text 564916 565148 232 0.0
Decreases (2 builds for cc32xx, mbed)
platform target config section 80ee243 21150ee change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931449 -66 -0.0
.rodata 105697 105673 -24 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2467864 2465744 -2120 -0.1
.text 1430508 1428388 -2120 -0.1
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 80ee243 21150ee change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 642233 376 0.1
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931449 -66 -0.0
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338088 20342775 4687 0.0
.debug_line 2657822 2658250 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105673 -24 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467864 2465744 -2120 -0.1
.bss 215924 215924 0 0.0
.data 5880 5880 0 0.0
.text 1430508 1428388 -2120 -0.1
qpg lighting-app qpg6105+debug (read/write) 1150516 1150524 8 0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597616 597624 8 0.0
lock-app qpg6105+debug (read/write) 1117820 1118052 232 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564916 565148 232 0.0

@github-actions github-actions bot added the tests label Feb 15, 2023
@github-actions
Copy link

PR #25092: Size comparison from 80ee243 to 5c17931

Increases above 0.2%:

platform target config section 80ee243 5c17931 change % change
cc32xx lock CC3235SF_LAUNCHXL .strtab 376514 377759 1245 0.3
Increases (1 build for cc32xx)
platform target config section 80ee243 5c17931 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 642233 376 0.1
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338088 20342775 4687 0.0
.debug_line 2657822 2658250 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1
Decreases (1 build for cc32xx)
platform target config section 80ee243 5c17931 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931449 -66 -0.0
.rodata 105697 105673 -24 -0.0
Full report (1 build for cc32xx)
platform target config section 80ee243 5c17931 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 642233 376 0.1
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931449 -66 -0.0
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338088 20342775 4687 0.0
.debug_line 2657822 2658250 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105673 -24 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1

@github-actions
Copy link

PR #25092: Size comparison from 83dd188 to 8ae914e

Increases above 0.2%:

platform target config section 83dd188 8ae914e change % change
cc32xx lock CC3235SF_LAUNCHXL .strtab 376514 377759 1245 0.3
Increases (1 build for cc32xx)
platform target config section 83dd188 8ae914e change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 642233 376 0.1
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338085 20342773 4688 0.0
.debug_line 2657824 2658252 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1
Decreases (1 build for cc32xx)
platform target config section 83dd188 8ae914e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931449 -66 -0.0
.rodata 105697 105673 -24 -0.0
Full report (1 build for cc32xx)
platform target config section 83dd188 8ae914e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 642233 376 0.1
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931449 -66 -0.0
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338085 20342773 4688 0.0
.debug_line 2657824 2658252 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105673 -24 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1

@github-actions
Copy link

PR #25092: Size comparison from 83dd188 to 39b1cc7

Increases above 0.2%:

platform target config section 83dd188 39b1cc7 change % change
cc32xx lock CC3235SF_LAUNCHXL .strtab 376514 377759 1245 0.3
Increases (1 build for cc32xx)
platform target config section 83dd188 39b1cc7 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 642233 376 0.1
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338085 20342773 4688 0.0
.debug_line 2657824 2658252 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1
Decreases (1 build for cc32xx)
platform target config section 83dd188 39b1cc7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931449 -66 -0.0
.rodata 105697 105673 -24 -0.0
Full report (1 build for cc32xx)
platform target config section 83dd188 39b1cc7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 642233 376 0.1
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931449 -66 -0.0
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338085 20342773 4688 0.0
.debug_line 2657824 2658252 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105673 -24 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1

@bzbarsky-apple
Use cluster-objects response struct in DoorLockServer::getUserCommand…
5eb7664 
…Handler.

Get rids of some manual TLV use and use of emberAfCurrentEndpoint().
@github-actions
Copy link

PR #25092: Size comparison from b2b6e0f to 5eb7664

Increases above 0.2%:

platform target config section b2b6e0f 5eb7664 change % change
cc32xx lock CC3235SF_LAUNCHXL .strtab 376514 377759 1245 0.3
Increases (1 build for cc32xx)
platform target config section b2b6e0f 5eb7664 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 641857 642233 376 0.1
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338086 20342774 4688 0.0
.debug_line 2657824 2658252 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1
Decreases (1 build for cc32xx)
platform target config section b2b6e0f 5eb7664 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_abbrev 931515 931449 -66 -0.0
.rodata 105697 105673 -24 -0.0
Full report (1 build for cc32xx)
platform target config section b2b6e0f 5eb7664 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 642233 376 0.1
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931449 -66 -0.0
.debug_aranges 87432 87448 16 0.0
.debug_frame 300120 300172 52 0.0
.debug_info 20338086 20342774 4688 0.0
.debug_line 2657824 2658252 428 0.0
.debug_loc 2790649 2793110 2461 0.1
.debug_ranges 281568 281968 400 0.1
.debug_str 3003658 3007539 3881 0.1
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105673 -24 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 377759 1245 0.3
.symtab 256016 256352 336 0.1
.text 534036 534436 400 0.1

@vivien-apple vivien-apple merged commit 8e12c87 into project-chip:master Feb 17, 2023
@bzbarsky-apple bzbarsky-apple deleted the door-lock-no-raw-tlv branch February 17, 2023 13:43
@vivien-apple vivien-apple mentioned this pull request Feb 24, 2023
Merged
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Use cluster-objects response struct in DoorLockServer::getUserCommand…
1967a67 
…Handler. (project-chip#25092)

Get rids of some manual TLV use and use of emberAfCurrentEndpoint().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @yunhanw-google @vivien-apple