[nrfconnect] Fixed setting tilt/lift for window covering #25108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Window covering sample has a bug that allows to set only lift/tilt positions that are multiple of 5% (step value). It was fixed by adding a logic that compares the next step value with the target value.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pjzander-signify,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple and
xylophone21
|
PR #25108: Size comparison from 352efee to 01fd0eb Full report (1 build for cc32xx)
|
LuDuda
approved these changes
Feb 16, 2023
bzbarsky-apple
approved these changes
Feb 16, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…p#25108) Window covering sample has a bug that allows to set only lift/tilt positions that are multiple of 5% (step value). It was fixed by adding a logic that compares the next step value with the target value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window covering sample has a bug that allows to set only lift/tilt positions that are multiple of 5% (step value).
It was fixed by adding a logic that compares the next step value with the target value.