[Silabs][EFR32] Fix lock-app with matter shell build failure #25114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
approved these changes
Feb 16, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
pullapprove
bot
requested review from
mspang,
pjzander-signify,
saurabhst,
tcarmelveilleux,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Feb 16, 2023
andy31415
approved these changes
Feb 16, 2023
jmartinez-silabs
added a commit
to SiliconLabs/matter
that referenced
this pull request
Feb 24, 2023
…-app with shell enabled (project-chip#25114) Merge in WMN_TOOLS/matter from cherry-pick/Fix_lock_app_shell to RC_1.1.0-1.1 Squashed commit of the following: commit 3d4a1d3dc59f7fd682a8fa8aa1b1d5e8d2bc2953 Author: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> Date: Thu Feb 16 11:51:37 2023 -0500 Missing source file when building lock-app with shell enabled (project-chip#25114)
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing source file to the lock-app build.gn when shell is enabled
Tested the lock-app build and shell locally