Stop assuming a particular threading model when generating shutdown events. #25139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
stop-shutdown-event-conflation
branch
from
d5978d1
to
7b529b6
Compare
…vents. We should be able to generate a shutdown event regardless of whether we're doing RunEventLoop or StartEventLoopTask. That means leaving the shutdown of the event loop to the API consumer, since those cases need to be handled somewhat differently.
bzbarsky-apple
force-pushed
the
stop-shutdown-event-conflation
branch
from
7b529b6
to
dd9019f
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #25139: Size comparison from 5f058f9 to dd9019f Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Feb 17, 2023
Damian-Nordic
approved these changes
Feb 17, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…vents. (project-chip#25139) We should be able to generate a shutdown event regardless of whether we're doing RunEventLoop or StartEventLoopTask. That means leaving the shutdown of the event loop to the API consumer, since those cases need to be handled somewhat differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to generate a shutdown event regardless of whether we're doing RunEventLoop or StartEventLoopTask. That means leaving the shutdown of the event loop to the API consumer, since those cases need to be handled somewhat differently.