Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen WiFi and bluetooth fix #25186

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Conversation

jlatusek
Copy link
Contributor

@jlatusek jlatusek commented Feb 20, 2023

Problem

  • During pairing ble-wifi, there is a chip stack locking error
  • The application does not have the correct privileges to manipulate the wifi adapter.

Changes

  • Add missing network.profile privileges to all tizen apps; this privilege is not documented as required, but the application's log shows that this one is missing.
  • Enable advertising of the Tizen device name.
  • Add locking chip stack in WiFi connected callback.
  • Allow the device to be already connected to WiFi

Testing

Tested on two Tizen devices.
chip-tool:

./chip-tool pairing ble-wifi 0x01 <wifi> <pass> 20202021 3840

lighting-app:

app_launcher -s org.tizen.matter.example.lighting wifi true

To test these changes with the Linux chip-tool there have to be merged changes in Tizen API. I've tested it locally using the same commands as above.

@github-actions
Copy link

PR #25186: Size comparison from 04adc52 to 52fc8f0

Full report (1 build for cc32xx)
platform target config section 04adc52 52fc8f0 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642209 642209 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360287 20360287 0 0.0
.debug_line 2661052 2661052 0 0.0
.debug_loc 2797120 2797120 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105713 105713 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534376 534376 0 0.0

@jlatusek jlatusek marked this pull request as draft February 20, 2023 09:55
@github-actions github-actions bot added examples platform tizen For Tizen platform labels Feb 20, 2023
@jlatusek jlatusek marked this pull request as ready for review February 20, 2023 11:22
@github-actions
Copy link

PR #25186: Size comparison from 04adc52 to b29c5a8

Full report (1 build for cc32xx)
platform target config section 04adc52 b29c5a8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642209 642209 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360287 20360287 0 0.0
.debug_line 2661052 2661052 0 0.0
.debug_loc 2797120 2797120 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105713 105713 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534376 534376 0 0.0

@github-actions
Copy link

PR #25186: Size comparison from 04adc52 to 3808ff3

Full report (2 builds for cc32xx, mbed)
platform target config section 04adc52 3808ff3 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642209 642209 0 0.0
(read/write) 203696 203696 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197096 197096 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934242 934242 0 0.0
.debug_aranges 87448 87448 0 0.0
.debug_frame 300212 300212 0 0.0
.debug_info 20360287 20360287 0 0.0
.debug_line 2661052 2661052 0 0.0
.debug_loc 2797120 2797120 0 0.0
.debug_ranges 281744 281744 0 0.0
.debug_str 3019502 3019502 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105713 105713 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377379 377379 0 0.0
.symtab 256048 256048 0 0.0
.text 534376 534376 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466552 2466552 0 0.0
.bss 215812 215812 0 0.0
.data 5880 5880 0 0.0
.text 1429196 1429196 0 0.0

@arkq arkq merged commit 3951efb into project-chip:master Feb 21, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Add missing privileges

* Init network commissioning interface

* add LockChipStack wifi in callback thread

* Advertise device name

* Add privilege to allow wifi managment in app

* Allow the device to be already connected to the wifi

* Fix includes
@jlatusek jlatusek deleted the tizen-bluetooth branch January 15, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants