-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable -Wconversion in src/platform/Darwin. #25323
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-platform-Wconversion
Feb 28, 2023
Merged
Enable -Wconversion in src/platform/Darwin. #25323
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-platform-Wconversion
Feb 28, 2023
+44
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
February 25, 2023 02:36
pullapprove
bot
requested review from
tehampson,
vijs,
vivien-apple,
woody-apple and
xylophone21
February 25, 2023 02:36
This may need #25324 to merge before it will compile... |
PR #25323: Size comparison from 265d55c to 54bfc01 Increases (2 builds for cc32xx, nrfconnect)
Decreases (1 build for qpg)
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
bzbarsky-apple
force-pushed
the
darwin-platform-Wconversion
branch
from
February 25, 2023 05:02
54bfc01
to
4d3030d
Compare
PR #25323: Size comparison from b89e83b to 4d3030d Increases (1 build for cc32xx)
Decreases (1 build for qpg)
Full report (3 builds for cc32xx, qpg)
|
bzbarsky-apple
force-pushed
the
darwin-platform-Wconversion
branch
from
February 27, 2023 15:36
4d3030d
to
a1581b8
Compare
woody-apple
approved these changes
Feb 27, 2023
yunhanw-google
approved these changes
Feb 27, 2023
bzbarsky-apple
force-pushed
the
darwin-platform-Wconversion
branch
from
February 27, 2023 19:10
a1581b8
to
aa2988a
Compare
PR #25323: Size comparison from af511d7 to aa2988a Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jtung-apple
approved these changes
Feb 27, 2023
Also fixes incorrect handling of the bssid from CWNetwork.
bzbarsky-apple
force-pushed
the
darwin-platform-Wconversion
branch
from
February 27, 2023 20:45
aa2988a
to
ded6ec0
Compare
PR #25323: Size comparison from af511d7 to ded6ec0 Increases (4 builds for cc32xx, mbed, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
msandstedt
reviewed
Feb 27, 2023
msandstedt
approved these changes
Feb 27, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Also fixes incorrect handling of the bssid from CWNetwork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes incorrect handling of the bssid from CWNetwork.