Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating chip_server_cluster_attributes #25687

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Deprecating chip_server_cluster_attributes #25687

merged 2 commits into from
Mar 21, 2023

Conversation

brdandu
Copy link
Contributor

@brdandu brdandu commented Mar 14, 2023 •
edited by andy31415
Loading

Replacing a state helper such as chip_server_cluster_attributes with a stateless helper zcl_attributes_server such that we can get deprecate the stateful helpers one by one.

Github: ZAP#898

@brdandu brdandu changed the title Replacing a state helper such as chip_server_cluster_attributes with … Deprecating chip_server_cluster_attributes Mar 14, 2023
@brdandu brdandu mentioned this pull request Mar 14, 2023
Closed
@brdandu brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesNonJavaTemplates/ZAP#898 branch from 15daf06 to 7368fe2 Compare March 15, 2023 15:44
andy31415
andy31415 reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs MatterIDL.zapt changes as well. it also seems we want separate logic between server side and client side cluster generation (client side wants all attributes/commands/etc) where as server side seems to want to consider enabling logic.

@bzbarsky-apple
Copy link
Contributor

Needs MatterIDL.zapt changes as well

That can be a separate PR, but yes, we need to figure out how it should work. Especially for "limited" vs "unlimited" clients ("light switch" vs "python controller").

@brdandu brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesNonJavaTemplates/ZAP#898 branch from 4fff5cb to 6766b75 Compare March 17, 2023 21:27
@brdandu brdandu marked this pull request as ready for review March 20, 2023 13:23
@brdandu brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesNonJavaTemplates/ZAP#898 branch from 5a306f7 to 5293a6a Compare March 20, 2023 13:35
@github-actions
Copy link

PR #25687: Size comparison from 804892e to 5293a6a

Full report (2 builds for cc32xx, mbed)
platform target config section 804892e 5293a6a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300316 300316 0 0.0
.debug_info 20248010 20248010 0 0.0
.debug_line 2661469 2661469 0 0.0
.debug_loc 2805592 2805592 0 0.0
.debug_ranges 283208 283208 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468424 2468424 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1431068 1431068 0 0.0

@brdandu brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesNonJavaTemplates/ZAP#898 branch from 5293a6a to 4c8122a Compare March 20, 2023 19:36
@github-actions
Copy link

PR #25687: Size comparison from 8425d28 to 4c8122a

Decreases (1 build for cc32xx)
platform target config section 8425d28 4c8122a2 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248011 20248010 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 8425d28 4c8122a2 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300316 300316 0 0.0
.debug_info 20248011 20248010 -1 -0.0
.debug_line 2661469 2661469 0 0.0
.debug_loc 2805592 2805592 0 0.0
.debug_ranges 283208 283208 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@brdandu
Replacing a state helper such as chip_server_cluster_attributes with …
555b488 
…a stateless helper zcl_attributes_server such that we can get deprecate the stateful helpers one by one.

Updating the zap being used
Github: ZAP#898
@brdandu
Updating min version to 3.16 instead of 3.17
c6ac360 
Github: ZAP#898
@brdandu brdandu force-pushed the bug/fixServerSideEnabledClustersAndAttributesNonJavaTemplates/ZAP#898 branch from 4c8122a to c6ac360 Compare March 20, 2023 20:14
@github-actions
Copy link

PR #25687: Size comparison from f1c1b88 to c6ac360

Full report (1 build for cc32xx)
platform target config section f1c1b88 c6ac360 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930292 930292 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300320 300320 0 0.0
.debug_info 20248022 20248022 0 0.0
.debug_line 2661345 2661345 0 0.0
.debug_loc 2805489 2805489 0 0.0
.debug_ranges 283264 283264 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@andy31415 andy31415 merged commit 934a6b1 into project-chip:master Mar 21, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@brdandu
Deprecating chip_server_cluster_attributes (project-chip#25687)
1d0aca2 
* Replacing a state helper such as chip_server_cluster_attributes with a stateless helper zcl_attributes_server such that we can get deprecate the stateful helpers one by one.
Updating the zap being used
Github: ZAP#898

* Updating min version to 3.16 instead of 3.17
Github: ZAP#898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@paulr34 paulr34 paulr34 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@arkq arkq Awaiting requested review from arkq

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin examples integrations review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brdandu @bzbarsky-apple @andy31415 @paulr34