Enable all thermostat client attributes in controller clusters #25753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
changed the title
|
PR #25753: Size comparison from 974f620 to 3b463a0 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 21, 2023
andy31415
force-pushed
the
enable_thermostat_client_attributes
branch
from
39a190a to
6884b55
Compare
|
Fast tracking - restyler seems to fail here (unsure why ... large files?) so will have to merge bypassing it. |
|
PR #25753: Size comparison from 5a0811e to 6884b55 Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ct-chip#25753) * Enable a bunch of thermostat client attributes * Zap regen --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable more attribute support within java and python.
Technically client-side clusters should have ignored enabling, however #25737 showed that there is more work to do here since codegen for java via zap also needs updating (work done by #25693).
Until then, I opened zap via
./scripts/tools/zap//run_zaptool.sh src/controller/data_model/controller-clusters.zap, switched thermostat to 'server', enabled all attributes and switched it back to client (odd workaround to mark client-side enabled in zap)