Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version from zap.json to download zap #25791

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Use version from zap.json to download zap #25791

merged 1 commit into from
Mar 25, 2023

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Mar 23, 2023

Zap version was retrieved from a Dockerfile that doesn't exist any more.
Use zap.json instead to get it.

@lebauce lebauce changed the title Fix zap downloading from source Use version from zap.json to download zap Mar 23, 2023
@github-actions
Copy link

PR #25791: Size comparison from e214d1e to d83749f

Increases (1 build for cc32xx)
platform target config section e214d1e d83749f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20251230 20251231 1 0.0
Full report (1 build for cc32xx)
platform target config section e214d1e d83749f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20251230 20251231 1 0.0
.debug_line 2661959 2661959 0 0.0
.debug_loc 2806733 2806733 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027534 3027534 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@andy31415 andy31415 mentioned this pull request Mar 23, 2023
Closed
bzbarsky-apple
bzbarsky-apple approved these changes Mar 23, 2023
View reviewed changes
scripts/tools/zap/zap_download.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited
Loading

PR #25791: Size comparison from a4a407b to 538bb19

Increases (7 builds for cc13x2_26x2, psoc6, qpg, telink)
platform target config section a4a407b 538bb19 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 665731 665739 8 0.0
.text 561632 561640 8 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27474327 27474328 1 0.0
light cy8ckit_062s2_43012 .debug_info 22832749 22832751 2 0.0
lock cy8ckit_062s2_43012 .debug_info 23084151 23084152 1 0.0
qpg lock-app qpg6105+debug (read/write) 1121440 1121448 8 0.0
.text 568540 568548 8 0.0
telink lighting-app-rpc tlsr9518adk80d (read/write) 1024816 1024824 8 0.0
text 707276 707278 2 0.0
pump-controller-app tlsr9518adk80d text 579588 579590 2 0.0
Decreases (9 builds for bl602, cc13x2_26x2, nrfconnect, telink)
platform target config section a4a407b 538bb19 change % change
bl602 lighting-app bl602+rpc .text 1060300 1060298 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 178148 178140 -8 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 775996 775992 -4 -0.0
telink all-clusters-app tlsr9518adk80d text 692328 692326 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 653368 653366 -2 -0.0
ota-requestor-app tlsr9518adk80d text 608214 608210 -4 -0.0
pump-app tlsr9518adk80d text 589268 589266 -2 -0.0
thermostat tlsr9518adk80d text 599218 599216 -2 -0.0
window-covering tlsr9518adk80d text 650292 650290 -2 -0.0
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section a4a407b 538bb19 change % change
bl602 lighting-app bl602 (read/write) 1356990 1356990 0 0.0
.bss 94834 94834 0 0.0
.data 9744 9744 0 0.0
.text 1029366 1029366 0 0.0
bl602+rpc (read/write) 1402438 1402438 0 0.0
.bss 102882 102882 0 0.0
.data 10136 10136 0 0.0
.text 1060300 1060298 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1189595 1189595 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70113 70113 0 0.0
.bss_psram 26064 26064 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1555664 1555664 0 0.0
.debug_aranges 134728 134728 0 0.0
.debug_frame 493832 493832 0 0.0
.debug_info 40900786 40900786 0 0.0
.debug_line 5293205 5293205 0 0.0
.debug_loc 3430405 3430405 0 0.0
.debug_ranges 374136 374136 0 0.0
.debug_str 3592155 3592155 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107984 107984 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 577941 577941 0 0.0
.symtab 174384 174384 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
960260 960260 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1281159 1281159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78161 78161 0 0.0
.bss_psram 26464 26464 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1707879 1707879 0 0.0
.debug_aranges 143088 143088 0 0.0
.debug_frame 522000 522000 0 0.0
.debug_info 45550952 45550952 0 0.0
.debug_line 5699678 5699678 0 0.0
.debug_loc 3629335 3629335 0 0.0
.debug_ranges 398136 398136 0 0.0
.debug_str 3996822 3996822 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122288 122288 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 639751 639751 0 0.0
.symtab 193008 193008 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1036278 1036278 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 682607 682607 0 0.0
(read/write) 168648 168648 0 0.0
.bss 80948 80948 0 0.0
.data 3352 3352 0 0.0
.rodata 88567 88567 0 0.0
.text 593724 593724 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 645919 645919 0 0.0
(read/write) 157616 157616 0 0.0
.bss 80148 80148 0 0.0
.data 3352 3352 0 0.0
.rodata 78439 78439 0 0.0
.text 567160 567160 0 0.0
lock-ftd LP_CC2652R7 (read only) 679519 679519 0 0.0
(read/write) 169200 169200 0 0.0
.bss 78500 78500 0 0.0
.data 3316 3316 0 0.0
.rodata 76815 76815 0 0.0
.text 602224 602224 0 0.0
lock-mtd LP_CC2652R7 (read only) 665731 665739 8 0.0
(read/write) 178148 178140 -8 -0.0
.bss 73660 73660 0 0.0
.data 3316 3316 0 0.0
.rodata 103619 103619 0 0.0
.text 561632 561640 8 0.0
pump-app LP_CC2652R7 (read only) 692291 692291 0 0.0
(read/write) 157172 157172 0 0.0
.bss 78476 78476 0 0.0
.data 3280 3280 0 0.0
.rodata 91003 91003 0 0.0
.text 600808 600808 0 0.0
pump-controller-app LP_CC2652R7 (read only) 677251 677251 0 0.0
(read/write) 172348 172348 0 0.0
.bss 78612 78612 0 0.0
.data 3304 3304 0 0.0
.rodata 86875 86875 0 0.0
.text 589896 589896 0 0.0
shell LP_CC2652R7 (read only) 674062 674062 0 0.0
(read/write) 179264 179264 0 0.0
.bss 83020 83020 0 0.0
.data 3348 3348 0 0.0
.rodata 85478 85478 0 0.0
.text 588272 588272 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930266 930266 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20229260 20229260 0 0.0
.debug_line 2661728 2661728 0 0.0
.debug_loc 2806516 2806516 0 0.0
.debug_ranges 283400 283400 0 0.0
.debug_str 3028246 3028246 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 0 0 0 0.0
537712 537712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 589378 589378 0 0.0
.app_xip_area 465972 465972 0 0.0
.bss 65832 65832 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 593618 593618 0 0.0
.app_xip_area 464916 464916 0 0.0
.bss 71120 71120 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 554134 554134 0 0.0
.app_xip_area 436328 436328 0 0.0
.bss 60280 60280 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1017024 1017024 0 0.0
.bss 178708 178708 0 0.0
.data 2128 2128 0 0.0
.text 836168 836168 0 0.0
BRD4187C (read/write) 1014756 1014756 0 0.0
.bss 148336 148336 0 0.0
.data 2776 2776 0 0.0
.text 839048 839048 0 0.0
lock-app BRD4161A+wf200 (read/write) 1071832 1071832 0 0.0
.bss 173140 173140 0 0.0
.data 2144 2144 0 0.0
.text 896528 896528 0 0.0
window-app BRD4187C (read/write) 1131444 1131444 0 0.0
.bss 132760 132760 0 0.0
.data 2668 2668 0 0.0
.text 971420 971420 0 0.0
esp32 all-clusters-app c3devkit (read only) 1052374 1052374 0 0.0
(read/write) 1586034 1586034 0 0.0
.dram0.bss 77984 77984 0 0.0
.dram0.data 13752 13752 0 0.0
.flash.rodata 222536 222536 0 0.0
.flash.text 1052374 1052374 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1104031 1104031 0 0.0
(read/write) 502107 502107 0 0.0
.dram0.bss 83024 83024 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 251272 251272 0 0.0
.flash.text 1098647 1098647 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 674688 674688 0 0.0
.bss 65532 65532 0 0.0
.data 2224 2224 0 0.0
.text 575532 575532 0 0.0
light k32w0+release (read/write) 673732 673732 0 0.0
.bss 65196 65196 0 0.0
.data 2212 2212 0 0.0
.text 574924 574924 0 0.0
lock k32w0+release (read/write) 628420 628420 0 0.0
.bss 63268 63268 0 0.0
.data 2136 2136 0 0.0
.text 548000 548000 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12132580 12132580 0 0.0
(read/write) 742648 742648 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 684520 684520 0 0.0
.dynamic 560 560 0 0.0
.got 15512 15512 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 585588 585588 0 0.0
.text 9784676 9784676 0 0.0
thermostat-no-ble arm64 (read only) 2524524 2524524 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77696 77696 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150904 150904 0 0.0
.text 2111232 2111232 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2468552 2468552 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1431196 1431196 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1174032 1174032 0 0.0
bss 155557 155557 0 0.0
rodata 132640 132640 0 0.0
text 805076 805076 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1434068 1434068 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775996 775992 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119104 1119104 0 0.0
bss 154713 154713 0 0.0
rodata 109456 109456 0 0.0
text 774288 774288 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840840 840840 0 0.0
(read/write) 1764188 1764188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253717 1253717 0 0.0
.debug_aranges 111512 111512 0 0.0
.debug_frame 374904 374904 0 0.0
.debug_info 27928505 27928505 0 0.0
.debug_line 3797230 3797230 0 0.0
.debug_loc 3703986 3703986 0 0.0
.debug_ranges 365136 365136 0 0.0
.debug_str 3538246 3538246 0 0.0
.heap 840840 840840 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 583978 583978 0 0.0
.symtab 426848 426848 0 0.0
.text 1563296 1563296 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841648 841648 0 0.0
(read/write) 1704508 1704508 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189064 189064 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1239050 1239050 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 377240 377240 0 0.0
.debug_info 27474327 27474328 1 0.0
.debug_line 3804729 3804729 0 0.0
.debug_loc 3687187 3687187 0 0.0
.debug_ranges 363072 363072 0 0.0
.debug_str 3525368 3525368 0 0.0
.heap 841648 841648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 543218 543218 0 0.0
.symtab 411680 411680 0 0.0
.text 1504424 1504424 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849912 849912 0 0.0
(read/write) 1617564 1617564 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180968 180968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074348 1074348 0 0.0
.debug_aranges 102952 102952 0 0.0
.debug_frame 347520 347520 0 0.0
.debug_info 22832749 22832751 2 0.0
.debug_line 3357173 3357173 0 0.0
.debug_loc 3361963 3361963 0 0.0
.debug_ranges 321608 321608 0 0.0
.debug_str 3323961 3323961 0 0.0
.heap 849912 849912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478343 478343 0 0.0
.symtab 379312 379312 0 0.0
.text 1425744 1425744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 822136 822136 0 0.0
(read/write) 1674492 1674492 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208728 208728 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076296 1076296 0 0.0
.debug_aranges 103352 103352 0 0.0
.debug_frame 349260 349260 0 0.0
.debug_info 23084151 23084152 1 0.0
.debug_line 3359453 3359453 0 0.0
.debug_loc 3385878 3385878 0 0.0
.debug_ranges 324208 324208 0 0.0
.debug_str 3342472 3342472 0 0.0
.heap 822136 822136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 481740 481740 0 0.0
.symtab 381504 381504 0 0.0
.text 1454896 1454896 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152888 1152888 0 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 599984 599984 0 0.0
lock-app qpg6105+debug (read/write) 1121440 1121448 8 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568540 568548 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1023144 1023144 0 0.0
bss 98068 98068 0 0.0
text 692328 692326 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 958084 958084 0 0.0
bss 97120 97120 0 0.0
text 653368 653366 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 861992 861992 0 0.0
bss 89284 89284 0 0.0
text 583486 583486 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877856 877856 0 0.0
bss 89372 89372 0 0.0
text 597688 597688 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 956644 956644 0 0.0
bss 97500 97500 0 0.0
text 664172 664172 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 967996 967996 0 0.0
bss 101748 101748 0 0.0
text 671748 671748 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1024816 1024824 8 0.0
bss 99064 99064 0 0.0
text 707276 707278 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 916344 916344 0 0.0
bss 89936 89936 0 0.0
text 611490 611490 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890792 890792 0 0.0
bss 90296 90296 0 0.0
text 608214 608210 -4 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867408 867408 0 0.0
bss 89400 89400 0 0.0
text 589268 589266 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854660 854660 0 0.0
bss 89200 89200 0 0.0
text 579588 579590 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850448 850448 0 0.0
bss 89060 89060 0 0.0
text 574984 574984 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882000 882000 0 0.0
bss 90764 90764 0 0.0
text 599218 599216 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944352 944352 0 0.0
bss 99172 99172 0 0.0
text 650292 650290 -2 -0.0

@andy31415 andy31415 merged commit 1a4932a into project-chip:master Mar 25, 2023
@lebauce lebauce deleted the zap-download-source branch March 26, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lebauce @andy31415 @bzbarsky-apple