Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Attestation crash #25837

Merged

Conversation

joonhaengHeo
Copy link
Contributor

Fixes #25705

  1. Fix Attestation skid comparison. ( == -> Arrays.equals)
  2. Add AlertDialog exception handling, Added movement to the initial screen when an error occurs.

@github-actions
Copy link

PR #25837: Size comparison from ec2ad41 to 522dd23

Decreases (1 build for nrfconnect)
platform target config section ec2ad41 522dd23 change % change
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 776044 776040 -4 -0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section ec2ad41 522dd23 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645745 645745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933102 933102 0 0.0
.debug_aranges 87704 87704 0 0.0
.debug_frame 301604 301604 0 0.0
.debug_info 20309905 20309905 0 0.0
.debug_line 2680953 2680953 0 0.0
.debug_loc 2827596 2827596 0 0.0
.debug_ranges 286376 286376 0 0.0
.debug_str 3041114 3041114 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380555 380555 0 0.0
.symtab 257456 257456 0 0.0
.text 537672 537672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466536 2466536 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1429180 1429180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1174080 1174080 0 0.0
bss 155557 155557 0 0.0
rodata 132640 132640 0 0.0
text 805124 805124 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1119152 1119152 0 0.0
bss 154713 154713 0 0.0
rodata 109456 109456 0 0.0
text 774336 774336 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1434116 1434116 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 776044 776040 -4 -0.0
qpg lighting-app qpg6105+debug (read/write) 1152928 1152928 0 0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 600024 600024 0 0.0
lock-app qpg6105+debug (read/write) 1121504 1121504 0 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568604 568604 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit d81612c into project-chip:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [android] chip-tool crashs during commissioning
3 participants